Skip to content

Add RestorationManager disposals in test/services/restoration_test.dart.#135218

Merged
polina-c merged 4 commits intoflutter:masterfrom
ksokolovskyi:restoration-test-fix
Sep 21, 2023
Merged

Add RestorationManager disposals in test/services/restoration_test.dart.#135218
polina-c merged 4 commits intoflutter:masterfrom
ksokolovskyi:restoration-test-fix

Conversation

@ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented Sep 21, 2023

This PR adds RestorationManager objects disposal in test/services/restoration_test.dart.

Description

Tests

  • Updates test/services/restoration_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 21, 2023
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023
polina-c
polina-c requested changes Sep 21, 2023
View reviewed changes
packages/flutter/.vscode/settings.json Outdated
@@ -0,0 +1,3 @@
{
Copy link
Contributor

@polina-c polina-c Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this?

Copy link
Contributor Author

@ksokolovskyi ksokolovskyi Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry 🤦‍♂️, fixed.

Copy link
Contributor

@polina-c polina-c Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you wanted to delete your edit, but not the entire file :)

Copy link
Contributor Author

@ksokolovskyi ksokolovskyi Sep 21, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my local VSCode settings file, so I just deleted it.
Now all is fine :)

@polina-c polina-c merged commit 4204f07 into flutter:master Sep 21, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
5ff07a8 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
832cbab 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
9c11781 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
9e15e18 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
ac664f2 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 21, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 21, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
bcdfa36 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
0b5eac6 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
0996164 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
3a154e1 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
7e83c8c 
…_test.dart. (flutter/flutter#135218)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 22, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 22, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
f9e338e 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
40b86ec 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
029d377 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
6e720a6 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
7c053f4 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
2d7c130 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
7604f02 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
ab0b7cd 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
6e8cb98 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
5cb234f 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
0a5efdb 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
0e0b599 
…_test.dart. (flutter/flutter#135218)
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
7525cab 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
a81fbea 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
34883d0 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
0b62e5b 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
6634d7c 
…_test.dart. (flutter/flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
2d26cdc 
…_test.dart. (flutter/flutter#135218)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@ksokolovskyi @Mairramer
Add RestorationManager disposals in test/services/restoration_test.da…
cd6c1f6 
…rt. (flutter#135218)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
4204f07 Add RestorationManager disposals in test/services/restoration…
c389c1d 
…_test.dart. (flutter/flutter#135218)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restauration manager not disposed

2 participants

@ksokolovskyi @polina-c