Add a11y label to modal barrier by goderbauer · Pull Request #13543 · flutter/flutter

goderbauer · 2017-12-13T22:29:50Z

Breaking change announcement has been made here: https://groups.google.com/forum/#!topic/flutter-dev/FzUAHl2z4mo

@HansMuller for the integration of translations.

cbracken · 2017-12-13T22:35:16Z

packages/flutter_localizations/lib/src/l10n/material_ja.arb

  "timePickerHourModeAnnouncement": "時を選択",
-  "timePickerMinuteModeAnnouncement": "分を選択"
+  "timePickerMinuteModeAnnouncement": "分を選択",
+  "modalBarrierDismissLabel": "閉じる"


LGTM for Japanese.

cbracken · 2017-12-13T22:35:28Z

packages/flutter_localizations/lib/src/l10n/material_fr.arb

  "timePickerHourModeAnnouncement": "Sélectionnez les heures",
-  "timePickerMinuteModeAnnouncement": "Sélectionnez les minutes"
+  "timePickerMinuteModeAnnouncement": "Sélectionnez les minutes",
+  "modalBarrierDismissLabel": "Ignorer"


LGTM for French.

Hixie · 2017-12-13T23:10:47Z

packages/flutter/lib/src/widgets/modal_barrier.dart

+  /// See also:
+  ///
+  ///  * [ModalRoute.barrierLabel], which controls this property for the
+  ///    [ModalBarrier] built by [ModalRoute] pages.


maybe see also something that tells you what a semantics label is? :-)

Hixie · 2017-12-13T23:11:18Z

packages/flutter/lib/src/widgets/modal_barrier.dart

+          behavior: HitTestBehavior.opaque,
+          child: new Semantics(
+            label: semanticsDismissable ? semanticsLabel : null,
+            textDirection: semanticsDismissable ? Directionality.of(context) : null,


start the build method with an assert that calls debugCheckHasDirectionality or whatever it's called

Hixie · 2017-12-13T23:11:29Z

packages/flutter/lib/src/widgets/modal_barrier.dart

+  ///
+  ///  * [ModalRoute.barrierLabel], which controls this property for the
+  ///    [ModalBarrier] built by [ModalRoute] pages.
+  final String semanticsLabel;


ditto earlier comment

Hixie · 2017-12-13T23:12:08Z

packages/flutter/test/material/dialog_test.dart

+        DefaultWidgetsLocalizations.delegate,
+        DefaultMaterialLocalizations.delegate,
+      ],
+      child: new Directionality(


you can remove the Directionality, Localizations adds one

Hixie · 2017-12-13T23:12:13Z

packages/flutter/test/material/dropdown_test.dart

+      ],
+      child: new MediaQuery(
+        data: new MediaQueryData.fromWindow(window),
+        child: new Directionality(


This one is awkward to remove. The test verifies that things work with different textDirections. While Localizations does provide a text direction, I cannot modify it directly. I could rewrite the test to work on different locales instead, but I think that would hide the real purpose of the test (which is to make sure that different text directions work). Therefore, I left the Directionality widget in the tree.

that's fine. i didn't notice it was being tweaked.

Hixie · 2017-12-13T23:12:48Z

packages/flutter_localizations/lib/src/l10n/material_en.arb

+
+  "modalBarrierDismissLabel": "Dismiss",
+  "@modalBarrierDismissLabel": {
+    "description": "Accessibility label used to annotate a dismissible modal barrier."


give an example, e.g. "as seen behind a popup dialog box" or something

HansMuller

You need to update flutter_localizations/lib/src/l10n/localizaions.dart, see https://github.com/flutter/flutter/blob/master/dev/tools/gen_localizations.dart

You just have to run:

dart dev/tools/gen_localizations.dart --overwrite

HansMuller · 2017-12-13T23:11:11Z

packages/flutter_localizations/lib/src/l10n/material_de_CH.arb

  "selectedRowCountTitleOther": "$selectedRowCount Elemente ausgewählt",
  "cancelButtonLabel": "ABBRECHEN",
-  "closeButtonLabel": "SCHLIEẞEN",
+  "closeButtonLabel": "SCHLIESSEN",


I have been trying to get the internal translations team to update this value (with little success). Your change may be reverted when the next translations update happens.

HansMuller · 2017-12-13T23:14:39Z

packages/flutter_localizations/lib/src/l10n/material_en.arb

+
+  "modalBarrierDismissLabel": "Dismiss",
+  "@modalBarrierDismissLabel": {
+    "description": "Accessibility label used to annotate a dismissible modal barrier."


This description will probably not help translators. You could include some of the text you wrote for routes.dart.

goderbauer · 2017-12-14T00:40:12Z

Addressed all comments. PTAL.

Hixie · 2017-12-14T23:01:49Z

goderbauer added 2 commits December 13, 2017 14:23

Add a11y label to modal barrier

2099c79

minor fixes

2168534

googlebot added the cla: yes label Dec 13, 2017

cbracken reviewed Dec 13, 2017

View reviewed changes

Hixie reviewed Dec 13, 2017

View reviewed changes

HansMuller reviewed Dec 13, 2017

View reviewed changes

goderbauer added 2 commits December 13, 2017 16:36

review feedback

1bf39bc

wording

e27b222

goderbauer added 3 commits December 13, 2017 16:48

fix import

16c89d6

fix analyzer warning

2696209

++

d1b9aa0

goderbauer merged commit f9cf5a1 into flutter:master Dec 14, 2017

goderbauer deleted the barrierLabel branch December 14, 2017 23:05

goderbauer added the a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) label Mar 5, 2018

HansMuller mentioned this pull request Mar 8, 2018

Roll localizations #15269

Merged

DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018

Add a11y label to modal barrier (flutter#13543)

1fb1430

DaveShuckerow mentioned this pull request Aug 7, 2018

Process: checking that all strings are translated before a release of the Flutter Gallery #20271

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021

Conversation

goderbauer commented Dec 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HansMuller left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Dec 14, 2017

Uh oh!

Hixie commented Dec 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

goderbauer commented Dec 13, 2017 •

edited

Loading

HansMuller left a comment •

edited

Loading