Add device ready check by ricardoamador · Pull Request #135526 · flutter/flutter

ricardoamador · 2023-09-26T20:47:16Z

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.
Fixes #121420

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…device.

dev/devicelab/lib/framework/devices.dart

godofredoc · 2023-09-29T19:03:37Z

dev/devicelab/lib/framework/devices.dart

+    print('Waiting for device.');
+    final String waitOut = await adb(<String>['wait-for-device']);
+    print(waitOut);
+    const RetryOptions retryOptions = RetryOptions(delayFactor: Duration(seconds: 1), maxAttempts: 30, maxDelay: Duration(minutes: 1));


Can this be translated to a one liner like https://cs.opensource.google/flutter/recipes/+/master:recipe_modules/android_virtual_device/resources/avd_setup.sh;l=15?

I tried that but the android shell would not run it. This is also a safer method as this will not potentially loop forever.

… long.

godofredoc · 2023-09-29T20:33:17Z

For this change can we take a snapshot of the android flakiness now to compare after this change lands?

ricardoamador · 2023-09-29T20:35:44Z

Do you mean a snapshot as in record all the current android flakes? That can be done via the CiYaml correct? As we record the open issues for flakes directly in that file?

godofredoc · 2023-09-29T20:39:10Z

Do you mean a snapshot as in record all the current android flakes? That can be done via the CiYaml correct? As we record the open issues for flakes directly in that file?

Nope, I meant a screenshot of the flakiness dashboard for devicelab android

ricardoamador · 2023-09-29T20:39:35Z

Ahhh okay. Yeah will do.

ricardoamador · 2023-09-29T20:46:14Z

Top Flaky Prod Builders last 90 days

Top Flaky Try Builders last 90 days

ricardoamador · 2023-09-29T20:49:32Z

The top flaky test over the past 90 days:

ricardoamador · 2023-09-29T21:07:30Z

Top flaky linux android prod tasks by tags last 90 days:

Top flaky linux android try tasks by tags last 90 days:

dev/devicelab/lib/framework/devices.dart

Co-authored-by: Christopher Fujino <[email protected]>

christopherfujino

LGTM thanks!

Add type annotation for Future.delayed.

flutter/flutter@57b5c3c...d3df8f6 2023-09-30 [email protected] Roll Flutter Engine from 68fc1a567195 to 01fc3c6624ce (1 revision) (flutter/flutter#135808) 2023-09-30 [email protected] Roll Flutter Engine from 4ed733d99cd5 to 68fc1a567195 (1 revision) (flutter/flutter#135807) 2023-09-30 [email protected] Roll Flutter Engine from d814c69abe26 to 4ed733d99cd5 (1 revision) (flutter/flutter#135801) 2023-09-30 [email protected] Roll Flutter Engine from f726438d4d65 to d814c69abe26 (1 revision) (flutter/flutter#135799) 2023-09-30 [email protected] Roll Flutter Engine from 0b96a82cc874 to f726438d4d65 (1 revision) (flutter/flutter#135796) 2023-09-30 [email protected] Roll Flutter Engine from f3a4cab69962 to 0b96a82cc874 (1 revision) (flutter/flutter#135793) 2023-09-30 [email protected] Roll Flutter Engine from e719b7957763 to f3a4cab69962 (2 revisions) (flutter/flutter#135792) 2023-09-30 [email protected] Roll Flutter Engine from 8939f9c1f4e4 to e719b7957763 (2 revisions) (flutter/flutter#135789) 2023-09-30 [email protected] Roll Flutter Engine from 6a13607008ed to 8939f9c1f4e4 (1 revision) (flutter/flutter#135788) 2023-09-30 [email protected] Add device ready check (flutter/flutter#135526) 2023-09-30 [email protected] Temporarily disable NexusLowRes, version=29 (flutter/flutter#135785) 2023-09-30 [email protected] Cover more test/widgets tests with leak tracking #12. (flutter/flutter#135385) 2023-09-30 [email protected] DraggableScrollableController should dispatch creation in constructor. (flutter/flutter#135423) 2023-09-30 [email protected] Roll Flutter Engine from d203e349781c to 6a13607008ed (2 revisions) (flutter/flutter#135780) 2023-09-29 [email protected] Roll Flutter Engine from 48973d7f9beb to d203e349781c (5 revisions) (flutter/flutter#135776) 2023-09-29 [email protected] ViewportOffset should dispatch creation in constructor. (flutter/flutter#135420) 2023-09-29 [email protected] Use platform dill from the engine when compiling with dart2wasm. (flutter/flutter#134970) 2023-09-29 [email protected] Roll Flutter Engine from d5fcd78a879b to 48973d7f9beb (5 revisions) (flutter/flutter#135765) 2023-09-29 [email protected] Upgrade leak_tracker to fix flackiness. (flutter/flutter#135760) 2023-09-29 [email protected] Roll Flutter Engine from c52251a8b2d0 to d5fcd78a879b (2 revisions) (flutter/flutter#135755) 2023-09-29 [email protected] Update `Drawer` tests for M2/M3 (flutter/flutter#135752) 2023-09-29 [email protected] Expose onAttach and onDetach in ScrollController subclasses (flutter/flutter#135721) 2023-09-29 [email protected] Update the wasm bootstrap to allow access to the emscripten wrapper to skwasm. (flutter/flutter#135723) 2023-09-29 [email protected] Update logic for getting `Analytics` instance from package:unified_analytics (flutter/flutter#134756) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter#121420 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

Ricardo Amador added 30 commits March 3, 2023 11:49

Adding changes to test.

a31b34c

Put in output to make sure code is getting run.

01c646d

Add the wait in the actual methods not in each test.

a1a15a8

Device state is not being caught correctly.

d3def3c

Fixing the regex to find the state.

479c856

Test change

18623f2

Merge master

cae0438

Adding awaitDevice to android device.

3b5a685

Reopening pull request.

f34464d

syntax.

3e7d3c5

Adding a sleep as device may not be active.

374c383

Print stdout since return code is incorrect from process.

193a59a

Trying to get output.

380f87f

Remove 10 second wait.

5ae691b

Switch to for loop

96f2753

Use for loop with raw string.

c2b47d6

Remove raw string

ad81a61

Update to make it fail to make sure it produces output.

9d58261

Update to add exit code.

2507f53

Return stderr

1013452

Do not use process.

edcbc1d

Update to try exec.

0eed699

Return to use adb.

d952de3

Splitting command into two different calls.

2147269

Add the shell command to an adb call.

9d7292d

separate shell

01c63a6

Updated to fix escaping

673b9bb

Updated to test simpler command

dbd6a0e

Updated logic to have dart loop.

0f24b13

Updated to support other tests that uninstall a file from an android …

946cdea

…device.

ricardoamador marked this pull request as ready for review September 29, 2023 18:34

godofredoc reviewed Sep 29, 2023

View reviewed changes

dev/devicelab/lib/framework/devices.dart Show resolved Hide resolved

godofredoc reviewed Sep 29, 2023

View reviewed changes

Reduce the number of attempts for the wait as it will run for far too…

3424ba2

… long.

godofredoc approved these changes Sep 29, 2023

View reviewed changes

christopherfujino reviewed Sep 29, 2023

View reviewed changes

dev/devicelab/lib/framework/devices.dart Outdated Show resolved Hide resolved

ricardoamador and others added 2 commits September 29, 2023 16:29

Update dev/devicelab/lib/framework/devices.dart

cab148c

Co-authored-by: Christopher Fujino <[email protected]>

Merge branch 'master' into add_device_ready_check

5703c73

christopherfujino approved these changes Sep 29, 2023

View reviewed changes

Update devices.dart

b1a2172

Add type annotation for Future.delayed.

ricardoamador added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 30, 2023

auto-submit bot merged commit 4e5e47e into flutter:master Sep 30, 2023

engine-flutter-autoroll mentioned this pull request Sep 30, 2023

Roll Flutter from 57b5c3cda000 to 8e3b7a9cb5d1 (22 revisions) flutter/packages#5041

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023

4e5e47e Add device ready check (flutter/flutter#135526)

f0821b7

engine-flutter-autoroll mentioned this pull request Sep 30, 2023

Roll Flutter from 57b5c3cda000 to 0a8963095468 (23 revisions) flutter/packages#5042

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023

4e5e47e Add device ready check (flutter/flutter#135526)

0ea86a0

engine-flutter-autoroll mentioned this pull request Sep 30, 2023

Roll Flutter from 57b5c3cda000 to d3df8f6bbf74 (24 revisions) flutter/packages#5043

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 30, 2023

4e5e47e Add device ready check (flutter/flutter#135526)

287c327

ricardoamador deleted the add_device_ready_check branch February 5, 2024 18:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add device ready check#135526

Add device ready check#135526
auto-submit[bot] merged 37 commits intoflutter:masterfrom
ricardoamador:add_device_ready_check

ricardoamador commented Sep 26, 2023 •

edited

Loading

Uh oh!

Uh oh!

godofredoc Sep 29, 2023

Uh oh!

ricardoamador Sep 29, 2023 •

edited

Loading

Uh oh!

godofredoc commented Sep 29, 2023

Uh oh!

ricardoamador commented Sep 29, 2023

Uh oh!

godofredoc commented Sep 29, 2023

Uh oh!

ricardoamador commented Sep 29, 2023

Uh oh!

ricardoamador commented Sep 29, 2023 •

edited

Loading

Uh oh!

ricardoamador commented Sep 29, 2023

Uh oh!

ricardoamador commented Sep 29, 2023

Uh oh!

Uh oh!

christopherfujino left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ricardoamador commented Sep 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

godofredoc Sep 29, 2023

Choose a reason for hiding this comment

Uh oh!

ricardoamador Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

godofredoc commented Sep 29, 2023

Uh oh!

ricardoamador commented Sep 29, 2023

Uh oh!

godofredoc commented Sep 29, 2023

Uh oh!

ricardoamador commented Sep 29, 2023

Uh oh!

ricardoamador commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ricardoamador commented Sep 29, 2023

Uh oh!

ricardoamador commented Sep 29, 2023

Uh oh!

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ricardoamador commented Sep 26, 2023 •

edited

Loading

ricardoamador Sep 29, 2023 •

edited

Loading

ricardoamador commented Sep 29, 2023 •

edited

Loading