Skip to content

Reverts "Upload generated frame-request-pending stats"#135668

Closed
auto-submit[bot] wants to merge 1 commit intomainfrom
revert_dd341d4295416f559b971fa58583a8efacfd376c
Closed

Reverts "Upload generated frame-request-pending stats"#135668
auto-submit[bot] wants to merge 1 commit intomainfrom
revert_dd341d4295416f559b971fa58583a8efacfd376c

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Sep 28, 2023

Reverts #135645
Initiated by: zanderso
This change reverts the following previous change:
These values are generated since #135279, but I didn't know to add the new keys to this list to get them to upload.

Part of #129150

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Sep 28, 2023
@auto-submit auto-submit bot removed the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Sep 28, 2023
@auto-submit
Copy link
Contributor Author

auto-submit bot commented Sep 28, 2023

auto label is removed for flutter/flutter/135668, Failed to merge flutter/flutter/135668 with Pull request flutter/flutter/135668 could not be merged: You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more information..

@zanderso
Copy link
Member

zanderso commented Sep 28, 2023

cc @moffatman @jonahwilliams

@zanderso
Copy link
Member

zanderso commented Sep 28, 2023

Failures on CI like https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20animated_complex_image_filtered_perf__e2e_summary/4951/overview

@zanderso zanderso self-requested a review September 28, 2023 13:39
@zanderso zanderso mentioned this pull request Sep 28, 2023
Closed
moffatman
moffatman approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@moffatman moffatman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso zanderso closed this Sep 28, 2023
@guidezpl guidezpl deleted the revert_dd341d4295416f559b971fa58583a8efacfd376c branch April 18, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moffatman moffatman moffatman approved these changes

@zanderso zanderso zanderso approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@zanderso zanderso

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zanderso @moffatman @fluttergithubbot