Skip to content

Provide parameter to Icon and IconThemeData for they to consider the context's text scaler#135708

Merged
auto-submit[bot] merged 8 commits intoflutter:masterfrom
mateusfccp:icon_text_scale_factor
Nov 29, 2023
Merged

Provide parameter to Icon and IconThemeData for they to consider the context's text scaler#135708
auto-submit[bot] merged 8 commits intoflutter:masterfrom
mateusfccp:icon_text_scale_factor

Conversation

@mateusfccp
Copy link
Contributor

@mateusfccp mateusfccp commented Sep 28, 2023

Provide a parameter applyTextScaling to both Icon and IconDataTheme. When true, the context's TextScaler will apply it's scale method to the icon size.

Fixes #115466

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icon widget does not scale with textScaleFactor

4 participants