Skip to content

[web] Use Layer.toImage for CanvasKit golden tests#135711

Closed
harryterkelsen wants to merge 8 commits intoflutter:masterfrom
harryterkelsen:canvaskit-golden-screenshot2
Closed

[web] Use Layer.toImage for CanvasKit golden tests#135711
harryterkelsen wants to merge 8 commits intoflutter:masterfrom
harryterkelsen:canvaskit-golden-screenshot2

Conversation

@harryterkelsen
Copy link
Contributor

@harryterkelsen harryterkelsen commented Sep 28, 2023

This is the same as #135249 but in a fresh PR to try to fix cache issues in Skia Gold.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 28, 2023

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. labels Sep 28, 2023
@goderbauer goderbauer mentioned this pull request Oct 10, 2023
Merged
8 tasks
@Piinks
Copy link
Contributor

Piinks commented Oct 17, 2023

(triage) Hey @harryterkelsen what's the status of this PR? Looks like it needs some tests and CI is unhappy.

@harryterkelsen
Copy link
Contributor Author

harryterkelsen commented Oct 18, 2023

Closing. This was an attempt to get the kick google testing into starting another run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@harryterkelsen @Piinks