It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

test-exempt: code refactor with no semantic change

auto label is removed for flutter/flutter/135886, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

• Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

Wow, super smart.

BTW, I just realised a list will be created anyway here:

    Overlay.of(context, rootOverlay: true, debugRequiredFor: debugRequiredFor)
        .insertAll(<OverlayEntry>[_handles!.start, _handles!.end]);

Could be eliminated with two calls I guess:

    Overlay.of(context, rootOverlay: true, debugRequiredFor: debugRequiredFor)
        ..insert(_handles!.start)
        ..insert(_handles!.end);

I think I'm going to make an AI parser that identifies if there is a place elsewhere in the codebase that could be improved.