implemented leadingWidth and automaticallyImplyLeading options #136165
Merged
auto-submit[bot] merged 24 commits intoflutter:masterfrom Nov 29, 2023
Merged
implemented leadingWidth and automaticallyImplyLeading options #136165auto-submit[bot] merged 24 commits intoflutter:masterfrom
auto-submit[bot] merged 24 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
framework
|
Exactly what I'm looking for. Thanks! |
Closed
2 tasks
Contributor
|
LGTM |
HansMuller
added
the
a: text input
| /// See also: | ||
| /// | ||
| /// * [AppBar.leadingWidth], which is controlled by this property. | ||
| double? leadingWidth; |
Contributor
There was a problem hiding this comment.
Would /// {@macro flutter.material.appbar.leadingWidth} be sufficient here? What do you think?
Contributor
There was a problem hiding this comment.
Looks like the documentation here is exactly the same as what is in "flutter.material.appbar.leadingWidth"? If that's the case could you use the dartdoc macro suggested above?
Contributor
|
Hi @VB10 thank you for your contribution! This looks like a reasonable change to me. I had a few comments regarding the tests and some of the documentation. |
…view comment" This reverts commit e443331.
Contributor
Author
@Renzo-Olivares Thank you for all your comments. With your review, I've added fixes. |
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
Thanks for making those changes quickly @VB10! Had a few small comments.
Contributor
Author
|
@Renzo-Olivares thank you your feedback. I updated this pr. |
Contributor
|
Hi @VB10 sorry for the delay, I made some small comments but this should be ready to go after addressing those comments. |
Contributor
|
(could you also sync the branch to rerun Google testing?) |
Contributor
Author
|
@Renzo-Olivares i've updated branch wit your comment and @LongCatIsLooong i've updated from master. Thank you for support. |
Renzo-Olivares
approved these changes
Nov 28, 2023
Contributor
Renzo-Olivares
left a comment
Renzo-Olivares
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution and for making all those changes @VB10
Renzo-Olivares
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 29, 2023
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 29, 2023
Roll Flutter from 6bf3ccd to 5e5b529 (58 revisions) flutter/flutter@6bf3ccd...5e5b529 2023-11-29 [email protected] Roll Flutter Engine from 60b963930202 to 222beb28a8eb (2 revisions) (flutter/flutter#139242) 2023-11-29 [email protected] Roll Flutter Engine from eebbe7e15c7d to 60b963930202 (2 revisions) (flutter/flutter#139237) 2023-11-29 [email protected] Roll Packages from 3c05466 to e4aaba8 (5 revisions) (flutter/flutter#139232) 2023-11-29 [email protected] Update VelocityTracker (4) (flutter/flutter#139166) 2023-11-29 [email protected] Analyze against using Stopwatches in the framework (flutter/flutter#138507) 2023-11-29 [email protected] Roll Flutter Engine from ecc9c7b6be7d to eebbe7e15c7d (1 revision) (flutter/flutter#139225) 2023-11-29 [email protected] Roll Flutter Engine from 28aae2d29822 to ecc9c7b6be7d (1 revision) (flutter/flutter#139210) 2023-11-29 [email protected] Improve documentation of CardTheme.shape (flutter/flutter#139096) 2023-11-29 [email protected] Simplify devicelab logic and fix tests (flutter/flutter#139122) 2023-11-29 [email protected] implemented leadingWidth and automaticallyImplyLeading options (flutter/flutter#136165) 2023-11-29 [email protected] TextField and TextFormField can use a MaterialStatesController (flutter/flutter#133977) 2023-11-29 [email protected] Provide parameter to Icon and IconThemeData for they to consider the context's text scaler (flutter/flutter#135708) 2023-11-29 [email protected] Roll Flutter Engine from be4d7c8b760c to 28aae2d29822 (1 revision) (flutter/flutter#139204) 2023-11-29 [email protected] Update `ButtonStyleButton.scaledPadding` documentation. Migrate callers in flutter/flutter (flutter/flutter#139014) 2023-11-29 [email protected] Roll Flutter Engine from de99c71c598f to be4d7c8b760c (1 revision) (flutter/flutter#139199) 2023-11-29 [email protected] Roll Flutter Engine from 9a840e8dba40 to de99c71c598f (2 revisions) (flutter/flutter#139195) 2023-11-29 [email protected] Roll Flutter Engine from fbb2b1e880fa to 9a840e8dba40 (1 revision) (flutter/flutter#139192) 2023-11-29 [email protected] Roll Flutter Engine from 4beaa1195b74 to fbb2b1e880fa (1 revision) (flutter/flutter#139191) 2023-11-29 [email protected] Roll Flutter Engine from 570fec4fa92c to 4beaa1195b74 (3 revisions) (flutter/flutter#139190) 2023-11-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add platform view wide gamut test" (flutter/flutter#139189) 2023-11-28 [email protected] Move analysis test to shard tests. (flutter/flutter#139161) 2023-11-28 [email protected] Write Tests for API Examples of `snack_bar.0`, `elevated_button.0`, `stepper.0`, `radio.0`, `filled_button.0`, `outlined_button.0` & `card.0` (flutter/flutter#138987) 2023-11-28 [email protected] Implement `switch` expressions in `dev/` (flutter/flutter#139048) 2023-11-28 [email protected] Roll Flutter Engine from 01fcec7214db to 570fec4fa92c (2 revisions) (flutter/flutter#139178) 2023-11-28 [email protected] Fix comment (flutter/flutter#138973) 2023-11-28 [email protected] Added some documentation for OverlayPortal (flutter/flutter#138934) 2023-11-28 [email protected] feature(table-widget): Added intrinsicHeight to TableCellVerticalAlignment enum. (flutter/flutter#130264) 2023-11-28 [email protected] Roll Flutter Engine from 97ede154dcd8 to 01fcec7214db (1 revision) (flutter/flutter#139172) 2023-11-28 [email protected] Ensure Icon vertically centers its icon glyph. (flutter/flutter#138937) 2023-11-28 [email protected] Roll Flutter Engine from fd3a33f8b239 to 97ede154dcd8 (2 revisions) (flutter/flutter#139168) 2023-11-28 [email protected] Roll Flutter Engine from d375d5b95d59 to fd3a33f8b239 (2 revisions) (flutter/flutter#139163) 2023-11-28 [email protected] Roll Flutter Engine from e4b18fa3661e to d375d5b95d59 (2 revisions) (flutter/flutter#139157) 2023-11-28 [email protected] Added keyboardType & textInputAction props to SearchBar, SearchAnchor & SearchAnchor.bar (flutter/flutter#138553) 2023-11-28 [email protected] Fix header formatting typo in PopupMenuButton docs (flutter/flutter#139084) 2023-11-28 [email protected] Fix turbulence seed for all tests with ink sparkles (flutter/flutter#138757) 2023-11-28 [email protected] Renable macOS 13 tests (flutter/flutter#139083) 2023-11-28 [email protected] Roll Flutter Engine from 8715e9b9119d to e4b18fa3661e (1 revision) (flutter/flutter#139142) 2023-11-28 [email protected] Roll Packages from e774e88 to 3c05466 (2 revisions) (flutter/flutter#139140) 2023-11-28 [email protected] Roll Flutter Engine from 6ad827e9a71b to 8715e9b9119d (1 revision) (flutter/flutter#139136) 2023-11-28 [email protected] Roll Flutter Engine from c18d3df967dc to 6ad827e9a71b (1 revision) (flutter/flutter#139135) 2023-11-28 [email protected] Roll Flutter Engine from 1caa7478db0d to c18d3df967dc (1 revision) (flutter/flutter#139133) 2023-11-28 [email protected] Roll Flutter Engine from 4f217e1f9afe to 1caa7478db0d (1 revision) (flutter/flutter#139129) 2023-11-28 [email protected] Fix textScalerOf and maybeTextScalerOf documentations (flutter/flutter#139123) 2023-11-28 [email protected] Roll Flutter Engine from c25cc65720de to 4f217e1f9afe (1 revision) (flutter/flutter#139126) 2023-11-28 [email protected] Roll Flutter Engine from 3381d3ff0df7 to c25cc65720de (1 revision) (flutter/flutter#139121) 2023-11-28 [email protected] Roll Flutter Engine from 96137d05fabc to 3381d3ff0df7 (4 revisions) (flutter/flutter#139119) ...
caseycrogers
pushed a commit
to caseycrogers/flutter
that referenced
this pull request
Dec 29, 2023
…er#136165) Before:  After:   Fixed flutter#136164
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
Fixed #136164
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.