Skip to content

[leak-tracking] Add more leak tracking in test/painting #3#136170

Merged
polina-c merged 15 commits intoflutter:masterfrom
droidbg:leak-tracking-painting-3
Nov 3, 2023
Merged

[leak-tracking] Add more leak tracking in test/painting #3#136170
polina-c merged 15 commits intoflutter:masterfrom
droidbg:leak-tracking-painting-3

Conversation

@droidbg
Copy link
Contributor

@droidbg droidbg commented Oct 8, 2023

Description

This PR changes more testWidgets by testWidgetsWithLeakTracking in flutter/test/paintings tests according to the dart-lang/leak_tracker#134.

Tests

  • Updates paint_image_test.dart to use testWidgetsWithLeakTracking.
  • Updates star_border_test.dart to use testWidgetsWithLeakTracking.
  • Updates system_fonts_test.dart to use testWidgetsWithLeakTracking.
  • Updates text_span_test.dart to use testWidgetsWithLeakTracking.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Oct 8, 2023
@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Oct 9, 2023
polina-c
polina-c requested changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@polina-c polina-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are leaking:

  Expected: leak free
    Actual: <Instance of 'Leaks'>
     Which: contains leaks:
            # The text is generated by leak_tracker.
            # For leak troubleshooting tips open:
            # https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md
            notDisposed:
              total: 3
              objects:
                FixedExtentScrollController:
                  test: CupertinoDatePicker reset cache upon system fonts change - time mode
                  identityHashCode: 66617359
                FixedExtentScrollController:
                  test: CupertinoDatePicker reset cache upon system fonts change - time mode
                  identityHashCode: 431776689
                FixedExtentScrollController:
                  test: CupertinoDatePicker reset cache upon system fonts change - time mode
                  identityHashCode: 478452384

@github-actions github-actions bot added the f: cupertino flutter/packages/flutter/cupertino repository label Oct 10, 2023
@droidbg
Copy link
Contributor Author

droidbg commented Oct 10, 2023

@polina-c could you help me in this, why it is failing, what needs to changed?

@ksokolovskyi
Copy link
Contributor

ksokolovskyi commented Oct 10, 2023

Hi, @droidbg!
To detect where exactly not disposed FixedExtentScrollController gets created, you can add
leakTrackingTestConfig: LeakTrackingTestConfig.debugNotDisposed() after the body of the CupertinoDatePicker reset cache upon system fonts change - time mode test:

testWidgetsWithLeakTracking(
   'CupertinoDatePicker reset cache upon system fonts change - time mode',
   (WidgetTester tester) async {
   ...
   },
   leakTrackingTestConfig: LeakTrackingTestConfig.debugNotDisposed(),
);

@polina-c
Copy link
Contributor

polina-c commented Oct 10, 2023

@polina-c could you help me in this, why it is failing, what needs to changed?

Did you check the link on top of the message: https://github.com/dart-lang/leak_tracker/blob/main/doc/TROUBLESHOOT.md?

It should help. If it does not, I want to understand how to improve it to make it helping. Can you help me here?

polina-c
polina-c requested changes Oct 10, 2023
View reviewed changes
@polina-c polina-c requested review from LongCatIsLooong and TahaTesser and removed request for LongCatIsLooong and TahaTesser October 11, 2023 19:02
@droidbg droidbg marked this pull request as draft October 12, 2023 01:04
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 12, 2023

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@droidbg droidbg marked this pull request as ready for review October 12, 2023 02:50
@droidbg droidbg mentioned this pull request Oct 21, 2023
Closed
@HansMuller HansMuller mentioned this pull request Nov 3, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
88f3e15 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
95a1b7c 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
485380c 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 4, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
3ee71e2 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
e01759f 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
73b2028 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
ad03aaa 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
76cb9ba 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
3dc532c 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
2d8f57b 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
396fbe7 
…er#3 (flutter/flutter#136170)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 6, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
4c827da 
…er#3 (flutter/flutter#136170)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
Roll Flutter from 29b2516 to f5a9835 (101 revisions) (#5341)
be18d28 
Roll Flutter from 29b2516 to f5a9835 (101 revisions)

flutter/flutter@29b2516...f5a9835

2023-11-06 [email protected] Check sample links for malformed links (flutter/flutter#137807)
2023-11-06 [email protected] Change cast in json parsing (flutter/flutter#137708)
2023-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update BottomNavigationBar tests for M3" (flutter/flutter#137948)
2023-11-06 [email protected] Roll Packages from cccf5d2 to 49eac1f (2 revisions) (flutter/flutter#137943)
2023-11-06 [email protected] Update BottomNavigationBar tests for M3 (flutter/flutter#136624)
2023-11-06 [email protected] Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (flutter/flutter#137941)
2023-11-06 [email protected] Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (flutter/flutter#137935)
2023-11-06 [email protected] Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (flutter/flutter#137611)
2023-11-06 [email protected] Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (flutter/flutter#137933)
2023-11-06 [email protected] Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (flutter/flutter#137837)
2023-11-06 [email protected] Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (flutter/flutter#137921)
2023-11-06 [email protected] Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (flutter/flutter#137920)
2023-11-05 [email protected] Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (flutter/flutter#137914)
2023-11-05 [email protected] Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (flutter/flutter#137912)
2023-11-05 [email protected] Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (flutter/flutter#137908)
2023-11-04 [email protected] Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (flutter/flutter#137904)
2023-11-04 [email protected] Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (flutter/flutter#137903)
2023-11-04 [email protected] Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (flutter/flutter#137900)
2023-11-04 [email protected] Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (flutter/flutter#137898)
2023-11-04 [email protected] Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (flutter/flutter#137892)
2023-11-04 [email protected] Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (flutter/flutter#137887)
2023-11-04 [email protected] HeroController should dispatch creation and disposal events. (flutter/flutter#137835)
2023-11-04 [email protected] Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (flutter/flutter#137877)
2023-11-03 [email protected] InheritedElement.removeDependent() (flutter/flutter#129210)
2023-11-03 [email protected] Remove unused generic type from BottomSheet (flutter/flutter#137791)
2023-11-03 [email protected] Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (flutter/flutter#137872)
2023-11-03 [email protected] Pin dart-lang/native dependencies (flutter/flutter#137601)
2023-11-03 [email protected] Send caret rect to embedder on selection update (flutter/flutter#137863)
2023-11-03 [email protected] Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (flutter/flutter#137871)
2023-11-03 [email protected] Tooltip docs: Recommend setting preferBelow to false in theme (flutter/flutter#135879)
2023-11-03 [email protected] Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) (flutter/flutter#137861)
2023-11-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Support Android 34" (flutter/flutter#137865)
2023-11-03 [email protected] InkFeature should dispatch creation and disposal events. (flutter/flutter#137793)
2023-11-03 [email protected] AppLifecycleListener should dispatch creation and disposal events. (flutter/flutter#137840)
2023-11-03 [email protected] Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) (flutter/flutter#137858)
2023-11-03 [email protected] Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) (flutter/flutter#137857)
2023-11-03 [email protected] Updated the nested navigation NavigationBar example (flutter/flutter#137788)
2023-11-03 [email protected] Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) (flutter/flutter#137853)
2023-11-03 [email protected] Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) (flutter/flutter#137847)
2023-11-03 [email protected] Roll flutter gallery version forward. (flutter/flutter#137846)
2023-11-03 [email protected] Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (flutter/flutter#137845)
2023-11-03 [email protected] Roll Packages from 33c2b4e to cccf5d2 (6 revisions) (flutter/flutter#137841)
2023-11-03 [email protected] [web] dispatch corresponding keyup events in text editing integrations (flutter/flutter#136874)
2023-11-03 [email protected] [leak-tracking] Add more leak tracking in test/painting #3 (flutter/flutter#136170)
2023-11-03 [email protected] Upgrade leak_tracker and remove some deps in allow list. (flutter/flutter#137806)
2023-11-03 [email protected] Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (flutter/flutter#137827)
...
@droidbg droidbg deleted the leak-tracking-painting-3 branch November 13, 2023 01:43
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
8e7fce9 [leak-tracking] Add more leak tracking in test/painting flutt…
9c248de 
…er#3 (flutter/flutter#136170)
dko5ki23t pushed a commit to dko5ki23t/google_maps_flutter_improved that referenced this pull request May 24, 2025
@engine-flutter-autoroll
Roll Flutter from 29b25165cab8 to f5a983535131 (101 revisions) (#5341)
186c4e0 
Roll Flutter from 29b25165cab8 to f5a983535131 (101 revisions)

flutter/flutter@29b2516...f5a9835

2023-11-06 [email protected] Check sample links for malformed links (flutter/flutter#137807)
2023-11-06 [email protected] Change cast in json parsing (flutter/flutter#137708)
2023-11-06 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Update BottomNavigationBar tests for M3" (flutter/flutter#137948)
2023-11-06 [email protected] Roll Packages from cccf5d24d703 to 49eac1fec6c7 (2 revisions) (flutter/flutter#137943)
2023-11-06 [email protected] Update BottomNavigationBar tests for M3 (flutter/flutter#136624)
2023-11-06 [email protected] Roll Flutter Engine from 4f6ed31bd8bd to bdfa8aa8f81f (1 revision) (flutter/flutter#137941)
2023-11-06 [email protected] Roll Flutter Engine from b9b3269b0b2c to 4f6ed31bd8bd (2 revisions) (flutter/flutter#137935)
2023-11-06 [email protected] Provide a helpful error message when `ColorScheme.brightness` doesn't match `ThemeData.brightness` (flutter/flutter#137611)
2023-11-06 [email protected] Roll Flutter Engine from 555ffa17b55c to b9b3269b0b2c (1 revision) (flutter/flutter#137933)
2023-11-06 [email protected] Fix tool exit message shown when user provides a non-list to "assets" for a deferred component (flutter/flutter#137837)
2023-11-06 [email protected] Roll Flutter Engine from 0d8c7ceacc01 to 555ffa17b55c (1 revision) (flutter/flutter#137921)
2023-11-06 [email protected] Roll Flutter Engine from 11d66db97d3f to 0d8c7ceacc01 (1 revision) (flutter/flutter#137920)
2023-11-05 [email protected] Roll Flutter Engine from a7592e42464c to 11d66db97d3f (1 revision) (flutter/flutter#137914)
2023-11-05 [email protected] Roll Flutter Engine from 1c6bd97e2288 to a7592e42464c (1 revision) (flutter/flutter#137912)
2023-11-05 [email protected] Roll Flutter Engine from daf18fe46b72 to 1c6bd97e2288 (1 revision) (flutter/flutter#137908)
2023-11-04 [email protected] Roll Flutter Engine from a45e679828e6 to daf18fe46b72 (1 revision) (flutter/flutter#137904)
2023-11-04 [email protected] Roll Flutter Engine from fb2a9c20141e to a45e679828e6 (1 revision) (flutter/flutter#137903)
2023-11-04 [email protected] Roll Flutter Engine from 576833873c15 to fb2a9c20141e (1 revision) (flutter/flutter#137900)
2023-11-04 [email protected] Roll Flutter Engine from 25f5e285f874 to 576833873c15 (1 revision) (flutter/flutter#137898)
2023-11-04 [email protected] Roll Flutter Engine from 7282a5d94ab6 to 25f5e285f874 (2 revisions) (flutter/flutter#137892)
2023-11-04 [email protected] Roll Flutter Engine from b66a87626300 to 7282a5d94ab6 (2 revisions) (flutter/flutter#137887)
2023-11-04 [email protected] HeroController should dispatch creation and disposal events. (flutter/flutter#137835)
2023-11-04 [email protected] Roll Flutter Engine from ec20731de6ff to b66a87626300 (1 revision) (flutter/flutter#137877)
2023-11-03 [email protected] InheritedElement.removeDependent() (flutter/flutter#129210)
2023-11-03 [email protected] Remove unused generic type from BottomSheet (flutter/flutter#137791)
2023-11-03 [email protected] Roll Flutter Engine from 035740c1f90e to ec20731de6ff (2 revisions) (flutter/flutter#137872)
2023-11-03 [email protected] Pin dart-lang/native dependencies (flutter/flutter#137601)
2023-11-03 [email protected] Send caret rect to embedder on selection update (flutter/flutter#137863)
2023-11-03 [email protected] Roll Flutter Engine from 677040f10f65 to 035740c1f90e (4 revisions) (flutter/flutter#137871)
2023-11-03 [email protected] Tooltip docs: Recommend setting preferBelow to false in theme (flutter/flutter#135879)
2023-11-03 [email protected] Roll Flutter Engine from f363a6e5e093 to 677040f10f65 (2 revisions) (flutter/flutter#137861)
2023-11-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Android] Support Android 34" (flutter/flutter#137865)
2023-11-03 [email protected] InkFeature should dispatch creation and disposal events. (flutter/flutter#137793)
2023-11-03 [email protected] AppLifecycleListener should dispatch creation and disposal events. (flutter/flutter#137840)
2023-11-03 [email protected] Roll Flutter Engine from d5ccb5b1b706 to f363a6e5e093 (2 revisions) (flutter/flutter#137858)
2023-11-03 [email protected] Roll Flutter Engine from 72262a238090 to d5ccb5b1b706 (3 revisions) (flutter/flutter#137857)
2023-11-03 [email protected] Updated the nested navigation NavigationBar example (flutter/flutter#137788)
2023-11-03 [email protected] Roll Flutter Engine from 0415a4f5e2a2 to 72262a238090 (2 revisions) (flutter/flutter#137853)
2023-11-03 [email protected] Roll Flutter Engine from 8531c5935356 to 0415a4f5e2a2 (1 revision) (flutter/flutter#137847)
2023-11-03 [email protected] Roll flutter gallery version forward. (flutter/flutter#137846)
2023-11-03 [email protected] Roll Flutter Engine from 43653c5a3ec8 to 8531c5935356 (1 revision) (flutter/flutter#137845)
2023-11-03 [email protected] Roll Packages from 33c2b4e53ad7 to cccf5d24d703 (6 revisions) (flutter/flutter#137841)
2023-11-03 [email protected] [web] dispatch corresponding keyup events in text editing integrations (flutter/flutter#136874)
2023-11-03 [email protected] [leak-tracking] Add more leak tracking in test/painting #3 (flutter/flutter#136170)
2023-11-03 [email protected] Upgrade leak_tracker and remove some deps in allow list. (flutter/flutter#137806)
2023-11-03 [email protected] Roll Flutter Engine from fc7c3f70c076 to 43653c5a3ec8 (1 revision) (flutter/flutter#137827)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polina-c polina-c polina-c approved these changes

Assignees

No one assigned

Labels

a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@droidbg @ksokolovskyi @polina-c