Skip to content

Add Card.filled and Card.outlined factory methods#136229

Merged
auto-submit[bot] merged 11 commits intoflutter:masterfrom
QuncCccccc:card_factories
Nov 1, 2023
Merged

Add Card.filled and Card.outlined factory methods#136229
auto-submit[bot] merged 11 commits intoflutter:masterfrom
QuncCccccc:card_factories

Conversation

@QuncCccccc
Copy link
Contributor

@QuncCccccc QuncCccccc commented Oct 9, 2023 •
edited
Loading

Fixes #119401

This PR is to:

  • add Card.filled and Card.outlined factory methods so that we can use tokens for these two types of cards to generate default theme instead of providing hard-corded values in example.
  • update card.2.dart example.
  • add test file for card.2.dart example.
  • fix some mismatch caused by editing the auto-generated defaults by hand in navigation_bar.dart and navigation_drawer.dart.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Oct 9, 2023
@QuncCccccc QuncCccccc marked this pull request as ready for review October 10, 2023 18:25
@QuncCccccc QuncCccccc requested a review from HansMuller October 10, 2023 18:53
HansMuller
HansMuller approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a nit about the example.

examples/api/lib/material/card/card.2.dart Outdated
Copy link
Contributor

@HansMuller HansMuller Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really encourage factoring into widgets rather than build methods. A _SampleCard widget with a const constructor would do the job here.

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 1, 2023
@auto-submit auto-submit bot merged commit 4a0f261 into flutter:master Nov 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
d85b287 
…r/flutter#136229)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
24a3923 
…r/flutter#136229)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
bacda12 
…r/flutter#136229)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
0775ebc 
…r/flutter#136229)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
bf30c2d 
…r/flutter#136229)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
01f2870 
…r/flutter#136229)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
ece4e9d 
…r/flutter#136229)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
722c37c 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
c9a8777 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
e7cdddd 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
9d5f365 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
d249690 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
064451d 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
afaaf50 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
600d3ab 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
b8aaf76 
…r/flutter#136229)
@HansMuller HansMuller mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
d368329 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
980e9b6 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
21ca63a 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
a9ef165 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
b4ca05a 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
a416a29 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
bc745e7 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
2587faa 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
698a759 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
5fb8276 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
08b0279 
…r/flutter#136229)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
ab9507c 
…r/flutter#136229)
@QuncCccccc QuncCccccc mentioned this pull request Nov 21, 2023
Closed
5 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
4a0f261 Add Card.filled and Card.outlined factory methods (flutte…
bb7652c 
…r/flutter#136229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@HansMuller HansMuller HansMuller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add factory constructors for filled and outlined cards

2 participants

@QuncCccccc @HansMuller