Skip to content

Fix FlexibleSpaceBar does compositing with near zero opacity.#136255

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
TahaTesser:fix_flexible_space_bar_push_opacity
Oct 11, 2023
Merged

Fix FlexibleSpaceBar does compositing with near zero opacity.#136255
auto-submit[bot] merged 2 commits intoflutter:masterfrom
TahaTesser:fix_flexible_space_bar_push_opacity

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Oct 10, 2023

fixes flexible_space_bar.dart': Failed assertion: line 475 pos 12: 'needsCompositing': is not true. is thrown when scrolling down in the list and then up

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 10, 2023
jonahwilliams
jonahwilliams reviewed Oct 10, 2023
View reviewed changes
jonahwilliams
jonahwilliams approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2023
@auto-submit auto-submit bot merged commit 692d7ad into flutter:master Oct 11, 2023
@TahaTesser TahaTesser deleted the fix_flexible_space_bar_push_opacity branch October 11, 2023 07:19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
283948e 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
fcb00b1 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
166a048 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
5173b05 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
4cf4130 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
717728a 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 11, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
45f4a37 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
e54e2e9 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
e520f89 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
684a6e5 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
01be144 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
be85551 
…y. (flutter/flutter#136255)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 12, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
a2f62c3 
…y. (flutter/flutter#136255)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 13, 2023
@engine-flutter-autoroll
692d7ad Fix FlexibleSpaceBar does compositing with near zero opacit…
affe6ed 
…y. (flutter/flutter#136255)
@vincent-hoodoo
Copy link

vincent-hoodoo commented Oct 23, 2023

Our integration tests are currently failing because of the Exceptions thrown from this bug.
Do you have any idea when this fix will land in stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flexible_space_bar.dart': Failed assertion: line 475 pos 12: 'needsCompositing': is not true. is thrown when scrolling down in the list and then up

3 participants

@TahaTesser @vincent-hoodoo @jonahwilliams