Skip to content

Update framework_test.dart to remove ButtonBar usage and remove references from other clases#137550

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
TahaTesser:remove_buttonbar_references
Nov 1, 2023
Merged

Update framework_test.dart to remove ButtonBar usage and remove references from other clases#137550
auto-submit[bot] merged 1 commit intoflutter:masterfrom
TahaTesser:remove_buttonbar_references

Conversation

@TahaTesser
Copy link
Contributor

@TahaTesser TahaTesser commented Oct 30, 2023 •
edited
Loading

This PR removes ButtonBar usage from framework_test.dart class and update other references in preparation for ButtonBar deprecation

related to #127955

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 30, 2023
@TahaTesser TahaTesser requested a review from Piinks October 31, 2023 21:27
Piinks
Piinks approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@Piinks Piinks added c: tech-debt Technical debt, code quality, testing, etc. autosubmit Merge PR when tree becomes green via auto submit App labels Nov 1, 2023
@auto-submit auto-submit bot merged commit b1f5d96 into flutter:master Nov 1, 2023
@TahaTesser TahaTesser deleted the remove_buttonbar_references branch November 1, 2023 22:06
Piinks added a commit that referenced this pull request Nov 1, 2023
@Piinks
Revert "Update framework_test.dart to remove ButtonBar usage and …
7bedcfc 
…remove references from other clases (#137550)"

This reverts commit b1f5d96.
@Piinks Piinks added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 1, 2023
@auto-submit auto-submit bot mentioned this pull request Nov 1, 2023
Merged
8 tasks
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 1, 2023
auto-submit bot pushed a commit that referenced this pull request Nov 1, 2023
Revert "Update framework_test.dart to remove ButtonBar usage and …
7b9cae5 
…remove references from other clases (#137550)"

This reverts commit b1f5d96.
auto-submit bot added a commit that referenced this pull request Nov 1, 2023
@auto-submit
Reverts "Update framework_test.dart to remove ButtonBar usage and…
b47e4c4 
… remove references from other clases" (#137731)

Reverts #137550
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation

related to #127955
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
d76699d 
…remove references from other clases (flutter/flutter#137550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
08537d5 
…remove references from other clases (flutter/flutter#137550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
6f9c91b 
…remove references from other clases (flutter/flutter#137550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
4cf7d94 
…remove references from other clases (flutter/flutter#137550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
339ce2f 
…remove references from other clases (flutter/flutter#137550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
2e91f47 
…remove references from other clases (flutter/flutter#137550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
5c9b44d 
…remove references from other clases (flutter/flutter#137550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
fc47d8b 
…remove references from other clases (flutter/flutter#137550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
a3483b0 
…remove references from other clases (flutter/flutter#137550)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
e35137a 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
01db5d8 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
07a3ca0 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
e394e56 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
cf89ceb 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
4123834 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
de65159 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
ffd5b2f 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
3e3183c 
…remove references from other clases (flutter/flutter#137550)
@HansMuller HansMuller mentioned this pull request Nov 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
ac6fb87 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
a32d099 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
fdcb076 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
cce7e6b 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
75b62ec 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
0ac4d4a 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
f2e8bd9 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
d9f84d5 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
d842a21 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
4e13ae2 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
8ea7ffe 
…remove references from other clases (flutter/flutter#137550)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
6b16d3a 
…remove references from other clases (flutter/flutter#137550)
@TahaTesser TahaTesser mentioned this pull request Nov 13, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Nov 14, 2023
@TahaTesser
Reland "Update framework_test.dart to remove ButtonBar usage and …
e8c2bb1 
…remove references from other clases (#137550) (#137753)

This PR removes `ButtonBar` usage from `framework_test.dart` class and update other references in preparation for `ButtonBar` deprecation

related to #127955

reland #137550
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
b1f5d96 Update framework_test.dart to remove ButtonBar usage and …
b93f597 
…remove references from other clases (flutter/flutter#137550)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TahaTesser @Piinks