Skip to content

Reverts "Update framework_test.dart to remove ButtonBar usage and remove references from other clases"#137731

Merged
auto-submit[bot] merged 1 commit intomasterfrom
revert_b1f5d96a82a91c6b1423d5febafa403bfeb8b632
Nov 1, 2023
Merged

Reverts "Update framework_test.dart to remove ButtonBar usage and remove references from other clases"#137731
auto-submit[bot] merged 1 commit intomasterfrom
revert_b1f5d96a82a91c6b1423d5febafa403bfeb8b632

Conversation

@auto-submit
Copy link
Contributor

@auto-submit auto-submit bot commented Nov 1, 2023

Reverts #137550
Initiated by: Piinks
This change reverts the following previous change:
Original Description:
This PR removes ButtonBar usage from framework_test.dart class and update other references in preparation for ButtonBar deprecation

related to #127955

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Revert "Update framework_test.dart to remove ButtonBar usage and …
7b9cae5 
…remove references from other clases (#137550)"

This reverts commit b1f5d96.
@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Nov 1, 2023
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Nov 1, 2023
Piinks
Piinks approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit auto-submit bot merged commit b47e4c4 into master Nov 1, 2023
@auto-submit auto-submit bot deleted the revert_b1f5d96a82a91c6b1423d5febafa403bfeb8b632 branch November 1, 2023 22:58
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
c61064b 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
b88f186 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
a01eb25 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
836aae8 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
7190ba3 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
3ab5b31 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
0bf7ea6 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
fd14456 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
2794155 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
ab9d98c 
…sage and remove references from other clases" (flutter/flutter#137731)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 2, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
75c64ca 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
f7485b5 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
64c2d6e 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
5e2714f 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
882aa1c 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
0cc9d44 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
bd25f86 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
28915eb 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 3, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
86f10b4 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
6eb2069 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
29db387 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
519e34e 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 4, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
b6f0f02 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
482c791 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 5, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
cd15ce6 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
f86a2e5 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
932cd9c 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
f3e4b3f 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
a62c322 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
0790ef4 
…sage and remove references from other clases" (flutter/flutter#137731)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 6, 2023
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
7d4b4f9 
…sage and remove references from other clases" (flutter/flutter#137731)
@TahaTesser TahaTesser mentioned this pull request Nov 14, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
b47e4c4 Reverts "Update framework_test.dart to remove ButtonBar u…
9452539 
…sage and remove references from other clases" (flutter/flutter#137731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Piinks approved these changes

@fluttergithubbot fluttergithubbot fluttergithubbot approved these changes

Assignees

@Piinks Piinks

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Piinks @fluttergithubbot