Skip to content

Improved Java version parsing#138155

Merged
auto-submit[bot] merged 2 commits intomasterfrom
i135402-fallback-java-parse-logic
Nov 9, 2023
Merged

Improved Java version parsing#138155
auto-submit[bot] merged 2 commits intomasterfrom
i135402-fallback-java-parse-logic

Conversation

@reidbaker
Copy link
Contributor

@reidbaker reidbaker commented Nov 9, 2023

Fixes #135402
Add fallback logic for a different format of java version output and handle no patch versions.
Add tests for new logic output to prevent regressions.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@reidbaker
Fallback logic for different formatting of java version without patch…
262560c 
… numbers and following a different output syntax
@reidbaker reidbaker requested review from a team and andrewkolos November 9, 2023 17:16
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 9, 2023
andrewkolos
andrewkolos approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. FYI, I pushed a commit to fix some indentation

@reidbaker
Copy link
Contributor Author

reidbaker commented Nov 9, 2023

LGTM. FYI, I pushed a commit to fix some indentation

Thank you and sorry about that.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 9, 2023
@auto-submit auto-submit bot merged commit 94079b9 into master Nov 9, 2023
@auto-submit auto-submit bot deleted the i135402-fallback-java-parse-logic branch November 9, 2023 18:38
@andrewkolos
Copy link
Contributor

andrewkolos commented Nov 9, 2023

LGTM. FYI, I pushed a commit to fix some indentation

Thank you and sorry about that.

No worries—I just like to let people know when I mess with their branches

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
59f19f9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
277dee9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
90595a7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
b1af087
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
e137bae
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 10, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 10, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
35b4be2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
873f94b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 11, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 11, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
781732b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 12, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
b5a523c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
dd7269b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
4245800
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 13, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
363be36
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
3a07e15
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
5039542
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
575fa08
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
3c7ee31
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
f8798b6
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 14, 2023
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
dd963f7
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
94079b9 Improved Java version parsing (flutter/flutter#138155)
918566a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flutter doctor] Could not determine java version with JDK 21

2 participants

@reidbaker @andrewkolos