Migration for NullSafetyAnalysisEvent to package:unified_analytics#138419
Closed
eliasyishak wants to merge 3 commits intoflutter:masterfrom
Closed
Migration for NullSafetyAnalysisEvent to package:unified_analytics#138419eliasyishak wants to merge 3 commits intoflutter:masterfrom
NullSafetyAnalysisEvent to package:unified_analytics#138419eliasyishak wants to merge 3 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
the
tool
32 tasks
eliasyishak
commented
Nov 14, 2023
Comment on lines
+90
to
+92
| if (packageLanguageVersion != null && | ||
| packageLanguageVersion.major >= nullSafeVersion.major && | ||
| packageLanguageVersion.minor >= nullSafeVersion.minor) { |
Contributor
Author
There was a problem hiding this comment.
Is this correct? This logic for calculating total number of migrated packages was taken from here
I think we should be able to just compare two LanguageVersion classes together instead of comparing the major and minor versions
Contributor
Author
|
No longer necessary to migrate this event per dart-lang/tools#202 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to tracker issue:
package:unified_analyticsimplementation in flutter tool #128251This PR will use the new event from
package:unified_analyticsand will consolidate the 3 separate send events from the legacy analytics system to just sending onePre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.