Skip to content

Migration for the sendTiming events for package:unified_analytics#138896

Merged
auto-submit[bot] merged 22 commits intoflutter:masterfrom
eliasyishak:ga4-send-timing-migration
Nov 29, 2023
Merged

Migration for the sendTiming events for package:unified_analytics#138896
auto-submit[bot] merged 22 commits intoflutter:masterfrom
eliasyishak:ga4-send-timing-migration

Conversation

@eliasyishak
Copy link
Contributor

@eliasyishak eliasyishak commented Nov 22, 2023 •
edited
Loading

Related to tracker issue:

image

The image above shows all of the instances where we have sendTiming. All of the call sites have been updated to use the new Event.timing event from package:unified_analytics.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@eliasyishak
Migrate the flutter command for --version
9ff40bb 
This needs to be done on its own because we return before the `_sendPostUsage` method can send the command ran
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 22, 2023
@github-actions github-actions bot added the platform-ios iOS applications specifically label Nov 27, 2023
@github-actions github-actions bot added the a: desktop Running on desktop label Nov 27, 2023
@christopherfujino
Copy link
Contributor

christopherfujino commented Nov 28, 2023

I believe this analysis error is unrelated to your change and fixed upstream:

Analyzing Á flutter sdk...                                      

  error • 'FakeView.render' ('void Function(Scene)') isn't a valid override of 'TestFlutterView.render' ('void Function(Scene, {Size? size})') • packages/flutter/test/widgets/multi_view_testing.dart:20:8 • invalid_override
  error • 'FakeView.render' ('void Function(Scene)') isn't a valid override of 'TestFlutterView.render' ('void Function(Scene, {Size? size})') • packages/flutter_test/test/multi_view_testing.dart:20:8 • invalid_override
   info • Place 'package:' imports before relative imports • packages/flutter_tools/lib/src/commands/packages.dart:22:1 • directives_ordering

@eliasyishak
Copy link
Contributor Author

eliasyishak commented Nov 28, 2023

@christopherfujino ah i see, thanks, i was wondering why it kept coming up

@eliasyishak eliasyishak mentioned this pull request Nov 28, 2023
Closed
32 tasks
@eliasyishak eliasyishak marked this pull request as ready for review November 28, 2023 21:17
@eliasyishak eliasyishak changed the title [WIP] Migration for the sendTiming events for package:unified_analytics Migration for the sendTiming events for package:unified_analytics Nov 28, 2023
christopherfujino
christopherfujino reviewed Nov 29, 2023
View reviewed changes
packages/flutter_tools/test/general.shard/runner/flutter_command_test.dart Outdated
Comment on lines +515 to +517
expect(timingEventCounts, 0,
reason: 'There should not be any timing events sent, '
'there may be other events');
Copy link
Contributor

@christopherfujino christopherfujino Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
expect(timingEventCounts, 0,
reason: 'There should not be any timing events sent, '
'there may be other events');
expect(
timingEventCounts,
0,
reason: 'There should not be any timing events sent, there may be other events',
);

Copy link
Contributor

@christopherfujino christopherfujino Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would there be other events?

Copy link
Contributor

@christopherfujino christopherfujino Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, this test was only ever testing that there weren't timing events?

Copy link
Contributor Author

@eliasyishak eliasyishak Nov 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, with package:usage, we had separate lists for timing, commands, and other events, but with the new approach they are stored in the same sentEvents list.

christopherfujino
christopherfujino reviewed Nov 29, 2023
View reviewed changes
christopherfujino
christopherfujino approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM modulo nits

@eliasyishak eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 29, 2023
@auto-submit auto-submit bot merged commit 60d5c8a into flutter:master Nov 29, 2023
@eliasyishak eliasyishak deleted the ga4-send-timing-migration branch November 29, 2023 17:43
@CaseyHillers CaseyHillers added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 30, 2023
@auto-submit auto-submit bot mentioned this pull request Nov 30, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Nov 30, 2023
Revert "Migration for the sendTiming events for `package:unified_an…
597268d 
…alytics` (#138896)"

This reverts commit 60d5c8a.
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 30, 2023
auto-submit bot added a commit that referenced this pull request Nov 30, 2023
@auto-submit
Reverts "Migration for the sendTiming events for `package:unified_a…
6c4475e 
…nalytics`" (#139278)

Reverts #138896
Initiated by: CaseyHillers
This change reverts the following previous change:
Original Description:
Related to tracker issue:
- #128251

<img width="278" alt="image" src="proxy.php?url=https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de">

The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.
@eliasyishak eliasyishak restored the ga4-send-timing-migration branch November 30, 2023 13:20
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 30, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 30, 2023
@engine-flutter-autoroll
60d5c8a Migration for the sendTiming events for `package:unified_an…
79a42b9 
…alytics` (flutter/flutter#138896)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Nov 30, 2023
@engine-flutter-autoroll
Roll Flutter from 5e5b529 to 918e336 (14 revisions) (#5526)
9cdc001 
flutter/flutter@5e5b529...918e336

2023-11-30 [email protected] Move Impeller tests on Pixel 7 Pro from staging to prod (flutter/flutter#139280)
2023-11-30 [email protected] Introduce multi-touch drag strategies for `DragGestureRecognizer` (flutter/flutter#136708)
2023-11-30 [email protected] Use the correct recipe on fuchsia_precache. (flutter/flutter#139279)
2023-11-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migration for the `sendTiming` events for `package:unified_analytics`" (flutter/flutter#139278)
2023-11-30 [email protected] Migrate fuchsia_precache to shard tests. (flutter/flutter#139202)
2023-11-29 [email protected] Fix chips `onDeleted` callback don't show the delete button when disabled (flutter/flutter#137685)
2023-11-29 [email protected] Roll Flutter Engine from 9a7e49d75411 to 35939ca8534f (5 revisions) (flutter/flutter#139259)
2023-11-29 [email protected] Refactor to use Apple system fonts (flutter/flutter#137275)
2023-11-29 [email protected] Dynamic view sizing (flutter/flutter#138648)
2023-11-29 [email protected] Roll dependencies (flutter/flutter#139203)
2023-11-29 [email protected] add sourceTimeStamp to ScaleUpdateDetails (flutter/flutter#135936)
2023-11-29 [email protected] Roll Flutter Engine from 222beb28a8eb to 9a7e49d75411 (1 revision) (flutter/flutter#139250)
2023-11-29 [email protected] Remove deprecated `PlatformMenuBar.body` (flutter/flutter#138509)
2023-11-29 [email protected] Migration for the `sendTiming` events for `package:unified_analytics` (flutter/flutter#138896)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@eliasyishak
Copy link
Contributor Author

eliasyishak commented Nov 30, 2023

This PR was reverted due to Google3 updates that need to be made:

caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@eliasyishak @caseycrogers
Migration for the sendTiming events for package:unified_analytics (…
1820f9b 
…flutter#138896)

Related to tracker issue:
- flutter#128251

<img width="278" alt="image" src="proxy.php?url=https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de">

The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.
caseycrogers pushed a commit to caseycrogers/flutter that referenced this pull request Dec 29, 2023
@auto-submit @caseycrogers
Reverts "Migration for the sendTiming events for `package:unified_a…
61284d0 
…nalytics`" (flutter#139278)

Reverts flutter#138896
Initiated by: CaseyHillers
This change reverts the following previous change:
Original Description:
Related to tracker issue:
- flutter#128251

<img width="278" alt="image" src="proxy.php?url=https://github.com/flutter/flutter/assets/42216813/cee7b9be-48d6-48e5-8c39-de28d0a1f0de">

The image above shows all of the instances where we have `sendTiming`. All of the call sites have been updated to use the new `Event.timing` event from `package:unified_analytics`.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
60d5c8a Migration for the sendTiming events for `package:unified_an…
a8639ce 
…alytics` (flutter/flutter#138896)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliasyishak @christopherfujino @CaseyHillers