Skip to content

Improve slider's value indicator display test#139198

Merged
auto-submit[bot] merged 3 commits intoflutter:masterfrom
hgraceb:improve_slider_test
Dec 11, 2023
Merged

Improve slider's value indicator display test#139198
auto-submit[bot] merged 3 commits intoflutter:masterfrom
hgraceb:improve_slider_test

Conversation

@hgraceb
Copy link
Member

@hgraceb hgraceb commented Nov 29, 2023

The previous test for #128137 does not effectively regress and verify #123313 because the issue is specific to desktop platforms.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants