Use new `enabledFeature` param for `Analytics` by eliasyishak · Pull Request #139934 · flutter/flutter

eliasyishak · 2023-12-11T20:52:39Z

Related to tracker issue:

☂️ package:unified_analytics implementation in flutter tool #128251

This updates the Analytics constructor to provide it with the enabled features for the flutter-tool. This will be sent with each event for the flutter-tool.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

packages/flutter_tools/lib/src/reporting/unified_analytics.dart

packages/flutter_tools/test/general.shard/unified_analytics_test.dart

packages/flutter_tools/lib/src/reporting/unified_analytics.dart

christopherfujino · 2023-12-12T19:44:33Z

packages/flutter_tools/test/general.shard/unified_analytics_test.dart

    });

-    testUsingContext('Client IDE is passed and found in events', () {
+    testWithoutContext('Client IDE is passed and found in events', () {


christopherfujino

LGTM ship it

Co-authored-by: Christopher Fujino <[email protected]>

eliasyishak · 2023-12-12T19:47:00Z

LGTM ship it

🎉 , i just need to put out a CL in g3 to update the package first and then should be good to go

eliasyishak · 2023-12-15T14:33:04Z

hey @CaseyHillers, do you know why this PR is saying "G3Fix failed to apply"? I didn't apply any g3fixes for this PR

CaseyHillers · 2023-12-15T18:06:02Z

@eliasyishak it looks like this was pushed during b/315823847 which was an outage a few days ago. Can you try pushing a new commit to get it picked up again? Thanks!

…er#139934)

flutter/flutter@2407f69...cdc83e5 2023-12-18 [email protected] Roll Flutter Engine from b3de65a6d3ea to 7f1a81d5545a (1 revision) (flutter/flutter#140309) 2023-12-18 [email protected] refactored cli tool ipa method name to support --export-options-plist (flutter/flutter#138555) 2023-12-18 [email protected] Restore and fix flavors_test_macos (flutter/flutter#139841) 2023-12-18 [email protected] Roll Flutter Engine from 626c93260f79 to b3de65a6d3ea (1 revision) (flutter/flutter#140308) 2023-12-17 [email protected] Roll Flutter Engine from f9c7aa27f13a to 626c93260f79 (1 revision) (flutter/flutter#140291) 2023-12-17 [email protected] Roll Flutter Engine from 726a137e3f99 to f9c7aa27f13a (1 revision) (flutter/flutter#140289) 2023-12-16 [email protected] Roll Flutter Engine from c5fc179cf0b3 to 726a137e3f99 (1 revision) (flutter/flutter#140280) 2023-12-16 [email protected] Roll Flutter Engine from a8d8fbbcef22 to c5fc179cf0b3 (1 revision) (flutter/flutter#140277) 2023-12-16 [email protected] Center Floating Snackbar with custom width when direction is RTL (flutter/flutter#140215) 2023-12-16 [email protected] Roll Flutter Engine from 6752398c2f54 to a8d8fbbcef22 (1 revision) (flutter/flutter#140274) 2023-12-16 [email protected] Use `SemanticsUpdateBuilder` again, remove all references to temporary `SemanticsUpdateBuilderNew` (flutter/flutter#139942) 2023-12-16 [email protected] Roll Flutter Engine from 7d300e5b9587 to 6752398c2f54 (1 revision) (flutter/flutter#140270) 2023-12-16 [email protected] Roll Flutter Engine from 832238a3b493 to 7d300e5b9587 (1 revision) (flutter/flutter#140268) 2023-12-16 [email protected] Roll Flutter Engine from 34d427aa009c to 832238a3b493 (1 revision) (flutter/flutter#140265) 2023-12-16 [email protected] Roll Flutter Engine from 74e4965a2845 to 34d427aa009c (1 revision) (flutter/flutter#140263) 2023-12-16 [email protected] Roll Flutter Engine from ca329dd84207 to 74e4965a2845 (4 revisions) (flutter/flutter#140262) 2023-12-16 [email protected] [github actions] minor PR to test latest github actions (flutter/flutter#140252) 2023-12-16 [email protected] Roll Flutter Engine from 6e3a04874be5 to ca329dd84207 (3 revisions) (flutter/flutter#140255) 2023-12-15 [email protected] Remove usage of testWidgetsWithLeakTracking. (flutter/flutter#140239) 2023-12-15 [email protected] Roll Flutter Engine from a8d861b53db1 to 6e3a04874be5 (1 revision) (flutter/flutter#140244) 2023-12-15 [email protected] Roll Flutter Engine from c48b08ac4682 to a8d861b53db1 (1 revision) (flutter/flutter#140240) 2023-12-15 [email protected] Use new `enabledFeature` param for `Analytics` (flutter/flutter#139934) 2023-12-15 [email protected] Roll Flutter Engine from db98451b063c to c48b08ac4682 (2 revisions) (flutter/flutter#140236) 2023-12-15 [email protected] Reorganize dependencies on leak_tracker. (flutter/flutter#140233) 2023-12-15 [email protected] [macOS,iOS] CocoaPods recommended version: 1.13.0 (flutter/flutter#135447) 2023-12-15 [email protected] Roll Flutter Engine from b36374085c4b to db98451b063c (1 revision) (flutter/flutter#140230) 2023-12-15 [email protected] Roll Flutter Engine from e89b7ed8812b to b36374085c4b (1 revision) (flutter/flutter#140228) 2023-12-15 [email protected] Roll Flutter Engine from 986a6fe198dc to e89b7ed8812b (1 revision) (flutter/flutter#140224) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er#139934)

Use new enabledFeature param for Analytics

33cc615

github-actions bot added a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. labels Dec 11, 2023

eliasyishak mentioned this pull request Dec 11, 2023

☂️ package:unified_analytics implementation in flutter tool #128251

Closed

32 tasks

Merge branch 'master' into send-enabled-features

27e7d4a

eliasyishak marked this pull request as ready for review December 12, 2023 16:57

eliasyishak requested a review from christopherfujino as a code owner December 12, 2023 16:57

flutter update-packages --force-upgrade

0606280

christopherfujino reviewed Dec 12, 2023

View reviewed changes

packages/flutter_tools/lib/src/reporting/unified_analytics.dart Outdated Show resolved Hide resolved

eliasyishak commented Dec 12, 2023

View reviewed changes

packages/flutter_tools/test/general.shard/unified_analytics_test.dart Outdated Show resolved Hide resolved

christopherfujino reviewed Dec 12, 2023

View reviewed changes

packages/flutter_tools/lib/src/reporting/unified_analytics.dart Show resolved Hide resolved

Update test to be unordered

4c832c2

christopherfujino reviewed Dec 12, 2023

View reviewed changes

christopherfujino approved these changes Dec 12, 2023

View reviewed changes

Nit fix

162631a

Co-authored-by: Christopher Fujino <[email protected]>

eliasyishak added 2 commits December 12, 2023 15:50

Empty commit to run Google testing

a335515

Empty commit to kick off g3fix

d319dfa

eliasyishak added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 15, 2023

Merge branch 'master' into send-enabled-features

f656b0f

auto-submit bot merged commit d180c12 into flutter:master Dec 15, 2023

engine-flutter-autoroll mentioned this pull request Dec 16, 2023

Roll Flutter from 2407f699e935 to 3958b3d5ff15 (17 revisions) flutter/packages#5695

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023

d180c12 Use new enabledFeature param for Analytics (flutter/flutt…

c7c0400

…er#139934)

engine-flutter-autoroll mentioned this pull request Dec 16, 2023

Roll Flutter from 2407f699e935 to 8c02a22403fe (18 revisions) flutter/packages#5696

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023

d180c12 Use new enabledFeature param for Analytics (flutter/flutt…

d581418

…er#139934)

engine-flutter-autoroll mentioned this pull request Dec 16, 2023

Roll Flutter from 2407f699e935 to c1e207d6acb2 (19 revisions) flutter/packages#5697

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 16, 2023

d180c12 Use new enabledFeature param for Analytics (flutter/flutt…

5c8dba8

…er#139934)

engine-flutter-autoroll mentioned this pull request Dec 17, 2023

Roll Flutter from 2407f699e935 to 32d42b63def2 (24 revisions) flutter/packages#5699

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2023

d180c12 Use new enabledFeature param for Analytics (flutter/flutt…

83a6575

…er#139934)

engine-flutter-autoroll mentioned this pull request Dec 17, 2023

Roll Flutter from 2407f699e935 to 32d42b63def2 (24 revisions) flutter/packages#5700

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 17, 2023

d180c12 Use new enabledFeature param for Analytics (flutter/flutt…

efaac95

…er#139934)

engine-flutter-autoroll mentioned this pull request Dec 18, 2023

Roll Flutter from 2407f699e935 to cdc83e5ebae4 (28 revisions) flutter/packages#5715

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 18, 2023

d180c12 Use new enabledFeature param for Analytics (flutter/flutt…

a75658f

…er#139934)

eliasyishak deleted the send-enabled-features branch January 3, 2024 14:20

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

d180c12 Use new enabledFeature param for Analytics (flutter/flutt…

a74f165

…er#139934)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use new `enabledFeature` param for `Analytics`#139934

Use new `enabledFeature` param for `Analytics`#139934
auto-submit[bot] merged 8 commits intoflutter:masterfrom
eliasyishak:send-enabled-features

eliasyishak commented Dec 11, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

christopherfujino Dec 12, 2023

Uh oh!

christopherfujino left a comment

Uh oh!

eliasyishak commented Dec 12, 2023

Uh oh!

eliasyishak commented Dec 15, 2023

Uh oh!

CaseyHillers commented Dec 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

eliasyishak commented Dec 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

christopherfujino Dec 12, 2023

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

eliasyishak commented Dec 12, 2023

Uh oh!

eliasyishak commented Dec 15, 2023

Uh oh!

CaseyHillers commented Dec 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eliasyishak commented Dec 11, 2023 •

edited

Loading