Remove large int support in standard message codec#14011
Merged
mravn-google merged 3 commits intoflutter:masterfrom Jan 11, 2018
Merged
Remove large int support in standard message codec#14011mravn-google merged 3 commits intoflutter:masterfrom
mravn-google merged 3 commits intoflutter:masterfrom
Conversation
Contributor
Author
|
Partial fix of #12976 |
Skylled
reviewed
Jan 10, 2018
| /// two's complement; otherwise, `java.lang.Long` for values that are | ||
| /// representable using 64-bit two's complement; otherwise, | ||
| /// `java.math.BigInteger`. | ||
| /// two's complement; otherwise, `java.lang.Long` |
Contributor
There was a problem hiding this comment.
nit - missing period (not 100% necessary as it's not a complete sentence)
Contributor
Author
There was a problem hiding this comment.
Thanks. Most of the other bullets don't use periods, so I've removed them consistently.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
This was referenced Nov 27, 2019
engine-flutter-autoroll
added a commit
that referenced
this pull request
Nov 27, 2019
[email protected]:flutter/engine.git/compare/27fa60793bcb...5250d63 git log 27fa607..5250d63 --first-parent --oneline 2019-11-26 [email protected] Roll src/third_party/skia 54036c9b8e4b..40a7dfc268b6 (1 commits) (#14016) 2019-11-26 [email protected] Roll fuchsia/sdk/core/mac-amd64 from Bxgic... to aVdHP... (#14017) 2019-11-26 [email protected] Roll fuchsia/sdk/core/linux-amd64 from kzFUw... to xyyOR... (#14021) 2019-11-26 [email protected] Add a separate target for Dart coverter on FML types. (#14011) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove documentation and code pretending it is possible to send >64 bit ints from Dart to Android/iOS.
flutter/engine support for sending large ints in the opposite direction was deprecated in flutter/engine#4528.
flutter-dev announcement: https://groups.google.com/forum/#!topic/flutter-dev/doKMRFpANOQ