More helpful test.dart output#140175
Conversation
Hixie
force-pushed
the
testsmessages
branch
2 times, most recently
from
765d8ea to
2054d72
Compare
dev/bots/run_command.dart
Outdated
There was a problem hiding this comment.
This omits output if it is longer than 10 characters? That seems a bit short? (used to be 10 lines) (we really should have a test for this...)
Also, should we continue to log that output was omitted because it was too long?
There was a problem hiding this comment.
woops yeah the 10 characters thing was definitely a mistake. i'll see if it's testable.
i removed the log saying it was too long because it's just kind of superfluous. in practice it doesn't really help anything as far as i can tell. it's not like the reader is looking for the output, they'll just go find the original logs anyway.
|
I made it 512 characters instead of 10. it's not the same as 10 lines but it's probably roughly equivalent. |
Slightly.
2 participants
Each error section is numbered, so you can all be sure you're talking about the same one.
A message is printed at the very end telling you how to find the error blocks in the verbose logs.