feat(popup_menu): add the ability to set route settings on PopupMenuB…#140373
feat(popup_menu): add the ability to set route settings on PopupMenuB…#140373sbatezat wants to merge 2 commits intoflutter:masterfrom
Conversation
…utton Add the ability to set route settings on PopupMenuButton
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@text-exemption-reviewers" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Looks like this PR is missing a test as per the bot message above. Can you please add one? Thank you! |
|
I am going to close this PR since there was no follow-up. We have an issue on file for this. Please feel free to reopen the PR if you find the time to work on this again. |
|
Hi @goderbauer I tried competing the work of the previous PR, please check. It seems like all checks have passed, please let me know if I should improve the test |
Add the ability to set route settings on PopupMenuButton
Fix #140372