[cp-beta]some random title#140497
Closed
XilaiZhang wants to merge 1 commit intoflutter-3.18-candidate.0from
Closed
[cp-beta]some random title#140497XilaiZhang wants to merge 1 commit intoflutter-3.18-candidate.0from
XilaiZhang wants to merge 1 commit intoflutter-3.18-candidate.0from
Conversation
* This seems to be unnecessary as users will open a CP PR with the original commit linked in it. * Add note on changelog description to be less than 80 chars
fluttergithubbot
approved these changes
Dec 21, 2023
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
This PR makes the following changes: 1. Remove dependency on [peters/evans package](https://github.com/marketplace/actions/create-pull-request)<br> The market place action introduces overheads that don't properly consume tokens. e.g. :[failed workflow that says token is not supplied](https://github.com/flutter/flutter/actions/runs/7282529195/job/19845096943) This PR changes the market place action to git commands that we have full control over, provides better error msg for debug, and properly consumes token. 2. Align usage of tokens:<br> All tokens in the workflow now uses flutter actions bot PAT token. From experiments, a mixed usage of different tokens in different steps sometimes cause the workflow to fail on authentication. Tested: Tested with [a similar workflow on my personal repository](https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/easy-cp.yml), and it produces the [expected cherry pick PR as end result](#140497)
guidezpl
deleted the
cp-beta-126606f9f30fb589835797b205c38244d71efd53
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is opened against a release branch.
To request a cherry pick of a commit, please fill in the form below. (Questions with an asterisk are required.)
To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords.
A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.
See https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices for examples (Bug fix, feature, docs update, ...)