Pin path_provider_android and dwds.#140797
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
tool
polina-c
changed the title
| /// in ways that prevent them from ever upgrading Flutter again! | ||
| const Map<String, String> kManuallyPinnedDependencies = <String, String>{ | ||
| // Add pinned packages here. Please leave a comment explaining why. | ||
| 'dwds': '22.1.0', // https://github.com/flutter/flutter/issues/140796 |
There was a problem hiding this comment.
Why does DWDS need to be pinned?
There was a problem hiding this comment.
Never mind:
flutter%20sdk/packages/flutter_tools/lib/src/isolated/devfs_web.dart:102:16: Error: The method 'WebExpressionCompiler.initialize' has fewer positional arguments than those of overridden method 'ExpressionCompiler.initialize'.
Future<void> initialize({String? moduleFormat, bool? soundNullSafety}) async {}
^
/home/chrome-bot/.pub-cache/hosted/pub.dev/dwds-23.0.0/lib/src/services/expression_compiler.dart:86:16: Context: This is the overridden method ('initialize').
Future<void> initialize(CompilerOptions options);
^
flutter%20sdk/packages/flutter_tools/lib/src/isolated/devfs_web.dart:289:23: Error: The argument type 'Uri?' can't be assigned to the parameter type 'BuildSettings'.
- 'Uri' is from 'dart:core'.
- 'BuildSettings' is from 'package:dwds/src/loaders/strategy.dart' ('/home/chrome-bot/.pub-cache/hosted/pub.dev/dwds-23.0.0/lib/src/loaders/strategy.dart').
packageConfig.toPackageUri(
^
|
superceded by #140810 (which fixes dwds and pins path_provider_android) |
2 participants
Pin some dependencies to unblock upgrades for other packages.
Breaking changes: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8759996669305826785/+/u/flutter_config_--clear-features/stdout
Fixes for the static errors lead to other test failures.