Skip to content

Clean up build directory before copying freshly produced build.#14081

Merged
aam merged 1 commit intoflutter:masterfrom
aam:cleanup-build-before-copying-ios
Jan 20, 2018
Merged

Clean up build directory before copying freshly produced build.#14081
aam merged 1 commit intoflutter:masterfrom
aam:cleanup-build-before-copying-ios

Conversation

@aam
Copy link
Member

@aam aam commented Jan 12, 2018

This solves the issue where non-preview-dart-2 build directory had artifacts from previous preview-dart-2 build on ios.

@aam aam requested review from chinmaygarde and yjbanov January 12, 2018 22:07
@aam aam changed the title Clean up build directory before copying freshly produced build artifa… Clean up build directory before copying freshly produced build. Jan 12, 2018
@yjbanov
Copy link
Contributor

yjbanov commented Jan 12, 2018

/cc @cbracken who (AFAIK) has worked on the caching logic for our build artifacts.

@aam
Copy link
Member Author

aam commented Jan 19, 2018

PTAL as this could be a source of unexpected failures when user goes from running with --preview-dart-2 to running without it.

@aam aam requested a review from cbracken January 19, 2018 21:00
@cbracken
Copy link
Member

lgtm

@aam aam merged commit a92110a into flutter:master Jan 20, 2018
@aam aam deleted the cleanup-build-before-copying-ios branch January 20, 2018 19:11
DaveShuckerow pushed a commit to DaveShuckerow/flutter that referenced this pull request May 14, 2018
engine-flutter-autoroll added a commit that referenced this pull request Dec 3, 2019
[email protected]:flutter/engine.git/compare/8672e79af873...faa1121

git log 8672e79..faa1121 --first-parent --oneline
2019-12-03 [email protected] Run benchmarks in Cirrus (#13950)
2019-12-03 [email protected] Report backing store changes in the macOS view (#13933)
2019-12-03 [email protected] Listen to keyUp event on meta modified keys (#13984)
2019-12-02 [email protected] Fix live region logic (#14081)
2019-12-02 [email protected] Roll src/third_party/skia e8c96d8e6116..2792515dab7c (1 commits) (#14069)
2019-12-02 [email protected] Roll src/third_party/dart 3f32196958..e4344a568f (1 commits) (#14073)
2019-12-02 [email protected] Roll fuchsia/sdk/core/mac-amd64 from aVdHP... to 6QxEZ... (#14080)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants