Clean up output directory before copying over new files#14085
Merged
aam merged 2 commits intoflutter:masterfrom Jan 15, 2018
Merged
Clean up output directory before copying over new files#14085aam merged 2 commits intoflutter:masterfrom
aam merged 2 commits intoflutter:masterfrom
Conversation
cbracken
approved these changes
Jan 13, 2018
Member
|
I'm not a Gradle expert, but if this does what it purports to do, LGTM. /cc @mravn-google and @szakarias who are the Gradle experts. |
mravn-google
approved these changes
Jan 14, 2018
|
|
||
| Task deleteOutputDir = project.tasks.create(name: "deleteOutputDirectory${variant.name.capitalize()}", type:Delete) { | ||
| delete variant.mergeAssets.outputDir | ||
| } |
Contributor
There was a problem hiding this comment.
I believe there is a cleanXxx task for every output-producing task xxx, so this should not be necessary. See below.
| Task copyFlxTask = project.tasks.create(name: "copyFlutterAssets${variant.name.capitalize()}", type: Copy) { | ||
| dependsOn flutterTask | ||
| dependsOn variant.mergeAssets | ||
| dependsOn deleteOutputDir |
Contributor
There was a problem hiding this comment.
You should be able to replace this line with
dependsOn "clean${variant.mergeAssets.name.capitalize()}"
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Clean up output directory before copying over new files * Use standard clean task command
This was referenced Dec 3, 2019
engine-flutter-autoroll
added a commit
that referenced
this pull request
Dec 4, 2019
[email protected]:flutter/engine.git/compare/1a96087747ac...6179380 git log 1a96087..6179380 --first-parent --oneline 2019-12-03 [email protected] Update fallback to Roboto url to be HTTPS (#14086) 2019-12-03 [email protected] Revert "Fix fml_unittests (#14062)" (#14087) 2019-12-03 [email protected] Revert PRs to unblock David and Jim's work (#14088) 2019-12-03 [email protected] Roll fuchsia/sdk/core/mac-amd64 from 6QxEZ... to OSk8h... (#14085) 2019-12-03 [email protected] Roll src/third_party/dart e4344a568f..a4d799c402 (7 commits) (#14083) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up of whitespaces aside, this deletes output directory before copying new build artifacts over.
This complements #14081 that does the same thing on ios, which is needed to prevent incompatible(
--preview-dart-2vs non-preview-dart-2) build artifacts being included into the built app.This fixes #13878.