Skip to content

Set template and migrate apps to iOS 12 minimum#140921

Merged
auto-submit[bot] merged 1 commit intoflutter:flutter-3.16-candidate.0from
jmagman:cp-12
Jan 9, 2024
Merged

Set template and migrate apps to iOS 12 minimum#140921
auto-submit[bot] merged 1 commit intoflutter:flutter-3.16-candidate.0from
jmagman:cp-12

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 3, 2024 •
edited
Loading

Cherry-pick #140823

Issue #140923

This looks like a lot of files, but most of them are updating the version on our integration/examples apps.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman
Set template and migrate apps to iOS 12 minimum (flutter#140823)
86c85fe 
Reland flutter#140478 with `ios_content_validation_test` test fix.
```
[ios_content_validation_test] Process terminated with exit code 0.
Task result:
{
  "success": true,
  "data": null,
  "detailFiles": [],
  "benchmarkScoreKeys": [],
  "reason": "success"
}

```

__________

1. Change templates to `IPHONEOS_DEPLOYMENT_TARGET`, `MinimumOSVersion`, and Podfile `platform :ios` to 12.0.
2. Add migrator for Podfile part to migrate `platform :ios, '11.0'` -> `platform :ios, '12.0'`
3. Compile with `-miphoneos-version-min=12.0`
4. Run the migrator on all example apps and integration tests.

See also flutter#62902 and flutter#85174 and flutter#101963

Fixes flutter#136060
@jmagman jmagman self-assigned this Jan 3, 2024
@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin labels Jan 3, 2024
@jmagman jmagman mentioned this pull request Jan 3, 2024
Closed
@jmagman jmagman changed the title Set template and migrate apps to iOS 12 minimum (#140823) Set template and migrate apps to iOS 12 minimum Jan 8, 2024
@jmagman jmagman mentioned this pull request Jan 8, 2024
Closed
8 tasks
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2024
@auto-submit auto-submit bot merged commit 46787ee into flutter:flutter-3.16-candidate.0 Jan 9, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 10, 2024
@engine-flutter-autoroll
46787ee Set template and migrate apps to iOS 12 minimum (flutter/flut…
2faadb4 
…ter#140921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024
@engine-flutter-autoroll
46787ee Set template and migrate apps to iOS 12 minimum (flutter/flut…
e8ea0ae 
…ter#140921)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 11, 2024
@engine-flutter-autoroll
46787ee Set template and migrate apps to iOS 12 minimum (flutter/flut…
a6158ce 
…ter#140921)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuartmorgan-g stuartmorgan-g stuartmorgan-g approved these changes

Assignees

@jmagman jmagman

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @stuartmorgan-g @godofredoc