Call onPopInvoked when pages API is used#141221
Merged
justinmc merged 4 commits intoflutter:masterfrom Jan 10, 2024
Merged
Conversation
github-actions
bot
added
framework
justinmc
force-pushed
the
on-pop-invoked-pages
branch
from
17ce7f2 to
65424b5
Compare
goderbauer
approved these changes
Jan 10, 2024
| testWidgets('popping a page with canPop true still calls onPopInvoked', (WidgetTester tester) async { | ||
| final List<_PageWithYesPop> pages = <_PageWithYesPop>[_PageWithYesPop.home]; | ||
| bool canPop() => pages.length <= 1; | ||
| bool onPopInvokedWasCalled = false; |
Member
There was a problem hiding this comment.
Maybe turn this into a count, so we can be sure it is only invoked once and not multiple times via different code paths?
Contributor
Author
There was a problem hiding this comment.
That's a much better idea, thanks.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jan 11, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jan 11, 2024
flutter/flutter@b840a60...9f2e681 2024-01-11 [email protected] [Tool][Impeller] Make impellerc produce Vulkan and GLES shaders for Android. (flutter/flutter#140976) 2024-01-11 [email protected] Roll Packages from 378e700 to 0744fe6 (6 revisions) (flutter/flutter#141378) 2024-01-11 [email protected] Roll Flutter Engine from efd0eb62f4aa to ecdaed76f284 (1 revision) (flutter/flutter#141359) 2024-01-11 [email protected] Roll Flutter Engine from ade9f18fa008 to efd0eb62f4aa (2 revisions) (flutter/flutter#141356) 2024-01-11 [email protected] Roll Flutter Engine from 42e3e0236112 to ade9f18fa008 (2 revisions) (flutter/flutter#141337) 2024-01-11 [email protected] Roll Flutter Engine from f39f5ca18328 to 42e3e0236112 (2 revisions) (flutter/flutter#141327) 2024-01-11 [email protected] Roll Flutter Engine from 431d64dbb4b8 to f39f5ca18328 (1 revision) (flutter/flutter#141322) 2024-01-11 [email protected] Add dart fix support to flutter_driver (flutter/flutter#141300) 2024-01-11 [email protected] Fix a leak. (flutter/flutter#141312) 2024-01-10 [email protected] Add covariants to reduce subclass casts in 2D APIs (flutter/flutter#141318) 2024-01-10 [email protected] Roll Flutter Engine from a045134c910d to 431d64dbb4b8 (2 revisions) (flutter/flutter#141316) 2024-01-10 [email protected] Roll Flutter Engine from 6810c9a57460 to a045134c910d (2 revisions) (flutter/flutter#141313) 2024-01-10 [email protected] Call onPopInvoked when pages API is used (flutter/flutter#141221) 2024-01-10 [email protected] Fix mechanism to pass flag for leak tracking. (flutter/flutter#141226) 2024-01-10 [email protected] Roll Flutter Engine from 5d252831e62c to 6810c9a57460 (2 revisions) (flutter/flutter#141308) 2024-01-10 [email protected] Roll Flutter Engine from 6cb256fc4985 to 5d252831e62c (1 revision) (flutter/flutter#141302) 2024-01-10 [email protected] Roll Flutter Engine from 52aedc6c9153 to 6cb256fc4985 (1 revision) (flutter/flutter#141297) 2024-01-10 [email protected] Improve testing for leak tracking. (flutter/flutter#140553) 2024-01-10 [email protected] Roll Flutter Engine from d1a2007a28b4 to 52aedc6c9153 (2 revisions) (flutter/flutter#141291) 2024-01-10 [email protected] [flutter_tools] fix flutter create -t skeleton (flutter/flutter#141233) 2024-01-10 [email protected] Roll Flutter Engine from b361a60ae224 to d1a2007a28b4 (1 revision) (flutter/flutter#141285) 2024-01-10 [email protected] Unpin package:vm_service (flutter/flutter#141279) 2024-01-10 [email protected] Collapse pubspec.lock by default (flutter/flutter#141282) 2024-01-10 [email protected] Roll Packages from 09205ca to 378e700 (2 revisions) (flutter/flutter#141275) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using PopScope with the Navigator.pages API, PopScope.onPopInvoked is only called when the pop is blocked and not when it's allowed. This PR fixes it by adding a call along that codepath.
Fixes #141189
Fixes Google b/309771402