Fix incorrect zh-cn translation for Look Up Label in selection controls by LouiseHsu · Pull Request #142158 · flutter/flutter

LouiseHsu · 2024-01-24T19:17:56Z

Translation suggestion here:
https://tc.corp.google.com/btviewer/edittranslation?project=Flutter&msgId=8222331119728136330&language=zh-CN

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

HansMuller · 2024-01-24T20:13:14Z

LGTM

HansMuller

LGTM.

This change will eventually be overwritten by Google's translation service; hopefully there will be no effective change when that happens.

hellohuanlin · 2024-01-24T21:37:25Z

packages/flutter_localizations/lib/src/l10n/cupertino_zh.arb

  "noSpellCheckReplacementsLabel": "找不到替换文字",
  "menuDismissLabel": "关闭菜单",
-  "lookUpButtonLabel": "向上看",
+  "lookUpButtonLabel": "查询",


do we have a separate localization for traditional chinese?

We have zh_TW and zh_HK. Actually I think these ones already got it right somehow:

Locale lookupButtonLabel

en

flutter/packages/flutter_localizations/lib/src/l10n/material_en.arb

Line 205 in e985c29

"lookUpButtonLabel": "Look Up",

zh_TW

flutter/packages/flutter_localizations/lib/src/l10n/material_zh_TW.arb

Line 2 in e985c29

"lookUpButtonLabel": "查詢",

zh_HK

flutter/packages/flutter_localizations/lib/src/l10n/material_zh_HK.arb

Line 5 in e985c29

"lookUpButtonLabel": "查詢",

auto-submit · 2024-01-24T22:12:11Z

auto label is removed for flutter/flutter/142158, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

justinmc

LGTM 👍

justinmc · 2024-01-25T17:31:07Z

packages/flutter_localizations/test/material/translations_test.dart

+    final MaterialLocalizations localizations = await GlobalMaterialLocalizations.delegate.load(locale);
+    expect(localizations, isA<MaterialLocalizationZh>());
+    expect(localizations.lookUpButtonLabel, '查询');
+  });


Nit: Is it actually useful to add tests like this? If we've done it before then no worries, just checking.

added it just cuz the translations havent been approved yet, so small chance this change might get overwritten by the translation tool. i definitely also just copied this test because there were other tests in this file that do the same thing 😅

justinmc · 2024-01-25T17:38:13Z

packages/flutter_localizations/lib/src/l10n/cupertino_zh.arb

  "noSpellCheckReplacementsLabel": "找不到替换文字",
  "menuDismissLabel": "关闭菜单",
-  "lookUpButtonLabel": "向上看",
+  "lookUpButtonLabel": "查询",


We have zh_TW and zh_HK. Actually I think these ones already got it right somehow:

Locale lookupButtonLabel

en

flutter/packages/flutter_localizations/lib/src/l10n/material_en.arb

Line 205 in e985c29

"lookUpButtonLabel": "Look Up",

zh_TW

flutter/packages/flutter_localizations/lib/src/l10n/material_zh_TW.arb

Line 2 in e985c29

"lookUpButtonLabel": "查詢",

zh_HK

flutter/packages/flutter_localizations/lib/src/l10n/material_zh_HK.arb

Line 5 in e985c29

"lookUpButtonLabel": "查詢",

…n controls (flutter/flutter#142158)

Manual roll requested by [email protected] flutter/flutter@a8efa77...2f6fdf2 2024-01-26 [email protected] Start renaming by adding a new `bringup: true` as an Android emulator. (flutter/flutter#142257) 2024-01-26 [email protected] Instrument ImageInfo. (flutter/flutter#141411) 2024-01-26 [email protected] Fix `SegmentedButton` default size and default tappable size (flutter/flutter#142243) 2024-01-26 [email protected] Update name for android_defines_test. (flutter/flutter#142273) 2024-01-26 [email protected] Enable native compilation for windows-arm64 (flutter/flutter#141930) 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions)" (flutter/flutter#142274) 2024-01-25 [email protected] Run a few mac tests only on arm. (flutter/flutter#142188) 2024-01-25 [email protected] fix Ink not updating on TextField newline (flutter/flutter#140700) 2024-01-25 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 3.1.4 to 3.1.5 (flutter/flutter#142259) 2024-01-25 [email protected] Roll Flutter Engine from 4b145d041560 to 44f26274bfbe (6 revisions) (flutter/flutter#142264) 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Rename `integration_tests/external_ui` but do not touch anything else..."" (flutter/flutter#142268) 2024-01-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Rename `integration_tests/external_ui` but do not touch anything else..." (flutter/flutter#142265) 2024-01-25 [email protected] Roll Flutter Engine from b2167a93c1a0 to 4b145d041560 (3 revisions) (flutter/flutter#142256) 2024-01-25 [email protected] Implementing `switch` expressions in the `cupertino/` directory (flutter/flutter#141591) 2024-01-25 [email protected] Rename `integration_tests/external_ui` but do not touch anything else... (flutter/flutter#142238) 2024-01-25 [email protected] Roll Flutter Engine from 55eefd5bd255 to b2167a93c1a0 (2 revisions) (flutter/flutter#142252) 2024-01-25 [email protected] Roll Flutter Engine from 3b4779324b44 to 55eefd5bd255 (6 revisions) (flutter/flutter#142245) 2024-01-25 [email protected] Fix incorrect zh-cn translation for Look Up Label in selection controls (flutter/flutter#142158) 2024-01-25 [email protected] PopScope example improvements (flutter/flutter#142163) 2024-01-25 [email protected] Roll Flutter Engine from 1d3f16b0d62e to 3b4779324b44 (1 revision) (flutter/flutter#142225) 2024-01-25 [email protected] Roll Packages from 8fbdf65 to 21b5abb (6 revisions) (flutter/flutter#142224) 2024-01-25 [email protected] Don't show legacy welcome message when analytics are disabled (flutter/flutter#140956) 2024-01-25 [email protected] Roll Flutter Engine from 7c4ed15cb271 to 1d3f16b0d62e (1 revision) (flutter/flutter#142223) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fix translations

65acb58

LouiseHsu marked this pull request as ready for review January 24, 2024 20:10

HansMuller approved these changes Jan 24, 2024

View reviewed changes

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2024

hellohuanlin reviewed Jan 24, 2024

View reviewed changes

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 24, 2024

justinmc approved these changes Jan 25, 2024

View reviewed changes

LouiseHsu merged commit caba667 into flutter:master Jan 25, 2024

engine-flutter-autoroll mentioned this pull request Jan 26, 2024

Roll Flutter from a8efa771d6a3 to 988db6ba57ac (27 revisions) flutter/packages#5973

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

d283a1a

…n controls (flutter/flutter#142158)

engine-flutter-autoroll mentioned this pull request Jan 26, 2024

Roll Flutter from a8efa771d6a3 to 242facbcb9d3 (28 revisions) flutter/packages#5974

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

4e07218

…n controls (flutter/flutter#142158)

engine-flutter-autoroll mentioned this pull request Jan 26, 2024

Roll Flutter from a8efa771d6a3 to 827c94c4af87 (29 revisions) flutter/packages#5975

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

2c675a5

…n controls (flutter/flutter#142158)

engine-flutter-autoroll mentioned this pull request Jan 26, 2024

Roll Flutter from a8efa771d6a3 to 0b686be36edb (30 revisions) flutter/packages#5976

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

0ed4371

…n controls (flutter/flutter#142158)

engine-flutter-autoroll mentioned this pull request Jan 26, 2024

Roll Flutter from a8efa771d6a3 to 91068c89b96a (31 revisions) flutter/packages#5977

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

df0115b

…n controls (flutter/flutter#142158)

engine-flutter-autoroll mentioned this pull request Jan 26, 2024

Roll Flutter from a8efa771d6a3 to cd60dd921de4 (32 revisions) flutter/packages#5978

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

e52cfa8

…n controls (flutter/flutter#142158)

engine-flutter-autoroll mentioned this pull request Jan 26, 2024

Roll Flutter from a8efa771d6a3 to 91f0878fedb6 (33 revisions) flutter/packages#5980

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 26, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

0e63122

…n controls (flutter/flutter#142158)

HansMuller mentioned this pull request Jan 26, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

052d147

…n controls (flutter/flutter#142158)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 27, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

0fa89bb

…n controls (flutter/flutter#142158)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

0a6c388

…n controls (flutter/flutter#142158)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 28, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

2ab021b

…n controls (flutter/flutter#142158)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

8587367

…n controls (flutter/flutter#142158)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

a033b2f

…n controls (flutter/flutter#142158)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

a72c6e2

…n controls (flutter/flutter#142158)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

3ad59bd

…n controls (flutter/flutter#142158)

engine-flutter-autoroll mentioned this pull request Jan 29, 2024

Manual roll Flutter from a8efa771d6a3 to 370f40e6dfbf (26 revisions) flutter/packages#6006

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

07d07bb

…n controls (flutter/flutter#142158)

engine-flutter-autoroll mentioned this pull request Jan 29, 2024

Manual roll Flutter from a8efa771d6a3 to 2f6fdf2650d4 (23 revisions) flutter/packages#6008

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 29, 2024

caba667 Fix incorrect zh-cn translation for Look Up Label in selectio…

99fb24a

…n controls (flutter/flutter#142158)

huycozy mentioned this pull request Mar 8, 2024

Incorrect zh-CN translations on some texts #144825

Closed

LouiseHsu deleted the fix-incorrect-lookup-translation-zh branch March 8, 2024 22:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix incorrect zh-cn translation for Look Up Label in selection controls#142158

Fix incorrect zh-cn translation for Look Up Label in selection controls#142158
LouiseHsu merged 1 commit intoflutter:masterfrom
LouiseHsu:fix-incorrect-lookup-translation-zh

LouiseHsu commented Jan 24, 2024

Uh oh!

HansMuller commented Jan 24, 2024

Uh oh!

HansMuller left a comment

Uh oh!

hellohuanlin Jan 24, 2024

Uh oh!

justinmc Jan 25, 2024

Uh oh!

auto-submit bot commented Jan 24, 2024

Uh oh!

justinmc left a comment

Uh oh!

justinmc Jan 25, 2024 •

edited

Loading

Uh oh!

LouiseHsu Jan 25, 2024 •

edited

Loading

Uh oh!

justinmc Jan 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

LouiseHsu commented Jan 24, 2024

Pre-launch Checklist

Uh oh!

HansMuller commented Jan 24, 2024

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

hellohuanlin Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

justinmc Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jan 24, 2024

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Jan 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LouiseHsu Jan 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

justinmc Jan 25, 2024 •

edited

Loading

LouiseHsu Jan 25, 2024 •

edited

Loading