Skip to content

Migrate examples/hello_world Android app to Gradle Kotlin DSL#142300

Closed
bartekpacia wants to merge 4 commits intoflutter:masterfrom
bartekpacia:add_kotlin_gradle_dsl_app
Closed

Migrate examples/hello_world Android app to Gradle Kotlin DSL#142300
bartekpacia wants to merge 4 commits intoflutter:masterfrom
bartekpacia:add_kotlin_gradle_dsl_app

Conversation

@bartekpacia
Copy link
Member

@bartekpacia bartekpacia commented Jan 26, 2024 •
edited
Loading

This PR introduces the first app in this repo that only uses Gradle Kotlin DSL instead of Gradle Groovy DSL.

This PR was originally #141541, but it was reverted in #142018 because "Linux_android hello_world__memory" broke the tree. It is now fixed.

@github-actions github-actions bot added d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 26, 2024
@bartekpacia bartekpacia marked this pull request as ready for review January 28, 2024 00:36
reidbaker
reidbaker approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@reidbaker reidbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me but why did Linux_android hello_world__memory not fail when the first pr was put up? NVM It looks like the test is post submit only.

I could not find a passing test for a commit in this pr. I found https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_android%20hello_world__memory/11963/overview which looks like it is passing though.

Did you find a different way to run this test to verify the build worked?

@reidbaker reidbaker mentioned this pull request Jan 29, 2024
Closed
@bartekpacia
Copy link
Member Author

bartekpacia commented Jan 29, 2024 •
edited
Loading

Did you find a different way to run this test to verify the build worked?

I ran the test hello_world__memory test locally and it passed. The LUCI run you linked also confirms that.

Anyway, this PR has to wait for now since its "basis" (PR #140744 which added support for Gradle Kotlin KTS) is being reverted in #142266 and #142464.

@bartekpacia bartekpacia mentioned this pull request Feb 1, 2024
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Feb 2, 2024
@bartekpacia
Reland "Add support for Gradle Kotlin DSL (#140744)" (#142752)
6facb96 
This PR attempts to:
- reland #140744
- reland #141541 (which is also in #142300 - I will close it once this PR is merged)
@bartekpacia
Copy link
Member Author

bartekpacia commented Feb 7, 2024

done as part of #142752

@bartekpacia bartekpacia closed this Feb 7, 2024
@bartekpacia bartekpacia deleted the add_kotlin_gradle_dsl_app branch February 7, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

@camsim99 camsim99 Awaiting requested review from camsim99

Assignees

No one assigned

Labels

d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bartekpacia @reidbaker