Add stateful reordering test for TwoDimensionalViewport by Amir-P · Pull Request #142375 · flutter/flutter

Amir-P · 2024-01-27T14:05:26Z

Adds a test to validate state is preserved after reordering in TwoDimensionalViewport (reference: #141504 (review)).

Fixes 2D follow up: Persist state for reordered keyed children #130754

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks

Hey @Amir-P thanks for coming back for more! 🎉
Can you actually make this a new test? We want to preserve what the original test is validating in case of regressions.
More tests are never a bad thing! :)

Amir-P · 2024-02-25T18:44:41Z

Sorry for the delay. I've been busy. Could you please take a look again? @Piinks

Piinks

LGTM! Thanks for adding more testing! 😀

justinmc

LGTM with nits 👍 . Thanks!

justinmc · 2024-02-29T22:24:46Z

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

+        (WidgetTester tester) async {
+      final TwoDimensionalChildBuilderDelegate delegate1 =
+          TwoDimensionalChildBuilderDelegate(
+              maxXIndex: 5,


The indentation for these parameters should be 2 instead of 4.

justinmc · 2024-02-29T22:26:31Z

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

+                    const ChildVicinity(xIndex: 1, yIndex: 2)) {
+                  key = const ValueKey<int>(2);
+                }
+                return Checkbox(key: key, value: false, onChanged: (_) {});


See the styleguide about the anonymous parameter: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-anonymous-parameter-names

justinmc · 2024-02-29T22:26:45Z

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

+              });
+      final TwoDimensionalChildBuilderDelegate delegate2 =
+          TwoDimensionalChildBuilderDelegate(
+              maxXIndex: 5,


These parameters should also be outdented.

justinmc · 2024-02-29T22:27:52Z

packages/flutter/test/widgets/two_dimensional_viewport_test.dart

+      expect(tester.state(find.byKey(const ValueKey<int>(2))),
+          stateBeforeReordering);


Nit: For these expects, I would put each parameter on its own line.

expect( tester.state(find.byKey(const ValueKey<int>(2))), stateBeforeReordering, );

…ter/flutter#142375)

Roll Flutter from e92bca3 to ba719bc (37 revisions) flutter/flutter@e92bca3...ba719bc 2024-03-01 [email protected] Fix `CalendarDatePicker` day selection shape and overlay (flutter/flutter#144317) 2024-03-01 [email protected] Fix chips use square delete button `InkWell` shape instead of circular (flutter/flutter#144319) 2024-03-01 [email protected] InputDecorator M3 tests migration - Step4 - Hint tests (flutter/flutter#144169) 2024-03-01 [email protected] Roll Flutter Engine from f0037d4fbd67 to 2a5a9a6dead0 (1 revision) (flutter/flutter#144468) 2024-03-01 [email protected] Roll Flutter Engine from 16e04d264145 to f0037d4fbd67 (1 revision) (flutter/flutter#144464) 2024-03-01 [email protected] Roll Flutter Engine from 1dff89788b18 to 16e04d264145 (1 revision) (flutter/flutter#144459) 2024-03-01 [email protected] Horizontally expand text selection toolbar buttons in overflow menu (flutter/flutter#144391) 2024-03-01 [email protected] Roll Flutter Engine from f68cc57cbe12 to 1dff89788b18 (2 revisions) (flutter/flutter#144457) 2024-03-01 [email protected] Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) (flutter/flutter#144455) 2024-03-01 [email protected] Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) (flutter/flutter#144453) 2024-03-01 [email protected] Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) (flutter/flutter#144452) 2024-03-01 [email protected] Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) (flutter/flutter#144450) 2024-03-01 [email protected] Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) (flutter/flutter#144448) 2024-03-01 [email protected] Remove master from API docs (flutter/flutter#144425) 2024-03-01 [email protected] Enable missing-code-block-language (flutter/flutter#144443) 2024-03-01 [email protected] Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (flutter/flutter#144436) 2024-02-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/flutter#144424) 2024-02-29 [email protected] Reland [a11y] Fix date picker cannot focus on the edit field (flutter/flutter#144198) 2024-02-29 [email protected] Reland "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144431) 2024-02-29 [email protected] Make daemon server work on ipv6-only machines. (flutter/flutter#144359) 2024-02-29 [email protected] Remove deprecated `backgroundColor` from `ThemeData` (flutter/flutter#144079) 2024-02-29 [email protected] Add stateful reordering test for TwoDimensionalViewport (flutter/flutter#142375) 2024-02-29 [email protected] Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (flutter/flutter#144423) 2024-02-29 [email protected] Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (flutter/flutter#144419) 2024-02-29 [email protected] Fix a crash in remote device daemon. (flutter/flutter#144358) 2024-02-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144429) 2024-02-29 [email protected] Remove `toggleableActiveColor` from `ThemeData` (flutter/flutter#144178) 2024-02-29 [email protected] Add `FocusNode.focusabilityListenable` (flutter/flutter#144280) 2024-02-29 [email protected] Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (flutter/flutter#144416) 2024-02-29 [email protected] [devicelab] fix motog4 tests and update comment. (flutter/flutter#144410) 2024-02-29 [email protected] Bump dartdocs to 8.0.6 (flutter/flutter#144413) 2024-02-29 [email protected] Use dartpad's main channel for master/main docs (flutter/flutter#144329) 2024-02-29 [email protected] Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (flutter/flutter#144405) 2024-02-29 [email protected] Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (flutter/flutter#144399) 2024-02-29 [email protected] Roll Flutter Engine from 8179b0ed778e to 7dd404724c50 (3 revisions) (flutter/flutter#144395) 2024-02-29 [email protected] Roll Packages from 353086c to 6d02f03 (14 revisions) (flutter/flutter#144393) 2024-02-29 [email protected] Roll Flutter Engine from d068d980f952 to 8179b0ed778e (1 revision) (flutter/flutter#144378) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

…ter/flutter#142375)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Jan 27, 2024

goderbauer requested a review from Piinks January 30, 2024 23:10

Piinks reviewed Feb 1, 2024

View reviewed changes

Amir-P added 2 commits February 24, 2024 23:58

Add stateful reordering test for TwoDimensionalViewport

d2c3aa9

Restore previous test

cbfab42

Amir-P force-pushed the add_stateful_reordering_test branch from 01eba62 to cbfab42 Compare February 24, 2024 20:28

Amir-P requested a review from Piinks February 25, 2024 18:44

Piinks approved these changes Feb 29, 2024

View reviewed changes

gspencergoog approved these changes Feb 29, 2024

View reviewed changes

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024

justinmc approved these changes Feb 29, 2024

View reviewed changes

auto-submit bot merged commit 6068891 into flutter:master Feb 29, 2024

Amir-P deleted the add_stateful_reordering_test branch March 1, 2024 05:58

engine-flutter-autoroll mentioned this pull request Mar 1, 2024

Roll Flutter from e92bca3ff5d2 to ba719bc588ed (37 revisions) flutter/packages#6235

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2024

6068891 Add stateful reordering test for TwoDimensionalViewport (flut…

b2e2188

…ter/flutter#142375)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

6068891 Add stateful reordering test for TwoDimensionalViewport (flut…

39e167c

…ter/flutter#142375)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add stateful reordering test for TwoDimensionalViewport#142375

Add stateful reordering test for TwoDimensionalViewport#142375
auto-submit[bot] merged 2 commits intoflutter:masterfrom
Amir-P:add_stateful_reordering_test

Amir-P commented Jan 27, 2024

Uh oh!

Piinks left a comment

Uh oh!

Amir-P commented Feb 25, 2024

Uh oh!

Piinks left a comment

Uh oh!

justinmc left a comment

Uh oh!

justinmc Feb 29, 2024

Uh oh!

justinmc Feb 29, 2024

Uh oh!

justinmc Feb 29, 2024

Uh oh!

justinmc Feb 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		expect(tester.state(find.byKey(const ValueKey<int>(2))),
		stateBeforeReordering);

Conversation

Amir-P commented Jan 27, 2024

Pre-launch Checklist

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

Amir-P commented Feb 25, 2024

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

justinmc Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

justinmc Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

justinmc Feb 29, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants