[cp-stable]some random title#142674
Closed
XilaiZhang wants to merge 1 commit intoflutter:flutter-3.16-candidate.0from
Closed
[cp-stable]some random title#142674XilaiZhang wants to merge 1 commit intoflutter:flutter-3.16-candidate.0from
XilaiZhang wants to merge 1 commit intoflutter:flutter-3.16-candidate.0from
Conversation
* This seems to be unnecessary as users will open a CP PR with the original commit linked in it. * Add note on changelog description to be less than 80 chars
Contributor
Author
|
Hello @XilaiZhang! Looks like you attached the cp label and successfully created a cherry pick pr. |
fluttergithubbot
approved these changes
Feb 1, 2024
Contributor
Author
|
The actor will be whoever triggered the workflow run, not the pr author |
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
…142676) Context: Follow up from sync with @itsjustkevin today. Tag and ping the actor of workflow, when the cherry pick pull request is successfully created. 1. actor of workflow will be the username of the user that triggered the initial workflow run. i.e., whoever labels the PR. This person might not necessarily be the author of the cherry pick PR. 2. PR number of newly created cherry pick PR is parsed from the output of "gh pr create" as a multi line string. Tested: on cp success: #142674 pings the actor of workflow (not the pr author). on cp failure: [example workflow](https://github.com/XilaiZhang/miscellaneous-side-project/actions/runs/7734400373/job/21088324523) leaves a msg on the original PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is opened against a release branch.
To request a cherry pick of a commit, please fill in the form below. (Questions with an asterisk are required.)
To fill in the form, you can edit this PR description and type your answers after the 'My Answer' keywords.
A flutter domain expert will evaluate this cherry pick request shortly after ALL questions are answered.
See https://github.com/flutter/flutter/wiki/Hotfix-Documentation-Best-Practices for examples (Bug fix, feature, docs update, ...)