Enable the whole logcat log#143119
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
matanlurey
left a comment
There was a problem hiding this comment.
There is a test folder that includes commands that run against a fake ADB, is there a reason this can't be tested?
| // <String>['-s', deviceId, 'logcat'] | ||
| // to view the whole log, or just run logcat alongside this. | ||
| <String>['-s', deviceId, 'logcat', 'ActivityManager:I', 'flutter:V', '*:F'], | ||
| <String>['-s', deviceId, 'logcat'], |
There was a problem hiding this comment.
Is the entire comment stream above stale now?
There was a problem hiding this comment.
Good catch! Updated.
This is simply an |
|
Ok, I'm convinced. LGTM and test-exempt. |
Help with #142572.