Dual compile reland#143262
Conversation
mdebbar
left a comment
There was a problem hiding this comment.
I only looked at the 2 commits on top of the previously reverted PR. They look good to me!
|
@eyebrowsoffire I suspect that this PR may be blocking the Flutter --> packages roller based on @gspencergoog's findings (see discussion on Discord) on the web test failures in I think we should revert this PR, but let me know if you think this is a misfire. |
|
@camsim99 Thanks for flagging this. I took a look at the issue, and it appears that those failing tests in the flutter/packages seem to be depending on an actual bug in our code. Not specifying a web renderer in |
This is an attempt at a reland of #141396
The main changes here that are different than the original PR is fixes to wire up the
flutter testcommand properly with the web renderer.