Parameterize several mixins to avoid override errors when compiling with CFE#14327
Closed
mraleph wants to merge 1 commit intoflutter:masterfrom
Closed
Parameterize several mixins to avoid override errors when compiling with CFE#14327mraleph wants to merge 1 commit intoflutter:masterfrom
mraleph wants to merge 1 commit intoflutter:masterfrom
Conversation
Contributor
|
People hate SingleTickerProviderStateMixin enough as it is, I don't think we can afford to make it even more complicated. |
Contributor
|
Can this PR be closed now? |
Member
Author
|
Closing: a smaller version will be merged separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not yet for commit - but rather for informative purposes (see dart-lang/sdk#31984)
This PR adds type parameters to
TickerProviderStateMixin,SingleTickerProviderStateMixin,AutomaticKeepAliveClientMixinandRenderProxyBoxMixin.Having type parameters ensures that we don't have instantiations of the same class with different type arguments appearing in superinterfaces of mixin application.
/cc @Hixie @leafpetersen