Introduce avatarBoxConstraints & deleteIconBoxConstraints for the chips#143302
Merged
auto-submit[bot] merged 5 commits intoflutter:masterfrom Feb 13, 2024
TahaTesser:chip_icons_constraints
Merged
Introduce avatarBoxConstraints & deleteIconBoxConstraints for the chips#143302auto-submit[bot] merged 5 commits intoflutter:masterfrom TahaTesser:chip_icons_constraints
avatarBoxConstraints & deleteIconBoxConstraints for the chips#143302auto-submit[bot] merged 5 commits intoflutter:masterfrom
TahaTesser:chip_icons_constraints
Conversation
HansMuller
reviewed
Feb 12, 2024
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Including an example with the new constraints properties woudl be helpful. Using the same example would be fine, and the one used for this PR's description would do the job.
I think the new properties should be reflected in the ChipTheme.
Contributor
Author
Added theme values and examples. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2024
… for the chips (flutter/flutter#143302)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2024
… for the chips (flutter/flutter#143302)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 14, 2024
… for the chips (flutter/flutter#143302)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2024
… for the chips (flutter/flutter#143302)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2024
… for the chips (flutter/flutter#143302)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 15, 2024
… for the chips (flutter/flutter#143302)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
… for the chips (flutter/flutter#143302)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 16, 2024
… for the chips (flutter/flutter#143302)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
… for the chips (flutter/flutter#143302)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Chip widget's avatar padding changing if label text is more than 1 line
Code sample
expand to view the code sample
Preview
Examples previews
avatarBoxConstraintsdeleteIconBoxConstraintsPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.