Fix and test SemanticsController.simulatedAccessibilityTraversal by Piinks · Pull Request #143386 · flutter/flutter

Piinks · 2024-02-13T19:45:31Z

The start and end parameters of SemanticsController.simulatedAccessibilityTraversal were deprecated in #112413, but no tests were added that verified the new API. 😳

This change

fixes a typo in an error message
fixes the new startNode and endNode not being accounted for in setting the traversal range
adds dart fixes for the deprecations
adds tests for the new API that is meant to replace the deprecated one.
- Filed SemanticsController.simulatedAccessibilityTraversal broken in multiple views #143405 to follow up on the new API not working in multiple views.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks · 2024-02-13T22:19:40Z

packages/flutter_test/lib/src/controller.dart

      if (view != null && startView != view) {
        throw StateError(
-          'The end node is not part of the provided view.\n'
+          'The start node is not part of the provided view.\n'


This was the originally reported typo. 😆

goderbauer

Changes LGTM, just a question on how helpful the partial flutter fix is.

goderbauer · 2024-02-13T23:26:32Z

packages/flutter_test/test_fixes/flutter_test/semantics_controller.dart.expect

+  testWidgets('simulatedAccessibilityTraversal', (WidgetTester tester) async {
+    // Changes made in https://github.com/flutter/flutter/pull/143386
+    tester.semantics.simulatedAccessibilityTraversal();
+    tester.semantics.simulatedAccessibilityTraversal(startNode: theStart);


Hm, this will not compile, though, because startNode expects a FinderBase<SemanticsNode>, but theStart is a FinderBase<Element>.

Is this intentionally a part-fix? I am not sure how helpful that is...

It is partial. I always prefer to provide when we can, because during the deprecation period, the analyzer will say "Use startNode instead."
But after we remove it, it will only say "This is undefined."

Having the dart fix here means they will at least have a hint in the latter scenario that says "Use startNode."

packages/flutter_test/test_fixes/flutter_test/semantics_controller.dart

auto-submit · 2024-02-14T00:16:21Z

auto label is removed for flutter/flutter/143386, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Piinks · 2024-02-14T00:48:00Z

The Google testing shard keeps failing on an infra issue. Filed an internal bug, will follow up in the morning.

…ller.dart

…sal (flutter/flutter#143386)

Piinks · 2024-02-15T15:47:49Z

Reason for revert: This broke a customer test.

…sal (#143386)" This reverts commit f190d62.

…rsal (#143386)" (#143523) Reverts #143386 Initiated by: Piinks Reason for reverting: This broke a customer test. Original PR Author: Piinks Reviewed By: {goderbauer} This change reverts the following previous change: Original Description: Fixes #143173 The `start` and `end` parameters of `SemanticsController.simulatedAccessibilityTraversal` were deprecated in #112413, but no tests were added that verified the new API. 😳 This change - fixes a typo in an error message - fixes the new `startNode` and `endNode` not being accounted for in setting the traversal range - adds dart fixes for the deprecations - adds tests for the new API that is meant to replace the deprecated one. - Filed #143405 to follow up on the new API not working in multiple views.

…sal (flutter/flutter#143386)

…rsal (flutter#143386)" (flutter#143523) Reverts flutter#143386 Initiated by: Piinks Reason for reverting: This broke a customer test. Original PR Author: Piinks Reviewed By: {goderbauer} This change reverts the following previous change: Original Description: Fixes flutter#143173 The `start` and `end` parameters of `SemanticsController.simulatedAccessibilityTraversal` were deprecated in flutter#112413, but no tests were added that verified the new API. 😳 This change - fixes a typo in an error message - fixes the new `startNode` and `endNode` not being accounted for in setting the traversal range - adds dart fixes for the deprecations - adds tests for the new API that is meant to replace the deprecated one. - Filed flutter#143405 to follow up on the new API not working in multiple views.

#143528) â�¦rsal (#143386)" (#143523) Reverts #143386 Initiated by: Piinks Reason for reverting: This broke a customer test. Original PR Author: Piinks Reviewed By: {goderbauer} This change reverts the following previous change: Original Description: Fixes #143173 The `start` and `end` parameters of `SemanticsController.simulatedAccessibilityTraversal` were deprecated in #112413, but no tests were added that verified the new API. ð��³ This change - fixes a typo in an error message - fixes the new `startNode` and `endNode` not being accounted for in setting the traversal range - adds dart fixes for the deprecations - adds tests for the new API that is meant to replace the deprecated one. - Filed #143405 to follow up on the new API not working in multiple views.

Relands #143386 Which was reverted in #143523 Fixes #143173 Unblocks #143485 â� â�¡ï¸� Update from the revert is in this commit: 1e68532

…sal (flutter/flutter#143386)

Roll Flutter from a628814 to d7867ca (66 revisions) flutter/flutter@a628814...d7867ca 2024-02-16 [email protected] Roll Packages from ef349be to c56c12d (5 revisions) (flutter/flutter#143581) 2024-02-16 [email protected] Update `MaterialStatesController` docs for calling `setState` in a listener (flutter/flutter#143453) 2024-02-16 [email protected] Update `DataTable` docs for disabled `DataRow` ink well (flutter/flutter#143450) 2024-02-16 [email protected] Roll Flutter Engine from b7103bc8b374 to dd530f1556df (17 revisions) (flutter/flutter#143565) 2024-02-16 [email protected] Manual roll Flutter Engine from b7103bc8b374 to 7de84271eb65 (flutter/flutter#143564) 2024-02-16 [email protected] Manual roll Flutter Engine from d3c71d78f8ef to df0dc1fc06ca (flutter/flutter#143563) 2024-02-16 [email protected] Manual roll Flutter Engine from bc4dd534a0fa to d3c71d78f8ef (flutter/flutter#143561) 2024-02-16 [email protected] Manual roll Flutter Engine from edb2745e9834 to bc4dd534a0fa (flutter/flutter#143559) 2024-02-16 [email protected] Manual roll Flutter Engine from 15a358bbaf71 to edb2745e9834 (flutter/flutter#143555) 2024-02-16 [email protected] [devicelab] retain prior events for flutter gallery. (flutter/flutter#143554) 2024-02-16 [email protected] Reland "Disentangle and align flutter build web --wasm flags (#143517)" (flutter/flutter#143549) 2024-02-16 [email protected] Roll Flutter Engine from 3af336bfb2df to 15a358bbaf71 (1 revision) (flutter/flutter#143428) 2024-02-15 [email protected] Android Gradle file templates: make it easier to convert them to Kotlin DSL in the future (flutter/flutter#142146) 2024-02-15 [email protected] Remove bringup from win arm64 builds. (flutter/flutter#143548) 2024-02-15 [email protected] Fix minor spelling error (flutter/flutter#143541) 2024-02-15 [email protected] [devicelab] migrate new gallery benchmarks to local copy. (flutter/flutter#143545) 2024-02-15 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/flutter#143546) 2024-02-15 [email protected] [flutter_tool] [dap] Forward Flutter progress events to DAP client (flutter/flutter#142524) 2024-02-15 [email protected] Swap the tasks that have been running fine for a while. (flutter/flutter#143544) 2024-02-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disentangle and align `flutter build web --wasm` flags (#143517)" (flutter/flutter#143547) 2024-02-15 [email protected] Reland simulatedAccessibilityTraversal fix (flutter/flutter#143527) 2024-02-15 [email protected] Disentangle and align `flutter build web --wasm` flags (flutter/flutter#143517) 2024-02-15 [email protected] [devicelab] introduce new old gallery. (flutter/flutter#143486) 2024-02-15 [email protected] Remove certs dependency. (flutter/flutter#143495) 2024-02-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix and test SemanticsController.simulatedAccessibilityTraversal (#143386)" (flutter/flutter#143523) 2024-02-15 [email protected] Roll Packages from a864254 to ef349be (9 revisions) (flutter/flutter#143521) 2024-02-15 [email protected] Modify `plugin_ffi` and `package_ffi` template (flutter/flutter#143376) 2024-02-15 [email protected] Remove certs installation from win_arm builds. (flutter/flutter#143487) 2024-02-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[a11y] Add isEnabled semantics flag to text field (#143334)" (flutter/flutter#143494) 2024-02-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[a11y] Fix date picker cannot focus on the edit field (#143117)" (flutter/flutter#143493) 2024-02-14 [email protected] [a11y] Fix date picker cannot focus on the edit field (flutter/flutter#143117) 2024-02-14 [email protected] cleanup now-irrelevant ignores for `deprecated_member_use` (flutter/flutter#143403) 2024-02-14 [email protected] Fix and test SemanticsController.simulatedAccessibilityTraversal (flutter/flutter#143386) 2024-02-14 [email protected] Disable deprecation warnings for mega_gallery (flutter/flutter#143466) 2024-02-14 [email protected] The initial/selected item on popup menu should always be visible (flutter/flutter#143118) 2024-02-14 [email protected] Roll native_assets_builder to 0.5.0 (flutter/flutter#143472) 2024-02-14 [email protected] InputDecorator M3 test migration step2 (flutter/flutter#143369) 2024-02-14 [email protected] Add more documentation for TextEditingController default constructor (flutter/flutter#143452) 2024-02-14 [email protected] Format all kotlin according to ktlint (flutter/flutter#143390) 2024-02-14 [email protected] Marks Linux_pixel_7pro integration_ui_keyboard_resize to be unflaky (flutter/flutter#143440) 2024-02-14 [email protected] Roll Packages from 9385bbb to a864254 (6 revisions) (flutter/flutter#143454) 2024-02-14 [email protected] [tools] Add column header for emulators information (flutter/flutter#142853) 2024-02-14 [email protected] Use `dart compile wasm` for wasm compilations (flutter/flutter#143298) 2024-02-14 [email protected] [devicelab] retain first frame data in certain integration tests. (flutter/flutter#143419) 2024-02-14 [email protected] Roll Flutter Engine from 0849250a1419 to 3af336bfb2df (2 revisions) (flutter/flutter#143427) 2024-02-14 [email protected] Roll Flutter Engine from 215d55f4f82d to 0849250a1419 (2 revisions) (flutter/flutter#143425) ...

…sal (flutter/flutter#143386)

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: tech-debt Technical debt, code quality, testing, etc. labels Feb 13, 2024

Piinks added the a: error message Error messages from the Flutter framework label Feb 13, 2024

Piinks commented Feb 13, 2024

View reviewed changes

Piinks mentioned this pull request Feb 13, 2024

SemanticsController.simulatedAccessibilityTraversal broken in multiple views #143405

Closed

Piinks requested a review from goderbauer February 13, 2024 22:29

Piinks changed the title ~~[WIP] Fix and test SemanticsController.simulatedAccessibilityTraversal~~ Fix and test SemanticsController.simulatedAccessibilityTraversal Feb 13, 2024

Piinks marked this pull request as ready for review February 13, 2024 22:30

goderbauer approved these changes Feb 13, 2024

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024

Piinks added 5 commits February 14, 2024 12:32

Need to test

dc501fd

dart fixes

de8ee22

Add tets

2828746

Self review

7bed3be

Update packages/flutter_test/test_fixes/flutter_test/semantics_contro…

0a8667f

…ller.dart

Piinks force-pushed the untestedDeprecation branch from 74b8b6b to 0a8667f Compare February 14, 2024 18:32

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 14, 2024

auto-submit bot merged commit f190d62 into flutter:master Feb 14, 2024

engine-flutter-autoroll mentioned this pull request Feb 15, 2024

Roll Flutter from a628814ebd25 to 97ab92ee353e (40 revisions) flutter/packages#6133

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024

f190d62 Fix and test SemanticsController.simulatedAccessibilityTraver…

4481226

…sal (flutter/flutter#143386)

Piinks mentioned this pull request Feb 15, 2024

Fix SemanticsFinder for multi-view #143485

Merged

engine-flutter-autoroll mentioned this pull request Feb 15, 2024

Roll Flutter from a628814ebd25 to c0778318f9c9 (41 revisions) flutter/packages#6135

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024

f190d62 Fix and test SemanticsController.simulatedAccessibilityTraver…

f86a983

…sal (flutter/flutter#143386)

Piinks added the revert Autorevert PR (with "Reason for revert:" comment) label Feb 15, 2024

auto-submit bot pushed a commit that referenced this pull request Feb 15, 2024

Revert "Fix and test SemanticsController.simulatedAccessibilityTraver…

b67c153

…sal (#143386)" This reverts commit f190d62.

auto-submit bot mentioned this pull request Feb 15, 2024

Reverts "Fix and test SemanticsController.simulatedAccessibilityTraversal (#143386)" #143523

Merged

8 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Feb 15, 2024

engine-flutter-autoroll mentioned this pull request Feb 15, 2024

Roll Flutter from a628814ebd25 to d00fe8faae66 (42 revisions) flutter/packages#6136

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 15, 2024

f190d62 Fix and test SemanticsController.simulatedAccessibilityTraver…

6595b15

…sal (flutter/flutter#143386)

Piinks mentioned this pull request Feb 15, 2024

Reland simulatedAccessibilityTraversal fix #143527

Merged

8 tasks

Jasguerrero mentioned this pull request Feb 15, 2024

Reverts "Fix and test SemanticsController.simulatedAccessibilityTrave… #143528

Merged

auto-submit bot pushed a commit that referenced this pull request Feb 15, 2024

Reland simulatedAccessibilityTraversal fix (#143527)

ea3d066

Relands #143386 Which was reverted in #143523 Fixes #143173 Unblocks #143485 â� â�¡ï¸� Update from the revert is in this commit: 1e68532

engine-flutter-autoroll mentioned this pull request Feb 16, 2024

Roll Flutter from a628814ebd25 to a603a178757f (65 revisions) flutter/packages#6144

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

f190d62 Fix and test SemanticsController.simulatedAccessibilityTraver…

eedb85a

…sal (flutter/flutter#143386)

engine-flutter-autoroll mentioned this pull request Feb 16, 2024

Roll Flutter from a628814ebd25 to d7867ca7d635 (66 revisions) flutter/packages#6146

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024

f190d62 Fix and test SemanticsController.simulatedAccessibilityTraver…

fde24b5

…sal (flutter/flutter#143386)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

f190d62 Fix and test SemanticsController.simulatedAccessibilityTraver…

38fd681

…sal (flutter/flutter#143386)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix and test SemanticsController.simulatedAccessibilityTraversal#143386

Fix and test SemanticsController.simulatedAccessibilityTraversal#143386
auto-submit[bot] merged 5 commits intoflutter:masterfrom
Piinks:untestedDeprecation

Piinks commented Feb 13, 2024 •

edited

Loading

Uh oh!

Piinks Feb 13, 2024

Uh oh!

goderbauer left a comment

Uh oh!

goderbauer Feb 13, 2024

Uh oh!

Piinks Feb 14, 2024

Uh oh!

Uh oh!

auto-submit bot commented Feb 14, 2024

Uh oh!

Piinks commented Feb 14, 2024

Uh oh!

Piinks commented Feb 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Piinks commented Feb 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Piinks Feb 13, 2024

Choose a reason for hiding this comment

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer Feb 13, 2024

Choose a reason for hiding this comment

Uh oh!

Piinks Feb 14, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit bot commented Feb 14, 2024

Uh oh!

Piinks commented Feb 14, 2024

Uh oh!

Piinks commented Feb 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Piinks commented Feb 13, 2024 •

edited

Loading