[Not intended to land] Dummy benchmark for platform view scroll and ads banner#143805
Closed
hellohuanlin wants to merge 1 commit intoflutter:masterfrom
Closed
[Not intended to land] Dummy benchmark for platform view scroll and ads banner#143805hellohuanlin wants to merge 1 commit intoflutter:masterfrom
hellohuanlin wants to merge 1 commit intoflutter:masterfrom
Conversation
8 tasks
hellohuanlin
changed the title
hellohuanlin
changed the title
hellohuanlin
changed the title
Contributor
Author
|
Closing in favor of #145224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not intended to land. Just a dummy benchmark while working on platform view performance issues.
Based on https://github.com/lucalooz/flutter_ads_list_perf from #129632, except that I don't use real AdMob (since it's a non-flutter-org repo).
Also I used 320x50 standard banner size, so I can fit 7-8 banners on screen, which should be enough (i guess?).
Feel free to use it when working on platform view performance.
Under devicelab, run