Implementing switch expressions in rendering/#143812
Merged
auto-submit[bot] merged 5 commits intoflutter:masterfrom Feb 26, 2024
Merged
Implementing switch expressions in rendering/#143812auto-submit[bot] merged 5 commits intoflutter:masterfrom
switch expressions in rendering/#143812auto-submit[bot] merged 5 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
framework
nate-thegrate
commented
Feb 21, 2024
Member
|
@Piinks can you take a look at this one since it is mostly slivers and scrolling? |
Contributor
For sure! |
Piinks
reviewed
Feb 21, 2024
| @@ -792,19 +780,15 @@ class RenderFlex extends RenderBox with ContainerRenderObjectMixin<RenderBox, Fl | |||
| } else { | |||
| final BoxConstraints innerConstraints; | |||
| if (crossAxisAlignment == CrossAxisAlignment.stretch) { | |||
Contributor
There was a problem hiding this comment.
Hmm, this caught my eye. It is an enum without an exhaustive switch statement!
Do you think crossAxisAlignment and _direction can be used together?
I think there is one other if (crossAxisAlignment == CrossAxisAlignment.stretch) { in this file too if it seems feasible to alter the loci to be exhaustive.
What do you think?
Contributor
Author
There was a problem hiding this comment.
I think that sounds great 🙂👍
I updated _computeSizes() to get rid of every == enum comparison. Really happy with how it looks now!
Comment on lines
-98
to
-99
| final Size childSize; | ||
| final Offset scrollOffset; |
Contributor
There was a problem hiding this comment.
Could these be combined into a record for one switch statement? I noticed that in packages/flutter/lib/src/rendering/paragraph.dart in this PR. :)
Contributor
Author
There was a problem hiding this comment.
Yes they could! I had them combined originally but the line length was a bit much.
But after looking over it again, I think we could make it work by inverting the if-statement, so it returns early instead of indenting the whole function.
While I'm at it, I'll refactor position into an exhaustive switch statement too :)
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 27, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Feb 27, 2024
flutter/flutter@b77560e...c30f998 2024-02-27 [email protected] [flutter_tools] Fix missing stack trace from daemon (flutter/flutter#144113) 2024-02-27 [email protected] Roll Flutter Engine from 04ff2868ce80 to 0bc21ea7bc92 (21 revisions) (flutter/flutter#144208) 2024-02-26 [email protected] Move debugShowWidgetInspectorOverride (flutter/flutter#144029) 2024-02-26 [email protected] Allow `Listenable.merge()` to use any iterable (flutter/flutter#143675) 2024-02-26 [email protected] Mark firebase_release_smoke_test as `bringup: true` (flutter/flutter#144186) 2024-02-26 [email protected] refactor: Differentiate pubspec and resolution errors for plugins (flutter/flutter#142035) 2024-02-26 [email protected] Roll Flutter Engine from 34a8b9bdaaac to 04ff2868ce80 (1 revision) (flutter/flutter#144159) 2024-02-26 [email protected] Implementing `switch` expressions in `rendering/` (flutter/flutter#143812) 2024-02-26 [email protected] Roll Flutter Engine from 7a573c21a4ad to 34a8b9bdaaac (1 revision) (flutter/flutter#144147) 2024-02-26 [email protected] Roll Flutter Engine from a15326b2c439 to 7a573c21a4ad (1 revision) (flutter/flutter#144145) 2024-02-26 [email protected] Update copyDirectory to allow links to not be followed (flutter/flutter#144040) 2024-02-26 [email protected] Roll Packages from 7df2085 to 353086c (7 revisions) (flutter/flutter#144144) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
flutter/flutter@b77560e...c30f998 2024-02-27 [email protected] [flutter_tools] Fix missing stack trace from daemon (flutter/flutter#144113) 2024-02-27 [email protected] Roll Flutter Engine from 04ff2868ce80 to 0bc21ea7bc92 (21 revisions) (flutter/flutter#144208) 2024-02-26 [email protected] Move debugShowWidgetInspectorOverride (flutter/flutter#144029) 2024-02-26 [email protected] Allow `Listenable.merge()` to use any iterable (flutter/flutter#143675) 2024-02-26 [email protected] Mark firebase_release_smoke_test as `bringup: true` (flutter/flutter#144186) 2024-02-26 [email protected] refactor: Differentiate pubspec and resolution errors for plugins (flutter/flutter#142035) 2024-02-26 [email protected] Roll Flutter Engine from 34a8b9bdaaac to 04ff2868ce80 (1 revision) (flutter/flutter#144159) 2024-02-26 [email protected] Implementing `switch` expressions in `rendering/` (flutter/flutter#143812) 2024-02-26 [email protected] Roll Flutter Engine from 7a573c21a4ad to 34a8b9bdaaac (1 revision) (flutter/flutter#144147) 2024-02-26 [email protected] Roll Flutter Engine from a15326b2c439 to 7a573c21a4ad (1 revision) (flutter/flutter#144145) 2024-02-26 [email protected] Update copyDirectory to allow links to not be followed (flutter/flutter#144040) 2024-02-26 [email protected] Roll Packages from 7df2085 to 353086c (7 revisions) (flutter/flutter#144144) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
8 tasks
9 tasks
nate-thegrate
added
the
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is part of the effort to solve issue #136139.
The previous
switchexpressions PR was comprised of many simple changes throughoutflutter/lib/src/, but due to some more in-depth refactoring influtter/lib/src/rendering/, I decided to submit the changes to this directory as a separate pull request.There was really just one function that I changed significantly; I'll add a comment for explanation.
Pre-launch Checklist
///).