Add CloseButtonTooltip to the 'X' button on a SnackBar by dsanagustin · Pull Request #143934 · flutter/flutter

dsanagustin · 2024-02-22T14:58:44Z

Adds a localized Close Button tooltip to the 'X' Button on a SnackBar, making it readable by screen readers.

Github Issue #143793

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA. (No need. I am a Googler.)
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///). No need. I made a one-line change to a function.
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

goderbauer

LGTM with two tiny nits

packages/flutter/test/material/snack_bar_test.dart

dsanagustin · 2024-02-22T20:44:48Z

LGTM with two tiny nits

@goderbauer Suggestions applied, thank you so much! Quick question: I don't have write access to this repo -- how can I merge this PR once the checks pass?

goderbauer · 2024-02-22T21:03:18Z

You'll need a secondary LGTM (I just pinged someone), and then one of us can merge it.

gspencergoog

auto-submit · 2024-02-22T21:06:53Z

auto label is removed for flutter/flutter/143934, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Co-authored-by: Michael Goderbauer <[email protected]>

…er/flutter#143934)

flutter/flutter@41581c9...39585e6 2024-02-23 [email protected] Re-enable Impeller goldens blocking. (flutter/flutter#144023) 2024-02-23 [email protected] Roll Flutter Engine from 0f3ad23b84ed to 5f99a6c3289e (16 revisions) (flutter/flutter#144028) 2024-02-23 [email protected] Roll Packages from 078c2a3 to 7df2085 (3 revisions) (flutter/flutter#144030) 2024-02-23 [email protected] Run tests on iOS 17 exclusively (flutter/flutter#144022) 2024-02-23 [email protected] Retry button tap in [FlutterUITests testFlutterViewWarm] (flutter/flutter#143967) 2024-02-23 [email protected] Remove deprecated `InteractiveViewer.alignPanAxis` (flutter/flutter#142500) 2024-02-23 [email protected] Remove deprecated `KeepAliveHandle.release` (flutter/flutter#143961) 2024-02-23 [email protected] Remove deprecated AnimatedListItemBuilder, AnimatedListRemovedItemBuilder (flutter/flutter#143974) 2024-02-23 [email protected] Manual roll Flutter Engine from 06448ee8165f to 0f3ad23b84ed (16 revisions) (flutter/flutter#143989) 2024-02-23 [email protected] Remove deprecated TimelineSummary.writeSummaryToFile (flutter/flutter#143983) 2024-02-23 [email protected] Remove unused drone_dimension field (flutter/flutter#143984) 2024-02-23 [email protected] Remove deprecated MediaQuery.boldTextOverride (flutter/flutter#143960) 2024-02-22 [email protected] Revert engine back to 06448ee8165f4ff6579ef9510ac69322eda896ac (flutter/flutter#143986) 2024-02-22 [email protected] Remove deprecated FlutterDriver.enableAccessibility (flutter/flutter#143979) 2024-02-22 [email protected] Roll Flutter Engine from cb6115d3a6ab to c5d2e011652b (3 revisions) (flutter/flutter#143980) 2024-02-22 [email protected] Revert "Introduce tone-based surfaces and accent color add-ons - Part 2" (flutter/flutter#143973) 2024-02-22 [email protected] Add CloseButtonTooltip to the 'X' button on a SnackBar (flutter/flutter#143934) 2024-02-22 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/flutter#143971) 2024-02-22 [email protected] Roll Flutter Engine from 06448ee8165f to cb6115d3a6ab (10 revisions) (flutter/flutter#143972) 2024-02-22 [email protected] Use inlining annotations on important methods for all targets (flutter/flutter#143923) 2024-02-22 [email protected] Add missing `TextPainter.strutStyle` to paragraph style (flutter/flutter#143771) 2024-02-22 [email protected] Shift Moto G4 staging tests to A02s (flutter/flutter#143957) 2024-02-22 [email protected] Add CurvedAnimation disposals in some widgets (flutter/flutter#143790) 2024-02-22 [email protected] Fix documentation typo in basic.dart (flutter/flutter#143887) 2024-02-22 [email protected] Fixed Small Typo in Emulators Test Name (flutter/flutter#143578) 2024-02-22 [email protected] Support using lightweight Flutter Engines to run tests (flutter/flutter#141726) 2024-02-22 [email protected] Roll Flutter Engine from 9250bfdb38c5 to 06448ee8165f (1 revision) (flutter/flutter#143943) 2024-02-22 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland Add UI Benchmarks (#143542) (#143799)" (flutter/flutter#143946) 2024-02-22 [email protected] Roll Packages from 48048f6 to 078c2a3 (11 revisions) (flutter/flutter#143935) 2024-02-22 [email protected] Roll Flutter Engine from 7777480eb94d to 9250bfdb38c5 (8 revisions) (flutter/flutter#143933) 2024-02-22 [email protected] Reland Add UI Benchmarks (#143542) (flutter/flutter#143799) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…er/flutter#143934)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Feb 22, 2024

dsanagustin force-pushed the snackbar-x-tooltip branch 2 times, most recently from 74ea14c to 5dea555 Compare February 22, 2024 17:49

goderbauer approved these changes Feb 22, 2024

View reviewed changes

packages/flutter/test/material/snack_bar_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/snack_bar_test.dart Outdated Show resolved Hide resolved

gspencergoog approved these changes Feb 22, 2024

View reviewed changes

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2024

dsanagustin and others added 3 commits February 22, 2024 16:13

add localized close button tooltip to X button on snackbar.

3d331fa

add test

6922376

Apply suggestions from code review

0ee1d4f

Co-authored-by: Michael Goderbauer <[email protected]>

dsanagustin force-pushed the snackbar-x-tooltip branch from d9f580f to 0ee1d4f Compare February 22, 2024 21:13

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 22, 2024

auto-submit bot merged commit 1653592 into flutter:master Feb 22, 2024

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to fcd154bd247f (26 revisions) flutter/packages#6188

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

1653592 Add CloseButtonTooltip to the 'X' button on a SnackBar (flutt…

a236b43

…er/flutter#143934)

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to 00229827ab7c (27 revisions) flutter/packages#6189

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

1653592 Add CloseButtonTooltip to the 'X' button on a SnackBar (flutt…

1285fc3

…er/flutter#143934)

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to bb856079c401 (28 revisions) flutter/packages#6190

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

1653592 Add CloseButtonTooltip to the 'X' button on a SnackBar (flutt…

7781eb2

…er/flutter#143934)

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to bab5f85df560 (29 revisions) flutter/packages#6193

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

1653592 Add CloseButtonTooltip to the 'X' button on a SnackBar (flutt…

91783d6

…er/flutter#143934)

engine-flutter-autoroll mentioned this pull request Feb 23, 2024

Roll Flutter from 41581c9a1b90 to 39585e66c11f (31 revisions) flutter/packages#6194

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 23, 2024

1653592 Add CloseButtonTooltip to the 'X' button on a SnackBar (flutt…

ee81aaa

…er/flutter#143934)

HansMuller mentioned this pull request Feb 28, 2024

Add Tooltips to the Close Button of Snackbar #143793

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

1653592 Add CloseButtonTooltip to the 'X' button on a SnackBar (flutt…

a45783f

…er/flutter#143934)

goderbauer mentioned this pull request Jun 13, 2024

No Overlay widget found exception When showing snackbar #148314

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add CloseButtonTooltip to the 'X' button on a SnackBar#143934

Add CloseButtonTooltip to the 'X' button on a SnackBar#143934
auto-submit[bot] merged 3 commits intoflutter:masterfrom
dsanagustin:snackbar-x-tooltip

dsanagustin commented Feb 22, 2024 •

edited

Loading

Uh oh!

goderbauer left a comment

Uh oh!

Uh oh!

Uh oh!

dsanagustin commented Feb 22, 2024

Uh oh!

goderbauer commented Feb 22, 2024

Uh oh!

gspencergoog left a comment

Uh oh!

auto-submit bot commented Feb 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dsanagustin commented Feb 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dsanagustin commented Feb 22, 2024

Uh oh!

goderbauer commented Feb 22, 2024

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Feb 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dsanagustin commented Feb 22, 2024 •

edited

Loading