Add `FocusNode.focusabilityListenable` by LongCatIsLooong · Pull Request #144280 · flutter/flutter

LongCatIsLooong · 2024-02-28T01:11:53Z

This is for #127803: a text field should unregister from the scribble scope, when it becomes unfocusable.

When a FocusNode has listeners and its _canRequestFocus flag is set to true, it adds +1 to _focusabilityListeningDescendantCount of all ancestors until it reaches the first ancestor with descendantsAreFocusable = false. When the a FocusNode's descendantsAreFocusable changes, all listeners that contributed to its _focusabilityListeningDescendantCount will be notified.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gspencergoog

This looks great, and it might even make canRequestFocus more efficient.

Roll Flutter from e92bca3 to ba719bc (37 revisions) flutter/flutter@e92bca3...ba719bc 2024-03-01 [email protected] Fix `CalendarDatePicker` day selection shape and overlay (flutter/flutter#144317) 2024-03-01 [email protected] Fix chips use square delete button `InkWell` shape instead of circular (flutter/flutter#144319) 2024-03-01 [email protected] InputDecorator M3 tests migration - Step4 - Hint tests (flutter/flutter#144169) 2024-03-01 [email protected] Roll Flutter Engine from f0037d4fbd67 to 2a5a9a6dead0 (1 revision) (flutter/flutter#144468) 2024-03-01 [email protected] Roll Flutter Engine from 16e04d264145 to f0037d4fbd67 (1 revision) (flutter/flutter#144464) 2024-03-01 [email protected] Roll Flutter Engine from 1dff89788b18 to 16e04d264145 (1 revision) (flutter/flutter#144459) 2024-03-01 [email protected] Horizontally expand text selection toolbar buttons in overflow menu (flutter/flutter#144391) 2024-03-01 [email protected] Roll Flutter Engine from f68cc57cbe12 to 1dff89788b18 (2 revisions) (flutter/flutter#144457) 2024-03-01 [email protected] Roll Flutter Engine from 76140bc9cec9 to f68cc57cbe12 (2 revisions) (flutter/flutter#144455) 2024-03-01 [email protected] Roll Flutter Engine from f300ced56a4e to 76140bc9cec9 (1 revision) (flutter/flutter#144453) 2024-03-01 [email protected] Roll Flutter Engine from 34cf95c7bd82 to f300ced56a4e (1 revision) (flutter/flutter#144452) 2024-03-01 [email protected] Roll Flutter Engine from 0db468f7bae5 to 34cf95c7bd82 (1 revision) (flutter/flutter#144450) 2024-03-01 [email protected] Roll Flutter Engine from 6f8044436eb3 to 0db468f7bae5 (3 revisions) (flutter/flutter#144448) 2024-03-01 [email protected] Remove master from API docs (flutter/flutter#144425) 2024-03-01 [email protected] Enable missing-code-block-language (flutter/flutter#144443) 2024-03-01 [email protected] Roll Flutter Engine from 7e8fefe4a084 to 6f8044436eb3 (5 revisions) (flutter/flutter#144436) 2024-02-29 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/flutter#144424) 2024-02-29 [email protected] Reland [a11y] Fix date picker cannot focus on the edit field (flutter/flutter#144198) 2024-02-29 [email protected] Reland "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144431) 2024-02-29 [email protected] Make daemon server work on ipv6-only machines. (flutter/flutter#144359) 2024-02-29 [email protected] Remove deprecated `backgroundColor` from `ThemeData` (flutter/flutter#144079) 2024-02-29 [email protected] Add stateful reordering test for TwoDimensionalViewport (flutter/flutter#142375) 2024-02-29 [email protected] Always use local CanvasKit/Skwasm in benchmarks for better hermeticity. (flutter/flutter#144423) 2024-02-29 [email protected] Roll Flutter Engine from bb6c6a01000f to 7e8fefe4a084 (2 revisions) (flutter/flutter#144419) 2024-02-29 [email protected] Fix a crash in remote device daemon. (flutter/flutter#144358) 2024-02-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use dartpad's main channel for master/main docs (#144329)" (flutter/flutter#144429) 2024-02-29 [email protected] Remove `toggleableActiveColor` from `ThemeData` (flutter/flutter#144178) 2024-02-29 [email protected] Add `FocusNode.focusabilityListenable` (flutter/flutter#144280) 2024-02-29 [email protected] Roll Flutter Engine from 1f24eaa4979d to bb6c6a01000f (2 revisions) (flutter/flutter#144416) 2024-02-29 [email protected] [devicelab] fix motog4 tests and update comment. (flutter/flutter#144410) 2024-02-29 [email protected] Bump dartdocs to 8.0.6 (flutter/flutter#144413) 2024-02-29 [email protected] Use dartpad's main channel for master/main docs (flutter/flutter#144329) 2024-02-29 [email protected] Roll Flutter Engine from 7b3ef43fa7e6 to 1f24eaa4979d (2 revisions) (flutter/flutter#144405) 2024-02-29 [email protected] Roll Flutter Engine from 7dd404724c50 to 7b3ef43fa7e6 (1 revision) (flutter/flutter#144399) 2024-02-29 [email protected] Roll Flutter Engine from 8179b0ed778e to 7dd404724c50 (3 revisions) (flutter/flutter#144395) 2024-02-29 [email protected] Roll Packages from 353086c to 6d02f03 (14 revisions) (flutter/flutter#144393) 2024-02-29 [email protected] Roll Flutter Engine from d068d980f952 to 8179b0ed778e (1 revision) (flutter/flutter#144378) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...

LongCatIsLooong · 2024-03-12T20:55:34Z

@gspencergoog I'm considering reverting this as I don't think I need this anymore (inactive routes don't seem to prevent child widgets from gaining focus so I need to find a different solution for the scribble problem). I'd like to remove the feature so the code is a bit simpler to read. Does that sound reasonable to you?

gspencergoog · 2024-03-13T01:49:55Z

I'm considering reverting this as I don't think I need this anymore (inactive routes don't seem to prevent child widgets from gaining focus so I need to find a different solution for the scribble problem). I'd like to remove the feature so the code is a bit simpler to read. Does that sound reasonable to you?

@LongCatIsLooong Sure, we can always re-add something like this if we find it useful.

LongCatIsLooong · 2024-03-13T03:17:29Z

reason for revert: no longer needed.

auto-submit · 2024-03-13T03:17:37Z

Time to revert pull request flutter/flutter/144280 has elapsed.
You need to open the revert manually and process as a regular pull request.

…e the feature is no longer needed This reverts commit 726e5d2.

…eature is no longer needed (#145102) This reverts commit 726e5d2. *Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.* *List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.* *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

LongCatIsLooong added 14 commits February 25, 2024 20:33

Add focusability listener

410b4f5

Cache FocusNode.enclosingScope, clean up descendantsAreFocusable

a76c916

wip

93ed3a0

Merge branch 'focus-cleanup' into focusability-listener

c95adb9

clean up

67d309d

tests

6a7937c

fix

5929a02

new interface

d44b8e1

Merge remote-tracking branch 'upstream/main' into focusability-listener

a18d91e

value listener

4b79c0a

wip

e33a12a

fix tests

9ca3566

documentation

486b753

documentation

064d24e

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: focus Focus traversal, gaining or losing focus labels Feb 28, 2024

LongCatIsLooong added 2 commits February 28, 2024 14:56

fix tests

c2c1c17

documentation

7c1de5e

LongCatIsLooong requested review from goderbauer and gspencergoog February 29, 2024 02:46

gspencergoog approved these changes Feb 29, 2024

View reviewed changes

LongCatIsLooong added 2 commits February 29, 2024 10:47

Merge remote-tracking branch 'upstream/main' into focusability-listener

a7b9f3a

Merge remote-tracking branch 'upstream/main' into focusability-listener

07ce4c0

LongCatIsLooong force-pushed the focusability-listener branch from 7c28056 to 07ce4c0 Compare February 29, 2024 18:48

LongCatIsLooong added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 29, 2024

auto-submit bot merged commit 726e5d2 into flutter:master Feb 29, 2024

LongCatIsLooong deleted the focusability-listener branch February 29, 2024 20:42

engine-flutter-autoroll mentioned this pull request Mar 1, 2024

Roll Flutter from e92bca3ff5d2 to ba719bc588ed (37 revisions) flutter/packages#6235

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2024

726e5d2 Add FocusNode.focusabilityListenable (flutter/flutter#144280)

2f0fc2a

LongCatIsLooong added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 13, 2024

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 13, 2024

LongCatIsLooong added a commit to LongCatIsLooong/flutter that referenced this pull request Mar 13, 2024

Revert "Add FocusNode.focusabilityListenable (flutter#144280)" sinc…

48ec306

…e the feature is no longer needed This reverts commit 726e5d2.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

726e5d2 Add FocusNode.focusabilityListenable (flutter/flutter#144280)

1e835d2

LongCatIsLooong mentioned this pull request Aug 15, 2024

TextFormField may throw Exception when deleting text from field with CJK keyboard in a route pushed using CupertinoPageRoute on Android #153003

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `FocusNode.focusabilityListenable`#144280

Add `FocusNode.focusabilityListenable`#144280
auto-submit[bot] merged 18 commits intoflutter:masterfrom
LongCatIsLooong:focusability-listener

LongCatIsLooong commented Feb 28, 2024 •

edited

Loading

Uh oh!

gspencergoog left a comment

Uh oh!

LongCatIsLooong commented Mar 12, 2024

Uh oh!

gspencergoog commented Mar 13, 2024 •

edited

Loading

Uh oh!

LongCatIsLooong commented Mar 13, 2024

Uh oh!

auto-submit bot commented Mar 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LongCatIsLooong commented Feb 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong commented Mar 12, 2024

Uh oh!

gspencergoog commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LongCatIsLooong commented Mar 13, 2024

Uh oh!

auto-submit bot commented Mar 13, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LongCatIsLooong commented Feb 28, 2024 •

edited

Loading

gspencergoog commented Mar 13, 2024 •

edited

Loading