Restorable CupertinoTextFormFieldRow#144541
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Mar 5, 2024
Merged
Conversation
github-actions
bot
added
a: text input
bleroux
force-pushed
the
restorable_CupertinoTextFormFieldRow
branch
from
91e8897 to
b68797d
Compare
justinmc
approved these changes
Mar 4, 2024
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
LGTM with nits 👍 . Thanks for adding restoration support here. We must have missed it earlier when state restoration was added to the framework.
Contributor
There was a problem hiding this comment.
Good call making this non-nullable now!
Comment on lines
294
to
295
Contributor
There was a problem hiding this comment.
Nit:
// This makes sure to...
I think this is more clear that the comment is just an explanation. When I first read it, I thought it might be a command to callers to make sure that they also update the value.
Contributor
There was a problem hiding this comment.
Nit: I think it's kind of hard to read like this, because TestWidget seems so generic here. Maybe just rename it to "RestorableCupertinoTextFormFieldRow" and "useExternal" to "useExternalController"? And/or move the widgets other than the CupertinoTextFormFieldRow out?
I don't know, maybe that makes it more confusing haha. Up to you.
Contributor
Author
There was a problem hiding this comment.
I copy/pasted those names from other form field restoration tests. I was not pleased with the TestWidget but it is used on several existing tests and I did not have a good name to replace it.
I updated the PR with useExternalController (great suggestion) and renamed TestWidget to RestorableTestWidget. I tried RestorableCupertinoTextFormFieldRow but it is not very readable and it might be confusing because one can think it is an existing widget. Keeping 'Test' in the widget class name makes it clear it is test only.
bleroux
force-pushed
the
restorable_CupertinoTextFormFieldRow
branch
from
b68797d to
fe048ef
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 5, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Mar 5, 2024
flutter/flutter@65cd84b...3b5a2ec 2024-03-05 [email protected] Roll Flutter Engine from 17a4b66e0729 to 8916bb32b7b8 (1 revision) (flutter/flutter#144615) 2024-03-05 [email protected] Roll Flutter Engine from d514a302cdff to 17a4b66e0729 (8 revisions) (flutter/flutter#144607) 2024-03-05 [email protected] Do not shorten native assets framework names (flutter/flutter#144568) 2024-03-05 [email protected] Restorable CupertinoTextFormFieldRow (flutter/flutter#144541) 2024-03-05 [email protected] Updated the TextButton image button example artwork (flutter/flutter#144583) 2024-03-05 [email protected] Roll Flutter Engine from 728aa4ef05d4 to d514a302cdff (2 revisions) (flutter/flutter#144581) 2024-03-05 [email protected] Roll Flutter Engine from 62cf93be60b2 to 728aa4ef05d4 (3 revisions) (flutter/flutter#144578) 2024-03-05 [email protected] Disable super flakey impeller test. (flutter/flutter#144573) 2024-03-04 [email protected] Roll Flutter Engine from 40018811ec0e to 62cf93be60b2 (1 revision) (flutter/flutter#144572) 2024-03-04 [email protected] Roll Flutter Engine from 0d8588b1de7a to 40018811ec0e (6 revisions) (flutter/flutter#144570) 2024-03-04 [email protected] Print warning and exit when iOS device is unpaired (flutter/flutter#144551) 2024-03-04 [email protected] Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) (flutter/flutter#144558) 2024-03-04 [email protected] Remove unnecessary (and the only) `RenderObject.markParentNeedsLayout` override (flutter/flutter#144466) 2024-03-04 [email protected] Fix text color for default CupertinoContextMenuAction (flutter/flutter#144542) 2024-03-04 [email protected] Add missing parameter to `TableBorder.symmetric`, and improve class constructors (flutter/flutter#144279) 2024-03-04 [email protected] Fix build mode not propagated in android native asset build (flutter/flutter#144550) 2024-03-04 [email protected] Roll Packages from a9c68b8 to 0625827 (3 revisions) (flutter/flutter#144556) 2024-03-04 [email protected] Roll Flutter Engine from afd2d9f9421d to a31209171949 (1 revision) (flutter/flutter#144554) 2024-03-04 [email protected] Doc fix for `DropdownButtonFormField.value` (flutter/flutter#144427) 2024-03-04 [email protected] Fix Small Typo in Skia_Client Doc Comment (flutter/flutter#144490) 2024-03-04 [email protected] Roll Flutter Engine from 2338a557e018 to afd2d9f9421d (1 revision) (flutter/flutter#144549) 2024-03-04 [email protected] [Windows] Update keyboard modifiers link (flutter/flutter#144426) 2024-03-04 [email protected] Roll Flutter Engine from 9cbca80e2196 to 2338a557e018 (2 revisions) (flutter/flutter#144545) 2024-03-04 [email protected] Roll Flutter Engine from c52b3033eca6 to 9cbca80e2196 (1 revision) (flutter/flutter#144523) 2024-03-04 [email protected] Roll Flutter Engine from 024ea680ceed to c52b3033eca6 (1 revision) (flutter/flutter#144522) 2024-03-03 [email protected] Roll Flutter Engine from 2706c732b22a to 024ea680ceed (1 revision) (flutter/flutter#144519) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu
pushed a commit
to LouiseHsu/packages
that referenced
this pull request
Mar 7, 2024
flutter/flutter@65cd84b...3b5a2ec 2024-03-05 [email protected] Roll Flutter Engine from 17a4b66e0729 to 8916bb32b7b8 (1 revision) (flutter/flutter#144615) 2024-03-05 [email protected] Roll Flutter Engine from d514a302cdff to 17a4b66e0729 (8 revisions) (flutter/flutter#144607) 2024-03-05 [email protected] Do not shorten native assets framework names (flutter/flutter#144568) 2024-03-05 [email protected] Restorable CupertinoTextFormFieldRow (flutter/flutter#144541) 2024-03-05 [email protected] Updated the TextButton image button example artwork (flutter/flutter#144583) 2024-03-05 [email protected] Roll Flutter Engine from 728aa4ef05d4 to d514a302cdff (2 revisions) (flutter/flutter#144581) 2024-03-05 [email protected] Roll Flutter Engine from 62cf93be60b2 to 728aa4ef05d4 (3 revisions) (flutter/flutter#144578) 2024-03-05 [email protected] Disable super flakey impeller test. (flutter/flutter#144573) 2024-03-04 [email protected] Roll Flutter Engine from 40018811ec0e to 62cf93be60b2 (1 revision) (flutter/flutter#144572) 2024-03-04 [email protected] Roll Flutter Engine from 0d8588b1de7a to 40018811ec0e (6 revisions) (flutter/flutter#144570) 2024-03-04 [email protected] Print warning and exit when iOS device is unpaired (flutter/flutter#144551) 2024-03-04 [email protected] Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) (flutter/flutter#144558) 2024-03-04 [email protected] Remove unnecessary (and the only) `RenderObject.markParentNeedsLayout` override (flutter/flutter#144466) 2024-03-04 [email protected] Fix text color for default CupertinoContextMenuAction (flutter/flutter#144542) 2024-03-04 [email protected] Add missing parameter to `TableBorder.symmetric`, and improve class constructors (flutter/flutter#144279) 2024-03-04 [email protected] Fix build mode not propagated in android native asset build (flutter/flutter#144550) 2024-03-04 [email protected] Roll Packages from a9c68b8 to 0625827 (3 revisions) (flutter/flutter#144556) 2024-03-04 [email protected] Roll Flutter Engine from afd2d9f9421d to a31209171949 (1 revision) (flutter/flutter#144554) 2024-03-04 [email protected] Doc fix for `DropdownButtonFormField.value` (flutter/flutter#144427) 2024-03-04 [email protected] Fix Small Typo in Skia_Client Doc Comment (flutter/flutter#144490) 2024-03-04 [email protected] Roll Flutter Engine from 2338a557e018 to afd2d9f9421d (1 revision) (flutter/flutter#144549) 2024-03-04 [email protected] [Windows] Update keyboard modifiers link (flutter/flutter#144426) 2024-03-04 [email protected] Roll Flutter Engine from 9cbca80e2196 to 2338a557e018 (2 revisions) (flutter/flutter#144545) 2024-03-04 [email protected] Roll Flutter Engine from c52b3033eca6 to 9cbca80e2196 (1 revision) (flutter/flutter#144523) 2024-03-04 [email protected] Roll Flutter Engine from 024ea680ceed to c52b3033eca6 (1 revision) (flutter/flutter#144522) 2024-03-03 [email protected] Roll Flutter Engine from 2706c732b22a to 024ea680ceed (1 revision) (flutter/flutter#144519) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
CupertinoTextFormFieldRowrestorable.The implementation is based on #78835 which made
FormFieldandTextFormFieldrestorable.Related Issue
Fixes #144504.
Tests
Adds 4 tests.