Reverts "Platform view devicelab ad banner scroll list real ads (#144745)"#145189
Merged
auto-submit[bot] merged 1 commit intomasterfrom Mar 15, 2024
Merged
Conversation
…)" This reverts commit be78542.
auto-submit
bot
added
the
revert of
hellohuanlin
approved these changes
Mar 15, 2024
fluttergithubbot
approved these changes
Mar 15, 2024
auto-submit
bot
deleted the
revert_be78542d6c2a7ff96f2f277fd9fa7a966c15a152
branch
Contributor
|
The issue seems to be related to Android. Not sure if this is related to the fact that I added admob dependency. May need some help from android folks (cc @gmackall) ... |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
Member
|
Looks like a lockfile issue to me, let me try running building that benchmark app with your PR + lockfiles re-generated |
Member
|
7be30f3 fixes for me (I didn't try exactly what the test was doing but apk build fails before and succeeds after). |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
Contributor
May i know what command did you run? Thansk! |
Member
It's the partial output of running the |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: #144745
Initiated by: gspencergoog
Reason for reverting: appears to have broken the build.
Original PR Author: hellohuanlin
Reviewed By: {jmagman, jonahwilliams}
This change reverts the following previous change:
This benchmark is to measure the platform view performance improvement.
It is similar to https://github.com/lucalooz/flutter_ads_list_perf
There's still a pending issue #144339
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Fixes #143534
Fixes #143257
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.