Skip to content

Reland: "Platform view devicelab ad banner scroll list real ads"#145224

Merged
auto-submit[bot] merged 19 commits intoflutter:masterfrom
hellohuanlin:platform_view_devicelab_ad_banner_scroll_list_real_ads_reland
Mar 15, 2024
Merged

Reland: "Platform view devicelab ad banner scroll list real ads"#145224
auto-submit[bot] merged 19 commits intoflutter:masterfrom
hellohuanlin:platform_view_devicelab_ad_banner_scroll_list_real_ads_reland

Conversation

@hellohuanlin
Copy link
Contributor

@hellohuanlin hellohuanlin commented Mar 15, 2024 •
edited
Loading

Reland #144745, which got reverted due to Android lockfile. Fixed by dart dev/tools/bin/generate_gradle_lockfiles.dart

List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.

Fixes #143534
Fixes #143257

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the f: scrolling Viewports, list views, slivers, etc. label Mar 15, 2024
hellohuanlin
hellohuanlin commented Mar 15, 2024
View reviewed changes
dev/benchmarks/platform_views_layout/android/project-google_mobile_ads.lockfile
@@ -0,0 +1,126 @@
# This is a Gradle generated file for dependency locking.
Copy link
Contributor Author

@hellohuanlin hellohuanlin Mar 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmackall I'd like an extra eye on the android part. These 2 lockfiles (this and the webview below) are generated because admob dep is added.

Copy link
Member

@gmackall gmackall Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it was generated by the script then it LGTM. I tried building with these 2 files as well and didn't hit any issues, so they should be safe to include

jmagman
jmagman approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-Android parts LGTM

gmackall
gmackall approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@gmackall gmackall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lockfiles lgtm

@hellohuanlin hellohuanlin added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 15, 2024
@auto-submit auto-submit bot merged commit da4d0e4 into flutter:master Mar 15, 2024
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Mar 15, 2024

Woot! 🎊

@hellohuanlin hellohuanlin added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 15, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 15, 2024

A reason for requesting a revert of flutter/flutter/145224 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 15, 2024
@hellohuanlin
Copy link
Contributor Author

hellohuanlin commented Mar 15, 2024

Reason for revert:breaks the tree

@hellohuanlin hellohuanlin added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 15, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 15, 2024

A reason for requesting a revert of flutter/flutter/145224 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 15, 2024
@hellohuanlin
Copy link
Contributor Author

hellohuanlin commented Mar 15, 2024

Reason for revert: breaks the tree

@hellohuanlin hellohuanlin added the revert Autorevert PR (with "Reason for revert:" comment) label Mar 15, 2024
auto-submit bot pushed a commit that referenced this pull request Mar 15, 2024
Revert "Reland: "Platform view devicelab ad banner scroll list real a…
91cdb88 
…ds" (#145224)"

This reverts commit da4d0e4.
@auto-submit auto-submit bot mentioned this pull request Mar 15, 2024
Merged
9 tasks
@auto-submit auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Mar 15, 2024
auto-submit bot added a commit that referenced this pull request Mar 15, 2024
@auto-submit
Reverts "Reland: "Platform view devicelab ad banner scroll list real …
ca2d486 
…ads" (#145224)" (#145228)

Reverts: #145224
Initiated by: hellohuanlin
Reason for reverting: breaks the tree
Original PR Author: hellohuanlin

Reviewed By: {gmackall, jmagman}

This change reverts the following previous change:
Reland #144745, which got reverted due to Android lockfile. Fixed by `dart dev/tools/bin/generate_gradle_lockfiles.dart`

*List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.*

Fixes #143534
Fixes #143257

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
@jmagman jmagman mentioned this pull request Mar 15, 2024
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
da4d0e4 Reland: "Platform view devicelab ad banner scroll list real a…
f5e655c 
…ds" (flutter/flutter#145224)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 16, 2024
@engine-flutter-autoroll
da4d0e4 Reland: "Platform view devicelab ad banner scroll list real a…
a184986 
…ds" (flutter/flutter#145224)
@hellohuanlin hellohuanlin mentioned this pull request Apr 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024
@engine-flutter-autoroll
da4d0e4 Reland: "Platform view devicelab ad banner scroll list real a…
ab6b027 
…ds" (flutter/flutter#145224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

@gmackall gmackall gmackall approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc.

Projects

None yet

Milestone

No milestone

4 participants

@hellohuanlin @jonahwilliams @jmagman @gmackall