`flutter test --wasm` support by eyebrowsoffire · Pull Request #145347 · flutter/flutter

eyebrowsoffire · 2024-03-18T19:14:33Z

Adds support for flutter test --wasm.
- The test compilation flow is a bit different now, so that it supports compilers other than DDC. Specifically, when we run a set of unit tests, we generate a "switchboard" main function that imports each unit test and runs the main function for a specific one based off of a value set by the JS bootstrapping code. This way, there is one compile step and the same compile output is invoked for each unit test file.
Also, removes all references to dart:html from flutter/flutter.
Adds CI steps for running the framework unit tests with dart2wasm+skwasm
- These steps are marked as bringup: true, so we don't know what kind of failures they will result in. Any failures they have will not block the tree at all yet while we're still in bringup: true. Once this PR is merged, I plan on looking at any failures and either fixing them or disabling them so we can get these CI steps running on presubmit.

This fixes #126692

yjbanov · 2024-03-21T00:05:47Z

packages/flutter/lib/src/foundation/_bitfield_web.dart

 import 'bitfield.dart' as bitfield;

-/// The dart:html implementation of [bitfield.kMaxUnsignedSMI].
+/// The web implementation of [bitfield.kMaxUnsignedSMI].


Should this be "JS implementation"? I imagine Wasm can support the regular VM code.

As of right now, wasm uses this implementation. You can see the conditional import is gated on dart.library.js_util which evaluates to true on the dart2wasm platform:

flutter/packages/flutter/lib/src/foundation/bitfield.dart

Line 6 in 5545c95

if (dart.library.js_util) '_bitfield_web.dart' as bitfield;

You're right that we could probably switch over to using the VM version for wasm, since we don't have floating point precision issues with int on dart2wasm. I don't want to add yet another change that could potentially add risk to this big PR, so I'm filing that as a follow-on issue and we can look into that separately. #145540

yjbanov · 2024-03-21T00:07:01Z

packages/flutter_driver/lib/src/extension/_extension_web.dart

+@JS('window')
+external JSObject get _window;
+
+/// The web implementation of [registerWebServiceExtension].


Is there a non-web implementation of the registerWebServiceExtension? :)

Technically yes, see packages/flutter_driver/lib/src/extension/_extension_io.dart. It's a no-op, but it's an implementation.

yjbanov · 2024-03-21T00:10:37Z

packages/flutter_test/lib/src/_goldens_io.dart


 /// An unsupported [WebGoldenComparator] that exists for API compatibility.
 class DefaultWebGoldenComparator extends WebGoldenComparator {
+  /// This is provided to prevent warnings from the analyzer


nit: end the doc with a period

yjbanov · 2024-03-21T00:15:14Z

packages/flutter_tools/lib/src/test/flutter_web_platform.dart

+        if (needsCrossOriginIsolated)
+          ...<String, String>{
+            'Cross-Origin-Opener-Policy': 'same-origin',
+            'Cross-Origin-Embedder-Policy': 'require-corp',


What if we always used these, in all modes?

I considered this. However, that would be a breaking change for anyone who writes a test that relies on being in a non-crossOriginIsolated context. It seems like it would be weird to do a cross-origin fetch in a unit test, but I could see it in an integration test possibly. I tried to make this change as non-breaking as possible. If we want to re-evaluate that decision later and say "all flutter test runs should run in a crossOriginIsolated context and if that breaks your test you should change your test" I think I'd be okay with that, but I'd rather not overload that behavior change with this PR.

yjbanov · 2024-03-21T00:28:55Z

packages/flutter_tools/lib/src/test/web_test_compiler.dart

+      compilationArgs,
+    );
+
+    return WebMemoryFS();


Why are we not populating memory-fs in the wasm case?

WebMemoryFS is specific to DDC's outputs. To be honest, I'm not entirely sure why we do this at all in the DDC case. In the dart2wasm case, all the compiler outputs are just put into the output directory and they are served directly from there. I didn't want to mess too much with the DDC compilation process in this PR though.

Perhaps @jonahwilliams has some insight here

writing thousands of 10-100 line files is incredibly slow. So slow that it can easily add an order of magnitude onto the compilation time of the ddc applications. If you're producing a single output file then its irrelevant and I wouldnt use the memory fs

goderbauer · 2024-03-21T18:20:01Z

packages/flutter_test/lib/src/_test_selector_web.dart

+  /// This hard-codes the device pixel ratio to 3.0 and a 2400 x 1800 window
+  /// size for the purposes of testing.
+  ui_web.debugOverrideDevicePixelRatio(3.0);
+  ui.window.debugPhysicalSizeOverride = const ui.Size(2400, 1800);


fly-by comment: The window singleton is deprecated and we've cleaned up the code base to no longer depend on this singleton. Can you please not introduce new references to it?

This is not a new reference, it is copied over from the previous generated test bootstrap file. I'm happy to switch over to a different API though, as long as it is guaranteed to have the exact same behavior. What should I invoke instead?

I did not find an equivalent API that is accessible from this package. We can look into figuring out a solution for this later. Especially since this isn't really a new reference to this API, I don't want to block this change on it.

I've filed #145558 to keep track of this.

goderbauer · 2024-03-21T18:23:15Z

packages/flutter_test/lib/src/web.dart

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// ignore_for_file: public_member_api_docs


https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#comment-all-ignores

Also, will what is defined in here show up on api.flutter.dev? It should have docs then.

This is basically the same situation as

flutter/packages/flutter/lib/src/web.dart

Line 5 in 18340ea

// This code is copied from `package:web` which still needs its own

. I'll go ahead and add the same comment to the ignore.

These should not show up on api.flutter.dev. If they do, there's probably a bug somewhere.

flutter/flutter@18340ea...14774b9 2024-03-22 [email protected] Roll Flutter Engine from eba6e31498b8 to 09dadce76828 (1 revision) (flutter/flutter#145603) 2024-03-22 [email protected] Roll Flutter Engine from f9a34ae0b14f to eba6e31498b8 (1 revision) (flutter/flutter#145598) 2024-03-22 [email protected] Intensive `if` chain refactoring (flutter/flutter#145194) 2024-03-22 [email protected] Adds numpad navigation shortcuts for Linux (flutter/flutter#145464) 2024-03-22 [email protected] Roll Flutter Engine from 5a12de1beab7 to f9a34ae0b14f (1 revision) (flutter/flutter#145581) 2024-03-22 [email protected] Roll Flutter Engine from e2f324beac3b to 5a12de1beab7 (1 revision) (flutter/flutter#145578) 2024-03-22 [email protected] Replace `RenderBox.compute*` with `RenderBox.get*` and add `@visibleForOverriding` (flutter/flutter#145503) 2024-03-22 [email protected] Add some cross references in the docs, move an example to a dartpad example (flutter/flutter#145571) 2024-03-22 [email protected] Fix `BorderSide.none` requiring explicit transparent color for `UnderlineInputBorder` (flutter/flutter#145329) 2024-03-22 [email protected] Roll Flutter Engine from a46a7b273a5b to e2f324beac3b (1 revision) (flutter/flutter#145576) 2024-03-21 [email protected] Fix nullability of getFullHeightForCaret (flutter/flutter#145554) 2024-03-21 [email protected] Add a `--no-gradle-generation` mode to the `generate_gradle_lockfiles.dart` script (flutter/flutter#145568) 2024-03-21 [email protected] Roll Flutter Engine from 1b842ae58b3d to a46a7b273a5b (2 revisions) (flutter/flutter#145569) 2024-03-21 [email protected] Fixed race condition in PollingDeviceDiscovery. (flutter/flutter#145506) 2024-03-21 [email protected] Roll Flutter Engine from a2ed373fa70f to 1b842ae58b3d (1 revision) (flutter/flutter#145565) 2024-03-21 [email protected] Clarify AutomaticKeepAliveClientMixin semantics in build method (flutter/flutter#145297) 2024-03-21 [email protected] Eliminate more window singleton usages (flutter/flutter#145560) 2024-03-21 [email protected] `flutter test --wasm` support (flutter/flutter#145347) 2024-03-21 [email protected] Roll Flutter Engine from eb262e9c34db to a2ed373fa70f (2 revisions) (flutter/flutter#145556) 2024-03-21 [email protected] Roll Flutter Engine from bad4a30e1c75 to eb262e9c34db (1 revision) (flutter/flutter#145555) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

eyebrowsoffire added 7 commits March 14, 2024 13:15

Some changes.

a249eca

More fixes.

538ba54

More progress.

4bf7b55

Test is actually starting to run, but testWidgets crashes.

77b1367

Tests working.

23fdd64

Remove references to dart:html.

d0afced

Merge branch 'master' into flutter_test_wasm

3e1c14e

eyebrowsoffire added 13 commits March 18, 2024 12:20

Remove unused field.

d6a5e25

Fix generated import statement.

bdf4f08

Fix bootstrap test

584e7f2

Merge branch 'master' into flutter_test_wasm

e831a2c

Support skwasm.

a1705d0

Fix web plaform test.

05b8c39

Add skwasm test CI steps.

0cceef0

Fix up test bot.

c1bae47

Update TESTOWNERS

9986190

Fix analyzer errors.

8a2fe54

Remove debug prints.

fb86702

Fix forbidden imports.

cb3d066

Update packages.

b8d5504

github-actions bot added a: internationalization Supporting other languages or locales. (aka i18n) platform-web Web applications specifically labels Mar 18, 2024

eyebrowsoffire added 7 commits March 19, 2024 17:39

Fix web extension test again.

d924b5f

Fix other web extension test.

0196e55

Migrate away from dart:js

4269032

More migrations off of dart:js.

935592f

Don't try to use convert async functions via toJS.

4661a35

Fix stack trace integration test.

7e47757

Fix web extension test again.

92add79

eyebrowsoffire marked this pull request as ready for review March 20, 2024 20:57

eyebrowsoffire requested a review from ditman March 20, 2024 21:28

yjbanov approved these changes Mar 21, 2024

View reviewed changes

eyebrowsoffire added 2 commits March 21, 2024 09:41

Fix comment.

fbd7117

Merge branch 'master' into flutter_test_wasm

3f08190

goderbauer reviewed Mar 21, 2024

View reviewed changes

Add comment for ignore in web bindings.

5d6b22d

eyebrowsoffire added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2024

auto-submit bot merged commit 31209d0 into flutter:master Mar 21, 2024

engine-flutter-autoroll mentioned this pull request Mar 22, 2024

Roll Flutter from 18340ea16cee to 7fb35db62fa5 (18 revisions) flutter/packages#6374

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2024

31209d0 flutter test --wasm support (flutter/flutter#145347)

757598b

engine-flutter-autoroll mentioned this pull request Mar 22, 2024

Roll Flutter from 18340ea16cee to 7ad647ab9296 (19 revisions) flutter/packages#6375

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2024

31209d0 flutter test --wasm support (flutter/flutter#145347)

4d836ba

engine-flutter-autoroll mentioned this pull request Mar 22, 2024

Roll Flutter from 18340ea16cee to 14774b95c250 (20 revisions) flutter/packages#6376

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 22, 2024

31209d0 flutter test --wasm support (flutter/flutter#145347)

d318cd0

bleroux added a commit to NevercodeHQ/flutter that referenced this pull request Mar 28, 2024

Update required after flutter#145347

3c3ce41

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 14, 2024

31209d0 flutter test --wasm support (flutter/flutter#145347)

fd4cedc

eyebrowsoffire deleted the flutter_test_wasm branch December 12, 2025 21:55

Conversation

eyebrowsoffire commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eyebrowsoffire commented Mar 18, 2024 •

edited

Loading