Skip to content

Roll engine (with updates for new Map APIs)#14541

Closed
jason-simmons wants to merge 1 commit intoflutter:masterfrom
jason-simmons:roll_engine_0207
Closed

Roll engine (with updates for new Map APIs)#14541
jason-simmons wants to merge 1 commit intoflutter:masterfrom
jason-simmons:roll_engine_0207

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Feb 8, 2018

No description provided.

@jason-simmons
Copy link
Member Author

jason-simmons commented Feb 8, 2018

@aam

@jason-simmons
Copy link
Member Author

jason-simmons commented Feb 8, 2018

This is failing the flutter analyze --flutter-repo --watch --benchmark test because the continuous analysis server isn't picking up the new methods in the Map class (added in dart-lang/sdk@6f78471)

Should AnalyzeContinuously be using the version of the Dart SDK uploaded as part of the Flutter engine build? (located in bin/cache/artifacts/engine/linux-x64/dart-sdk)
That SDK's libraries should match the libraries available within the Flutter runtime.

@danrubel

@Hixie
Copy link
Contributor

Hixie commented Feb 8, 2018

We should roll the SDK we use for the tool as well.
The two SDKs are intentionally not in sync so that we don't come to depend on them being exactly in sync, but it's ok for them to be more in sync than they are right now. :-)

@jason-simmons
Copy link
Member Author

jason-simmons commented Feb 8, 2018

afaik Dart has not yet published a release of the SDK that includes these APIs

@Hixie
Copy link
Contributor

Hixie commented Feb 8, 2018

Isn't every commit "released"?

@aam
Copy link
Member

aam commented Feb 8, 2018

You can put for example hash/6f78471687bb099a818439add9324607e70dacfd into bin/internal/dart-sdk.version instead of 2.0.0-dev.19.0, which would pull that hash revision of dart sdk for flutter tools use.
I guess info findings can be ignored:

╰─➤  bin/flutter analyze --flutter-repo --watch --benchmark
Analyzing Flutter repository...                      25,555ms

   info • Prefer const with constant constructors. • packages/flutter/test/material/about_test.dart:58:9
   info • Prefer const with constant constructors. • packages/flutter/test/material/about_test.dart:81:9
   info • Prefer const with constant constructors. • packages/flutter/test/material/about_test.dart:87:9
   info • Prefer const with constant constructors. • packages/flutter/test/painting/decoration_test.dart:339:28
   info • Prefer const with constant constructors. • packages/flutter/test/painting/decoration_test.dart:340:28
   info • Prefer const with constant constructors. • packages/flutter/test/painting/decoration_test.dart:341:28
   info • Prefer const with constant constructors. • packages/flutter/test/painting/decoration_test.dart:342:28
   info • Prefer const with constant constructors. • packages/flutter/test/painting/shape_decoration_test.dart:20:31
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/list_wheel_scroll_view_test.dart:17:9
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/list_wheel_scroll_view_test.dart:44:18
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/list_wheel_scroll_view_test.dart:101:18
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_appbar_floating_pinned_test.dart:22:27
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_appbar_floating_test.dart:207:25
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_appbar_pinned_test.dart:260:25
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_appbar_scrolling_test.dart:86:25
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_block_test.dart:19:23
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_block_test.dart:155:25
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_block_test.dart:266:25
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_block_test.dart:284:25
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_block_test.dart:302:25
   info • Prefer const with constant constructors. • packages/flutter/test/widgets/slivers_block_test.dart:320:25
21 issues found • analyzed 1399 files, 25.57 seconds
Analysis benchmark written to analysis_benchmark.json ({time: 25.568, issues: 21, missingDartDocs: -1}).

@aam
Copy link
Member

aam commented Feb 8, 2018

You can put for example hash/6f78471687bb099a818439add9324607e70dacfd

Except using hash/<tag> throws pubs 'dev'-based version constraints off because versions coming from direct hash have 'edge'-prefix.

@whesse, do you know when next 'dev' cut(that will include 6f78471687bb099a818439add9324607e70dacfd) will happen?

@whesse
Copy link
Contributor

whesse commented Feb 8, 2018 via email

@whesse
Copy link
Contributor

whesse commented Feb 8, 2018 via email

@Hixie
Copy link
Contributor

Hixie commented Feb 8, 2018

I guess info findings can be ignored:

No, please fix those. :-)

@aam aam mentioned this pull request Feb 8, 2018
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jason-simmons @Hixie @aam @whesse @googlebot