Refactor add_to_app_life_cycle_tests#145546
Conversation
| workingDirectory: addToAppDir, | ||
| ); | ||
| } else { | ||
| printProgress('${yellow}Skipped on this platform (only iOS has add-to-add lifecycle tests at this time).$reset'); |
There was a problem hiding this comment.
Although, how do we even reach this?
There was a problem hiding this comment.
Does it need to be reached in a different way than the current SHARD=add_to_app_life_cycle_tests bin/cache/dart-sdk/bin/dart dev/bots/test.dart? My understanding was that the current commands to trigger this specific suite of tests will still be maintained since the "SHARD" parameter is being handled in the same way in test.dart
There was a problem hiding this comment.
do we have a non-ios .ci.yaml target configured that calls that? and does it do any work?
There was a problem hiding this comment.
I looked through all recipe: flutter/flutter_drone .ci.yaml targets and don't see any non-ios targets configured with add_to_app_life_cycle_tests as a parameter or without a shard at all
There was a problem hiding this comment.
Can we just throw here then?
There was a problem hiding this comment.
Yes that makes sense to me
There was a problem hiding this comment.
Added an exception thrown there
sealesj
added
the
autosubmit
2 participants
Refactor add_to_app_life_cycle_tests in order to reduce testing logic in test.dart, create a suite_runners directory and allow for later implementing package:test onto add_to_app_life_cycle_tests
Part of #145482
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.