regenerate gradle lockfiles & roll pub packages#145564
regenerate gradle lockfiles & roll pub packages#145564christopherfujino wants to merge 3 commits intoflutter:masterfrom
Conversation
christopherfujino
changed the title
github-actions
bot
added
a: tests
This PR was generated by `flutter update-packages --force-upgrade`.
christopherfujino
force-pushed
the
roll-pub-packages-and-fix-regenerate-gradle-lockfiles
branch
from
8945eeb to
3bb813f
Compare
| /// Applications need to include `StockStrings.delegate()` in their app's | ||
| /// localizationDelegates list, and the locales they support in the app's | ||
| /// supportedLocales list. For example: | ||
| /// `localizationDelegates` list, and the locales they support in the app's |
There was a problem hiding this comment.
@gmackall Does the regenerate gradle lockfiles script change dartdocs?
There was a problem hiding this comment.
Hmm, these diffs also broke analysis:
Analyzing flutter...
info • The expression has no effect and can be removed • dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings.dart:69:83 • noop_primitive_operations
info • Convert 'locale' to a super parameter • dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_en.dart:12:3 • use_super_parameters
info • Convert 'locale' to a super parameter • dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings_es.dart:12:3 • use_super_parameters
There was a problem hiding this comment.
This happened before: https://github.com/flutter/flutter/pull/137190/files#r1371888460
It's unclear to me how that script would touch dart files, though...
There was a problem hiding this comment.
Oh, we're calling flutter pub get, which WILL do localization code generation
There was a problem hiding this comment.
I guess I should fix analysis and check it in
|
The I think the answer isn't to change the test but to add a flag to the script to allow running it in a mode where we don't re-generate the gradle files themselves (I don't see a reason why the pub roller bot should need to re generate the gradle files themselves for each roll). I'll put up a pr to add that mode |
….dart` script (#145568) The script currently overwrites existing `settings.gradle`, `build.gradle`, and `gradle-wrapper.properties` files in the directories it processes. This mode makes it not do that, and just generate the lockfiles themselves. Related to #145564 (comment)
github-actions
bot
removed
a: tests
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
Looks like the gradle_deprecated_settings test is still failing. I think the issue here is that generate gradle files -> generate lockfiles -> revert grade file generation is not exactly the same as just generate lockfiles.
I was able to reproduce the error with those steps, but it built successfully if I instead started on a new branch and just did flutter update-packages --force-upgrade followed by running the lockfile generation script with the --no-gradle-generation flag
Thanks |
|
Superceded by: #145727 |
Example failing devicelab build https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/2980/overview Fixes #145561 Supercedes #145564
3 participants
Example failing devicelab build https://ci.chromium.org/ui/p/flutter/builders/prod/Linux_pixel_7pro%20platform_views_scroll_perf__timeline_summary/2980/overview
Fixes #145561