Add tests for theme_extension.1.dart API example. by ksokolovskyi · Pull Request #145819 · flutter/flutter

ksokolovskyi · 2024-03-27T10:12:35Z

This PR contributes to #130459

Description

Adds tests for examples/api/lib/material/theme/theme_extension.1.dart

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

ksokolovskyi · 2024-03-29T18:18:48Z

@Renzo-Olivares, could you please take a look at this PR?

examples/api/test/material/theme/theme_extension.1_test.dart

Renzo-Olivares

LGTM, thanks for adding this test!

ksokolovskyi · 2024-03-29T20:29:50Z

@Renzo-Olivares thanks for the review!

gspencergoog

auto-submit · 2024-04-01T20:08:03Z

auto label is removed for flutter/flutter/145819, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

ksokolovskyi · 2024-04-02T18:19:08Z

@Renzo-Olivares @gspencergoog could you please tell me why Google testing is failing?

Renzo-Olivares · 2024-04-02T18:29:17Z

@ksokolovskyi Can you try rebasing your branch with master. The failing tests look unrelated.

ksokolovskyi · 2024-04-02T19:39:32Z

@Renzo-Olivares still failing =(

Renzo-Olivares · 2024-04-02T19:52:41Z

@ksokolovskyi can you try the following, assuming you have upstream as one of your remote repos and set to the flutter sdk.

git fetch upstream
git rebase upstream/master
git push -f origin myBranch

auto-submit · 2024-04-02T22:54:43Z

auto label is removed for flutter/flutter/145819, due to - The status or check suite Windows tool_integration_tests_2_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-04-03T04:59:06Z

auto label is removed for flutter/flutter/145819, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

ksokolovskyi · 2024-04-04T06:49:52Z

@Renzo-Olivares @gspencergoog @goderbauer thanks for the review!

…utter#145819)

flutter/flutter@e868e2b...ac2ca93 2024-04-04 [email protected] Roll Flutter Engine from aadf522e3c98 to 4303dc0d7a73 (1 revision) (flutter/flutter#146262) 2024-04-04 [email protected] Roll Flutter Engine from c57c8665b4eb to aadf522e3c98 (1 revision) (flutter/flutter#146261) 2024-04-04 [email protected] Roll Flutter Engine from ca7596642cfd to c57c8665b4eb (1 revision) (flutter/flutter#146259) 2024-04-04 [email protected] Roll Flutter Engine from 83c037c449b5 to ca7596642cfd (1 revision) (flutter/flutter#146258) 2024-04-04 [email protected] Roll Flutter Engine from 614154012e93 to 83c037c449b5 (1 revision) (flutter/flutter#146255) 2024-04-04 [email protected] Roll Flutter Engine from 41da00ac46bc to 614154012e93 (1 revision) (flutter/flutter#146250) 2024-04-04 [email protected] Roll Flutter Engine from 18fdcad40332 to 41da00ac46bc (6 revisions) (flutter/flutter#146246) 2024-04-04 [email protected] Roll pub packages (flutter/flutter#146245) 2024-04-03 [email protected] Add tests for theme_extension.1.dart API example. (flutter/flutter#145819) 2024-04-03 [email protected] Roll Flutter Engine from 349608d2b008 to 18fdcad40332 (6 revisions) (flutter/flutter#146240) 2024-04-03 [email protected] Add `missing_code_block_language_in_doc_comment` lint. (flutter/flutter#145354) 2024-04-03 [email protected] Magnifier cleanup (flutter/flutter#143558) 2024-04-03 [email protected] Set up Kotlin linting step in ci with ktlint (flutter/flutter#143478) 2024-04-03 [email protected] Roll Flutter Engine from 1a9e48ab1c9a to 349608d2b008 (1 revision) (flutter/flutter#146230) 2024-04-03 [email protected] Update ownership to GitHub handles (flutter/flutter#146221) 2024-04-03 [email protected] Roll Flutter Engine from d065763b1a63 to 1a9e48ab1c9a (1 revision) (flutter/flutter#146226) 2024-04-03 [email protected] Refactor fuchsia_precache (flutter/flutter#145978) 2024-04-03 [email protected] Roll Flutter Engine from b1c23addaec5 to d065763b1a63 (1 revision) (flutter/flutter#146218) 2024-04-03 [email protected] `computeDryBaseline` for rendering / widgets RenderBoxes (flutter/flutter#146143) 2024-04-03 [email protected] Roll Flutter Engine from 7b28ae1d15cb to b1c23addaec5 (1 revision) (flutter/flutter#146214) 2024-04-03 [email protected] Fix TextStyle.lerp() to properly interpolate text shadows (flutter/flutter#145666) 2024-04-03 [email protected] Renderflex cross intrinsic size with baseline alignment (flutter/flutter#146185) 2024-04-03 [email protected] Roll Flutter Engine from 56fa2c33a5f7 to 7b28ae1d15cb (1 revision) (flutter/flutter#146208) 2024-04-03 [email protected] Refactor customer_testing (flutter/flutter#145911) 2024-04-03 [email protected] Add `DropdownMenu` cursor behavior sample (flutter/flutter#146133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Mar 27, 2024

Renzo-Olivares reviewed Mar 29, 2024

View reviewed changes

examples/api/test/material/theme/theme_extension.1_test.dart Outdated Show resolved Hide resolved

Renzo-Olivares approved these changes Mar 29, 2024

View reviewed changes

gspencergoog approved these changes Apr 1, 2024

View reviewed changes

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 1, 2024

ksokolovskyi force-pushed the add-theme-extension-example-tests branch from 78abbde to 377a2ac Compare April 2, 2024 20:11

ksokolovskyi added 2 commits April 2, 2024 15:17

Add tests for theme_extension.1.dart API example.

4e6590a

Add comments to describe the IconButton action

ca1b8f1

goderbauer force-pushed the add-theme-extension-example-tests branch from 377a2ac to ca1b8f1 Compare April 2, 2024 22:17

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 2, 2024

Merge branch 'master' into add-theme-extension-example-tests

7cf0675

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2024

Merge branch 'master' into add-theme-extension-example-tests

4b64649

gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 3, 2024

auto-submit bot merged commit 8101f13 into flutter:master Apr 3, 2024

engine-flutter-autoroll mentioned this pull request Apr 4, 2024

Roll Flutter from e868e2b3834f to ac2ca9347cf9 (25 revisions) flutter/packages#6460

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 4, 2024

8101f13 Add tests for theme_extension.1.dart API example. (flutter/fl…

a64676d

…utter#145819)

HansMuller mentioned this pull request Apr 5, 2024

Flutter Framework Team: Notable Commits #121415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for theme_extension.1.dart API example.#145819

Add tests for theme_extension.1.dart API example.#145819
auto-submit[bot] merged 4 commits intoflutter:masterfrom
ksokolovskyi:add-theme-extension-example-tests

ksokolovskyi commented Mar 27, 2024

Uh oh!

ksokolovskyi commented Mar 29, 2024

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Uh oh!

ksokolovskyi commented Mar 29, 2024

Uh oh!

gspencergoog left a comment

Uh oh!

auto-submit bot commented Apr 1, 2024

Uh oh!

ksokolovskyi commented Apr 2, 2024

Uh oh!

Renzo-Olivares commented Apr 2, 2024

Uh oh!

ksokolovskyi commented Apr 2, 2024

Uh oh!

Renzo-Olivares commented Apr 2, 2024 •

edited

Loading

Uh oh!

auto-submit bot commented Apr 2, 2024

Uh oh!

auto-submit bot commented Apr 3, 2024

Uh oh!

ksokolovskyi commented Apr 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ksokolovskyi commented Mar 27, 2024

Description

Pre-launch Checklist

Uh oh!

ksokolovskyi commented Mar 29, 2024

Uh oh!

Uh oh!

Renzo-Olivares left a comment

Choose a reason for hiding this comment

Uh oh!

ksokolovskyi commented Mar 29, 2024

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Apr 1, 2024

Uh oh!

ksokolovskyi commented Apr 2, 2024

Uh oh!

Renzo-Olivares commented Apr 2, 2024

Uh oh!

ksokolovskyi commented Apr 2, 2024

Uh oh!

Renzo-Olivares commented Apr 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auto-submit bot commented Apr 2, 2024

Uh oh!

auto-submit bot commented Apr 3, 2024

Uh oh!

ksokolovskyi commented Apr 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Renzo-Olivares commented Apr 2, 2024 •

edited

Loading