Revert "Reduce xcodebuild noise #2"#14641
Merged
mravn-google merged 2 commits intomasterfrom Feb 12, 2018
Merged
Conversation
Member
|
RSLGTM |
Merged
xster
added a commit
to xster/flutter
that referenced
this pull request
Feb 13, 2018
This reverts commit 2d47481.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Merging to get back to a green tree.
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Revert "Revert "Reduce xcodebuild noise flutter#2" (flutter#14641)" This reverts commit 2d47481. * Stop scrapping xcodebuild output, get the right build settings * clone the command params first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #14622
Reducing Xcode output seems to mean we fail to detect the target .app file, cf. #14640