Merged
Conversation
mravn-google
approved these changes
Feb 13, 2018
|
|
||
| // Run -showBuildSettings again but with the exact same parameters as the build. | ||
| final Map<String, String> buildSettings = parseXcodeBuildSettings(runCheckedSync( | ||
| buildCommands..add('-showBuildSettings'), |
Contributor
There was a problem hiding this comment.
I suggest we pass in a new list with the added flag rather than mutate buildCommands. It is used later for diagnostics and I believe it should reflect the actual command line that produced the buildResult above.
Just to avoid any surprises down the road.
Member
Author
There was a problem hiding this comment.
Oh ya, totally good point. Thanks.
| final String expectedOutputDirectory = fs.path.join( | ||
| buildSettings['TARGET_BUILD_DIR'], | ||
| buildSettings['WRAPPER_NAME'], | ||
| ); |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Revert "Revert "Reduce xcodebuild noise flutter#2" (flutter#14641)" This reverts commit 2d47481. * Stop scrapping xcodebuild output, get the right build settings * clone the command params first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third time's a charm
Unreverts #14641
Fixes #13104
Reduces xcodebuild fluff.
Also stops scrapping xcodebuild output as a critical path to building successfully. Fixes #14657
Fixes an issue where the build settings used to diagnose xcode build failures may not be the same settings used to build. Fixes #14661